You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/01 22:42:45 UTC

[GitHub] [beam] ibzib commented on a change in pull request #11584: [BEAM-9136]support isRelease tag for docker build command & update release guide

ibzib commented on a change in pull request #11584:
URL: https://github.com/apache/beam/pull/11584#discussion_r418767547



##########
File path: website/src/contribute/release-guide.md
##########
@@ -688,8 +688,20 @@ Verify that files are [present](https://dist.apache.org/repos/dist/dev/beam).
 * Build Python images and push to DockerHub.
 
 ```
-./gradlew :sdks:python:container:buildAll -Pdocker-tag=${RELEASE}_rc{RC_NUM}
+./gradlew :sdks:python:container:buildAll -Pdocker-pull-licenses -Pdocker-tag=${RELEASE}_rc{RC_NUM}
+```
+
+Verify that third party licenses are included by logging in to the images. For Python SDK images, there should be around 80 ~ 100 dependencies. 
+Please note that dependencies for the SDKs with different Python versions vary. 
+Need to verify all Python images by replacing `${ver}` in the following command to `python2.7, python3.5, python3.6, python3.7`.

Review comment:
       Ack, thanks for the heads up




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org