You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by GitBox <gi...@apache.org> on 2019/09/19 14:09:54 UTC

[GitHub] [wicket] espyrop commented on a change in pull request #383: Configurable contentDisposition

espyrop commented on a change in pull request #383: Configurable contentDisposition
URL: https://github.com/apache/wicket/pull/383#discussion_r326195740
 
 

 ##########
 File path: wicket-core/src/main/java/org/apache/wicket/markup/html/link/DownloadLink.java
 ##########
 @@ -65,6 +65,14 @@
 	 */
 	private Duration cacheDuration;
 
+	/**
+	 * Controls if the browser will save the file or display it inline.
+	 * <p>
+	 * The default is ATTACHMENT to maintain backward compatibility.
 
 Review comment:
   I have no objection to that. 
   Since I am not familiar with the github workflow: Must I adjust this text, or you will do it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services