You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shai Erera (JIRA)" <ji...@apache.org> on 2010/04/16 00:06:50 UTC

[jira] Created: (LUCENE-2397) SnapshotDeletionPolicy.snapshot() throws NPE if no commits happened

SnapshotDeletionPolicy.snapshot() throws NPE if no commits happened
-------------------------------------------------------------------

                 Key: LUCENE-2397
                 URL: https://issues.apache.org/jira/browse/LUCENE-2397
             Project: Lucene - Java
          Issue Type: Improvement
          Components: Index
            Reporter: Shai Erera
            Assignee: Shai Erera
            Priority: Minor
             Fix For: 3.1


SDP throws NPE if no commits occurred and snapshot() was called. I will replace it w/ throwing IllegalStateException. I'll also move TestSDP from o.a.l to o.a.l,index. I'll post a patch soon

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-2397) SnapshotDeletionPolicy.snapshot() throws NPE if no commits happened

Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shai Erera resolved LUCENE-2397.
--------------------------------

    Resolution: Fixed

Committed revision 935522.

> SnapshotDeletionPolicy.snapshot() throws NPE if no commits happened
> -------------------------------------------------------------------
>
>                 Key: LUCENE-2397
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2397
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.1
>
>         Attachments: LUCENE-2397.patch
>
>
> SDP throws NPE if no commits occurred and snapshot() was called. I will replace it w/ throwing IllegalStateException. I'll also move TestSDP from o.a.l to o.a.l,index. I'll post a patch soon

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Commented: (LUCENE-2397) SnapshotDeletionPolicy.snapshot() throws NPE if no commits happened

Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858388#action_12858388 ] 

Shai Erera commented on LUCENE-2397:
------------------------------------

I plan to commit this shortly.

> SnapshotDeletionPolicy.snapshot() throws NPE if no commits happened
> -------------------------------------------------------------------
>
>                 Key: LUCENE-2397
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2397
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.1
>
>         Attachments: LUCENE-2397.patch
>
>
> SDP throws NPE if no commits occurred and snapshot() was called. I will replace it w/ throwing IllegalStateException. I'll also move TestSDP from o.a.l to o.a.l,index. I'll post a patch soon

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Updated: (LUCENE-2397) SnapshotDeletionPolicy.snapshot() throws NPE if no commits happened

Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shai Erera updated LUCENE-2397:
-------------------------------

    Attachment: LUCENE-2397.patch

Patch fixes SDP, adds relevant test to TestSDP and move TestSDP to o.a.l.index. To apply the patch you first need to run:

svn mv lucene/src/test/org/apache/lucene/TestSnapshotDeletionPolicy.java lucene/src/test/org/apache/lucene/index/TestSnapshotDeletionPolicy.java

> SnapshotDeletionPolicy.snapshot() throws NPE if no commits happened
> -------------------------------------------------------------------
>
>                 Key: LUCENE-2397
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2397
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.1
>
>         Attachments: LUCENE-2397.patch
>
>
> SDP throws NPE if no commits occurred and snapshot() was called. I will replace it w/ throwing IllegalStateException. I'll also move TestSDP from o.a.l to o.a.l,index. I'll post a patch soon

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org