You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Delos Dai (JIRA)" <ji...@apache.org> on 2008/08/18 04:56:44 UTC
[jira] Created: (GERONIMODEVTOOLS-482) missing image for GEP
features in "About Eclipse Platform" Dialog
missing image for GEP features in "About Eclipse Platform" Dialog
-----------------------------------------------------------------
Key: GERONIMODEVTOOLS-482
URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482
Project: Geronimo-Devtools
Issue Type: Bug
Components: eclipse-plugin
Affects Versions: 2.1.2
Environment: build in Ubuntu 8.04 and Windows XP sp2. Jdk 1.5
Reporter: Delos Dai
Assignee: Tim McConnell
After I successfully build GEP with "mvn install", I get the package "geronimo-eclipse-plugin-2.1.2-deployable.zip" in assembly/target.
"geronimo-eclipse-plugin-2.1.2-deployable.zip" should be the distribution to user. But when I install GEP of this package, I found the image for GEP feature is missed in "About Eclipse Platform" dialog (see the attachment). In fact, you may find the image file in the package is broken. But I can see the image when I develop GEP in eclipse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-482) missing image for GEP
features in "About Eclipse Platform" Dialog
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623401#action_12623401 ]
Jarek Gawor commented on GERONIMODEVTOOLS-482:
----------------------------------------------
Btw, I see the icon but it is a little messed up. Also, I just noticed that the About "Apache Geronimo v2.1 Server Adapter" window has an invalid link in "Visit http://www.apache.org/licenses/LICENSE-2.0.txt/ for additional details" (has extra slash).
> missing image for GEP features in "About Eclipse Platform" Dialog
> -----------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-482
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.1.2
> Environment: build in Ubuntu 8.04 and Windows XP sp2. Jdk 1.5
> Reporter: Delos Dai
> Assignee: Tim McConnell
> Attachments: screenshot-1.jpg
>
>
> After I successfully build GEP with "mvn install", I get the package "geronimo-eclipse-plugin-2.1.2-deployable.zip" in assembly/target.
> "geronimo-eclipse-plugin-2.1.2-deployable.zip" should be the distribution to user. But when I install GEP of this package, I found the image for GEP feature is missed in "About Eclipse Platform" dialog (see the attachment). In fact, you may find the image file in the package is broken. But I can see the image when I develop GEP in eclipse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-482) missing image for GEP
features in "About Eclipse Platform" Dialog
Posted by "Ted Kirby (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623411#action_12623411 ]
Ted Kirby commented on GERONIMODEVTOOLS-482:
--------------------------------------------
Thanks Delos and Jarek. I fixed the license URL is 686821 and 686822. It does look like the plugins/org.apache.geronimo.st.v21.core/G-logo-32x32.gif file from the staging site is bad. It looks good in svn. Must have been corrupted in the build, or downloading to the build machine?
> missing image for GEP features in "About Eclipse Platform" Dialog
> -----------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-482
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.1.2
> Environment: build in Ubuntu 8.04 and Windows XP sp2. Jdk 1.5
> Reporter: Delos Dai
> Assignee: Tim McConnell
> Attachments: screenshot-1.jpg
>
>
> After I successfully build GEP with "mvn install", I get the package "geronimo-eclipse-plugin-2.1.2-deployable.zip" in assembly/target.
> "geronimo-eclipse-plugin-2.1.2-deployable.zip" should be the distribution to user. But when I install GEP of this package, I found the image for GEP feature is missed in "About Eclipse Platform" dialog (see the attachment). In fact, you may find the image file in the package is broken. But I can see the image when I develop GEP in eclipse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-482) missing image for GEP
features in "About Eclipse Platform" Dialog
Posted by "Delos Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623949#action_12623949 ]
Delos Dai commented on GERONIMODEVTOOLS-482:
--------------------------------------------
Tim, thank you for your help.
With the URL you gave, I found no problem of the image. I think I got wrong version. Sorry for the mistake. Thank you again!
> missing image for GEP features in "About Eclipse Platform" Dialog
> -----------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-482
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.1.2
> Environment: build in Ubuntu 8.04 and Windows XP sp2. Jdk 1.5
> Reporter: Delos Dai
> Assignee: Tim McConnell
> Fix For: 2.1.2
>
> Attachments: screenshot-1.jpg
>
>
> After I successfully build GEP with "mvn install", I get the package "geronimo-eclipse-plugin-2.1.2-deployable.zip" in assembly/target.
> "geronimo-eclipse-plugin-2.1.2-deployable.zip" should be the distribution to user. But when I install GEP of this package, I found the image for GEP feature is missed in "About Eclipse Platform" dialog (see the attachment). In fact, you may find the image file in the package is broken. But I can see the image when I develop GEP in eclipse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMODEVTOOLS-482) missing image for GEP
features in "About Eclipse Platform" Dialog
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell resolved GERONIMODEVTOOLS-482.
--------------------------------------------
Resolution: Fixed
Have to ensure that filtering is not enabled when a binary resource is getting copied as it may actually alter that resource. That was the case here -- the G-logo-32x32.gif file was getting inadvertently altered (apparently because the maven-resource-plugin found something to substitute) and corrupted it in the resulting plugin jarfile.
> missing image for GEP features in "About Eclipse Platform" Dialog
> -----------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-482
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.1.2
> Environment: build in Ubuntu 8.04 and Windows XP sp2. Jdk 1.5
> Reporter: Delos Dai
> Assignee: Tim McConnell
> Fix For: 2.1.2
>
> Attachments: screenshot-1.jpg
>
>
> After I successfully build GEP with "mvn install", I get the package "geronimo-eclipse-plugin-2.1.2-deployable.zip" in assembly/target.
> "geronimo-eclipse-plugin-2.1.2-deployable.zip" should be the distribution to user. But when I install GEP of this package, I found the image for GEP feature is missed in "About Eclipse Platform" dialog (see the attachment). In fact, you may find the image file in the package is broken. But I can see the image when I develop GEP in eclipse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMODEVTOOLS-482) missing image for GEP
features in "About Eclipse Platform" Dialog
Posted by "Delos Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Delos Dai updated GERONIMODEVTOOLS-482:
---------------------------------------
Attachment: screenshot-1.jpg
The last image is missing
> missing image for GEP features in "About Eclipse Platform" Dialog
> -----------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-482
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.1.2
> Environment: build in Ubuntu 8.04 and Windows XP sp2. Jdk 1.5
> Reporter: Delos Dai
> Assignee: Tim McConnell
> Attachments: screenshot-1.jpg
>
>
> After I successfully build GEP with "mvn install", I get the package "geronimo-eclipse-plugin-2.1.2-deployable.zip" in assembly/target.
> "geronimo-eclipse-plugin-2.1.2-deployable.zip" should be the distribution to user. But when I install GEP of this package, I found the image for GEP feature is missed in "About Eclipse Platform" dialog (see the attachment). In fact, you may find the image file in the package is broken. But I can see the image when I develop GEP in eclipse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-482) missing image for GEP
features in "About Eclipse Platform" Dialog
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623887#action_12623887 ]
Tim McConnell commented on GERONIMODEVTOOLS-482:
------------------------------------------------
Hi Delos, are you using the newest RC2 subdirectory on the staging site to pick up the "geronimo-eclipse-plugin-2.1.2-updatesite.zip" ?? I just downloaded it and checked all occurrences of the G-logo-32x32.gif file and it is not corrupted. Here is the correct site you should be downloading from:
-----> http://people.apache.org/~mcconne/releases/2.1.2/RC2/
Would you be able to double-check to ensure you are getting the correct version ?? The best way is to look at the "about.ini" file in the "org.apache.geronimo.st.v21.core_2.1.2.jar" and you'll see that the version number is:
2.1.2-20080818173711
BTW, I never did thank you for originally finding this problem. It is very much appreciated.
> missing image for GEP features in "About Eclipse Platform" Dialog
> -----------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-482
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.1.2
> Environment: build in Ubuntu 8.04 and Windows XP sp2. Jdk 1.5
> Reporter: Delos Dai
> Assignee: Tim McConnell
> Fix For: 2.1.2
>
> Attachments: screenshot-1.jpg
>
>
> After I successfully build GEP with "mvn install", I get the package "geronimo-eclipse-plugin-2.1.2-deployable.zip" in assembly/target.
> "geronimo-eclipse-plugin-2.1.2-deployable.zip" should be the distribution to user. But when I install GEP of this package, I found the image for GEP feature is missed in "About Eclipse Platform" dialog (see the attachment). In fact, you may find the image file in the package is broken. But I can see the image when I develop GEP in eclipse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-482) missing image for GEP
features in "About Eclipse Platform" Dialog
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623413#action_12623413 ]
Tim McConnell commented on GERONIMODEVTOOLS-482:
------------------------------------------------
Hi Ted, thanks for fixing the URL problem. I'm working on the icon problem. Looks to be as you suggest -- getting corrupted as part of the build....
> missing image for GEP features in "About Eclipse Platform" Dialog
> -----------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-482
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.1.2
> Environment: build in Ubuntu 8.04 and Windows XP sp2. Jdk 1.5
> Reporter: Delos Dai
> Assignee: Tim McConnell
> Attachments: screenshot-1.jpg
>
>
> After I successfully build GEP with "mvn install", I get the package "geronimo-eclipse-plugin-2.1.2-deployable.zip" in assembly/target.
> "geronimo-eclipse-plugin-2.1.2-deployable.zip" should be the distribution to user. But when I install GEP of this package, I found the image for GEP feature is missed in "About Eclipse Platform" dialog (see the attachment). In fact, you may find the image file in the package is broken. But I can see the image when I develop GEP in eclipse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-482) missing image for GEP
features in "About Eclipse Platform" Dialog
Posted by "Ted Kirby (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623395#action_12623395 ]
Ted Kirby commented on GERONIMODEVTOOLS-482:
--------------------------------------------
I think I do recall seeing the image a little messed up when I installed GEP 2.1.2 from the staging site. I got an image close to the correct one, not the red X you got. Can you try using the staging site, and see if you get a good image?
> missing image for GEP features in "About Eclipse Platform" Dialog
> -----------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-482
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.1.2
> Environment: build in Ubuntu 8.04 and Windows XP sp2. Jdk 1.5
> Reporter: Delos Dai
> Assignee: Tim McConnell
> Attachments: screenshot-1.jpg
>
>
> After I successfully build GEP with "mvn install", I get the package "geronimo-eclipse-plugin-2.1.2-deployable.zip" in assembly/target.
> "geronimo-eclipse-plugin-2.1.2-deployable.zip" should be the distribution to user. But when I install GEP of this package, I found the image for GEP feature is missed in "About Eclipse Platform" dialog (see the attachment). In fact, you may find the image file in the package is broken. But I can see the image when I develop GEP in eclipse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMODEVTOOLS-482) missing image for GEP
features in "About Eclipse Platform" Dialog
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated GERONIMODEVTOOLS-482:
-------------------------------------------
Fix Version/s: 2.1.2
> missing image for GEP features in "About Eclipse Platform" Dialog
> -----------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-482
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.1.2
> Environment: build in Ubuntu 8.04 and Windows XP sp2. Jdk 1.5
> Reporter: Delos Dai
> Assignee: Tim McConnell
> Fix For: 2.1.2
>
> Attachments: screenshot-1.jpg
>
>
> After I successfully build GEP with "mvn install", I get the package "geronimo-eclipse-plugin-2.1.2-deployable.zip" in assembly/target.
> "geronimo-eclipse-plugin-2.1.2-deployable.zip" should be the distribution to user. But when I install GEP of this package, I found the image for GEP feature is missed in "About Eclipse Platform" dialog (see the attachment). In fact, you may find the image file in the package is broken. But I can see the image when I develop GEP in eclipse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-482) missing image for GEP
features in "About Eclipse Platform" Dialog
Posted by "Ted Kirby (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623392#action_12623392 ]
Ted Kirby commented on GERONIMODEVTOOLS-482:
--------------------------------------------
What do you mean by "should be the distribution to user"? I would say the updatesite.zip file is the much preferred user deliverable. unzipping deployable.zip to the ganymede eclipse directory is a decidedly bad idea. It is not clear to me that you should reasonably expect the about function to work using a deployable.zip install. Maybe we should only deliver GEP via an updatesite.zip file, and stop building deployable.zip altogether.
> missing image for GEP features in "About Eclipse Platform" Dialog
> -----------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-482
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.1.2
> Environment: build in Ubuntu 8.04 and Windows XP sp2. Jdk 1.5
> Reporter: Delos Dai
> Assignee: Tim McConnell
> Attachments: screenshot-1.jpg
>
>
> After I successfully build GEP with "mvn install", I get the package "geronimo-eclipse-plugin-2.1.2-deployable.zip" in assembly/target.
> "geronimo-eclipse-plugin-2.1.2-deployable.zip" should be the distribution to user. But when I install GEP of this package, I found the image for GEP feature is missed in "About Eclipse Platform" dialog (see the attachment). In fact, you may find the image file in the package is broken. But I can see the image when I develop GEP in eclipse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-482) missing image for GEP
features in "About Eclipse Platform" Dialog
Posted by "Delos Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623638#action_12623638 ]
Delos Dai commented on GERONIMODEVTOOLS-482:
--------------------------------------------
Hi, All
Thank you for your quick help!
About the missing icon, I strongly agree with Tim's opinion "That was the case here -- the G-logo-32x32.gif file was getting inadvertently altered (apparently because the maven-resource-plugin found something to substitute) and corrupted it in the resulting plugin jarfile."
But although Tim has prevent the GIF file from being filtered, I still can't see the icon in "about eclipse platform" dialog, even with staging site. The problem still exists.
In fact, if you extract out the GIF file in "org.apache.geronimo.st.v21.core_2.1.2.jar" of "geronimo-eclipse-plugin-2.1.2-updatesite.zip", you will find the GIF file has been broken and can't be opened.
Besides the maven plugin used for filtering, is there any other code might corrupt the GIF file?
> missing image for GEP features in "About Eclipse Platform" Dialog
> -----------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-482
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-482
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.1.2
> Environment: build in Ubuntu 8.04 and Windows XP sp2. Jdk 1.5
> Reporter: Delos Dai
> Assignee: Tim McConnell
> Fix For: 2.1.2
>
> Attachments: screenshot-1.jpg
>
>
> After I successfully build GEP with "mvn install", I get the package "geronimo-eclipse-plugin-2.1.2-deployable.zip" in assembly/target.
> "geronimo-eclipse-plugin-2.1.2-deployable.zip" should be the distribution to user. But when I install GEP of this package, I found the image for GEP feature is missed in "About Eclipse Platform" dialog (see the attachment). In fact, you may find the image file in the package is broken. But I can see the image when I develop GEP in eclipse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.