[jira] [Commented] (OFBIZ-7969) Enable adding a content to an agreement

["Deepak Dixit (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-7969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446627#comment-15446627 ] 

Deepak Dixit commented on OFBIZ-7969:
-------------------------------------

Hi  Leila,

I reviewed your patch it looks good to me, some I found some improvement in this patch here is the list of improvement:

- Add service to createAgreementContent you can refer uploadPartyContent service for the same.
- Instead of saying createAgreementContent you can rename it to uploadAgreementContent 
- Use entity-auto for basic CRUD operation for AgreementContent. 
- Instead of creating FILE as agreement content type you can use some related name, FILE is more generic name.

> Enable adding a content to an agreement
> ---------------------------------------
>
>                 Key: OFBIZ-7969
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7969
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Leila Mekika
>            Priority: Minor
>         Attachments: OFBIZ-7969.patch, OFBIZ-7969_V2 .patch
>
>
> This add a screen in accounting component to allow uploading a file or attach an existing content to an agreement. This can be useful to attach agreement related contract or files.
> To test this functionnality, you need to reload seed data, create an agreement and go to page :
> http://localhost:8080/accounting/control/EditAgreementContents?agreementId=XXXX



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)