You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/08/05 10:09:55 UTC

[GitHub] [hudi] codope opened a new pull request, #6313: [HUDI-4550] Fallback to listing based rollback for completed instant

codope opened a new pull request, #6313:
URL: https://github.com/apache/hudi/pull/6313

   ## What is the purpose of the pull request
   
   Ideally, rollback is not triggered for completed instants. However, if it gets triggered due to some extraneous condition or forced while rollback strategy still configured to be marker-based, then fallback to listing-based rollback instead of failing.
   
   ## Brief change log
   
     - CTOR changes in rollback plan and action executors.
     - Change in condition to determine whether to use marker-based rollback.
     - Added UT to cover the scenario. 
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6313: [HUDI-4550] Fallback to listing based rollback for completed instant

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6313:
URL: https://github.com/apache/hudi/pull/6313#issuecomment-1206290058

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2d1931b2f622e2ae524068464c7b5bc4d6bdd5ac",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10611",
       "triggerID" : "2d1931b2f622e2ae524068464c7b5bc4d6bdd5ac",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2d1931b2f622e2ae524068464c7b5bc4d6bdd5ac Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10611) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #6313: [HUDI-4550] Fallback to listing based rollback for completed instant

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #6313:
URL: https://github.com/apache/hudi/pull/6313#issuecomment-1206775532

   again, let's try to understand how did we end up in this state. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6313: [HUDI-4550] Fallback to listing based rollback for completed instant

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6313:
URL: https://github.com/apache/hudi/pull/6313#issuecomment-1206286175

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2d1931b2f622e2ae524068464c7b5bc4d6bdd5ac",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2d1931b2f622e2ae524068464c7b5bc4d6bdd5ac",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2d1931b2f622e2ae524068464c7b5bc4d6bdd5ac UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6313: [HUDI-4550] Fallback to listing based rollback for completed instant

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6313:
URL: https://github.com/apache/hudi/pull/6313#issuecomment-1206351949

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2d1931b2f622e2ae524068464c7b5bc4d6bdd5ac",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10611",
       "triggerID" : "2d1931b2f622e2ae524068464c7b5bc4d6bdd5ac",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2d1931b2f622e2ae524068464c7b5bc4d6bdd5ac Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10611) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codope commented on pull request #6313: [HUDI-4550] Fallback to listing based rollback for completed instant

Posted by GitBox <gi...@apache.org>.
codope commented on PR #6313:
URL: https://github.com/apache/hudi/pull/6313#issuecomment-1207230430

   Successful CI https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=10638&view=results


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codope merged pull request #6313: [HUDI-4550] Fallback to listing based rollback for completed instant

Posted by GitBox <gi...@apache.org>.
codope merged PR #6313:
URL: https://github.com/apache/hudi/pull/6313


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6313: [HUDI-4550] Fallback to listing based rollback for completed instant

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6313:
URL: https://github.com/apache/hudi/pull/6313#issuecomment-1207207648

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "98d25790dc97e48f17d19b2b52d0c55131338d6d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "98d25790dc97e48f17d19b2b52d0c55131338d6d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 98d25790dc97e48f17d19b2b52d0c55131338d6d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6313: [HUDI-4550] Fallback to listing based rollback for completed instant

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6313:
URL: https://github.com/apache/hudi/pull/6313#issuecomment-1207220115

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "98d25790dc97e48f17d19b2b52d0c55131338d6d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10638",
       "triggerID" : "98d25790dc97e48f17d19b2b52d0c55131338d6d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8479da51618f56e3909d486f4c09ec533648e153",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10636",
       "triggerID" : "8479da51618f56e3909d486f4c09ec533648e153",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 98d25790dc97e48f17d19b2b52d0c55131338d6d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10638) 
   * 8479da51618f56e3909d486f4c09ec533648e153 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10636) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6313: [HUDI-4550] Fallback to listing based rollback for completed instant

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6313:
URL: https://github.com/apache/hudi/pull/6313#issuecomment-1207229011

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "98d25790dc97e48f17d19b2b52d0c55131338d6d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10638",
       "triggerID" : "98d25790dc97e48f17d19b2b52d0c55131338d6d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8479da51618f56e3909d486f4c09ec533648e153",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10636",
       "triggerID" : "8479da51618f56e3909d486f4c09ec533648e153",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8479da51618f56e3909d486f4c09ec533648e153 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10636) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6313: [HUDI-4550] Fallback to listing based rollback for completed instant

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6313:
URL: https://github.com/apache/hudi/pull/6313#issuecomment-1207219406

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "98d25790dc97e48f17d19b2b52d0c55131338d6d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10638",
       "triggerID" : "98d25790dc97e48f17d19b2b52d0c55131338d6d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8479da51618f56e3909d486f4c09ec533648e153",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8479da51618f56e3909d486f4c09ec533648e153",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 98d25790dc97e48f17d19b2b52d0c55131338d6d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10638) 
   * 8479da51618f56e3909d486f4c09ec533648e153 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6313: [HUDI-4550] Fallback to listing based rollback for completed instant

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6313:
URL: https://github.com/apache/hudi/pull/6313#issuecomment-1207199608

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2d1931b2f622e2ae524068464c7b5bc4d6bdd5ac",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10611",
       "triggerID" : "2d1931b2f622e2ae524068464c7b5bc4d6bdd5ac",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8479da51618f56e3909d486f4c09ec533648e153",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8479da51618f56e3909d486f4c09ec533648e153",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2d1931b2f622e2ae524068464c7b5bc4d6bdd5ac Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10611) 
   * 8479da51618f56e3909d486f4c09ec533648e153 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6313: [HUDI-4550] Fallback to listing based rollback for completed instant

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6313:
URL: https://github.com/apache/hudi/pull/6313#issuecomment-1207200124

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2d1931b2f622e2ae524068464c7b5bc4d6bdd5ac",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10611",
       "triggerID" : "2d1931b2f622e2ae524068464c7b5bc4d6bdd5ac",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8479da51618f56e3909d486f4c09ec533648e153",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10636",
       "triggerID" : "8479da51618f56e3909d486f4c09ec533648e153",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98d25790dc97e48f17d19b2b52d0c55131338d6d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "98d25790dc97e48f17d19b2b52d0c55131338d6d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8479da51618f56e3909d486f4c09ec533648e153 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10636) 
   * 98d25790dc97e48f17d19b2b52d0c55131338d6d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codope commented on pull request #6313: [HUDI-4550] Fallback to listing based rollback for completed instant

Posted by GitBox <gi...@apache.org>.
codope commented on PR #6313:
URL: https://github.com/apache/hudi/pull/6313#issuecomment-1207227704

   > LGTM. but lets see if we can find the root cause as to why this could happen
   
   Yeah we will keep HUDI-4550 and the original issue open for investigation. Fallback to listing-based rollback should be safe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6313: [HUDI-4550] Fallback to listing based rollback for completed instant

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6313:
URL: https://github.com/apache/hudi/pull/6313#issuecomment-1207208873

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "98d25790dc97e48f17d19b2b52d0c55131338d6d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10638",
       "triggerID" : "98d25790dc97e48f17d19b2b52d0c55131338d6d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 98d25790dc97e48f17d19b2b52d0c55131338d6d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10638) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org