[jira] [Created] (HDFS-14340) Lower the log level when can't get postOpAttr

["Anuhan Torgonshar (JIRA)" <ji...@apache.org>]

Anuhan Torgonshar created HDFS-14340:
----------------------------------------

             Summary: Lower the log level when can't get postOpAttr
                 Key: HDFS-14340
                 URL: https://issues.apache.org/jira/browse/HDFS-14340
             Project: Hadoop HDFS
          Issue Type: Improvement
          Components: nfs
    Affects Versions: 2.8.5, 3.1.0
            Reporter: Anuhan Torgonshar
         Attachments: RpcProgramNfs3.java

I think should lower the log level when can't get postOpAttr in _*hadoop-2.8.5-src/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/**RpcProgramNfs3.java*_. 

 
{code:java}
//the problematic log level ERROR, at line 1044
try {
   dirWcc = Nfs3Utils.createWccData(Nfs3Utils.getWccAttr(preOpDirAttr),
   dfsClient, dirFileIdPath, iug);
} catch (IOException e1) {
   LOG.error("Can't get postOpDirAttr for dirFileId: "
   + dirHandle.getFileId(), e1);
}

//other practice in similar code snippets, line number is 475, the log assigned with INFO level
try { 
   wccData = Nfs3Utils.createWccData(Nfs3Utils.getWccAttr(preOpAttr), dfsClient,   fileIdPath, iug); 
} catch (IOException e1) { 
   LOG.info("Can't get postOpAttr for fileIdPath: " + fileIdPath, e1); 
}

//other practice in similar code snippets, line number is 1405, the log assigned with INFO level
try {
   fromDirWcc = Nfs3Utils.createWccData(
   Nfs3Utils.getWccAttr(fromPreOpAttr), dfsClient, fromDirFileIdPath,iug);
   toDirWcc = Nfs3Utils.createWccData(Nfs3Utils.getWccAttr(toPreOpAttr),
   dfsClient, toDirFileIdPath, iug);
} catch (IOException e1) {
   LOG.info("Can't get postOpDirAttr for " + fromDirFileIdPath + " or"
   + toDirFileIdPath, e1);
}


{code}
Therefore, I think the logging practices should be consistent in similar contexts. When the code catches _*IOException*_ for *_getWccAttr()_* method, it more likely prints a log message with _*INFO*_ level, a lower level.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org