[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9138: [mypy] Enforcing typing for db_engine_specs

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #9138: [mypy] Enforcing typing for db_engine_specs
URL: https://github.com/apache/incubator-superset/pull/9138#discussion_r379242176
 
 

 ##########
 File path: superset/db_engine_specs/base.py
 ##########
 @@ -132,7 +138,9 @@ def get_allow_cost_estimate(cls, version: str = None) -> bool:
         return False
 
     @classmethod
-    def get_engine(cls, database, schema=None, source=None):
+    def get_engine(
+        cls, database: Database, schema: str = None, source: str = None
 
 Review comment:
   If you've enabled `no implicit optional` shouldn't these be `Optional[str]`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org