You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2017/09/18 06:00:11 UTC

Review Request 62375: RANGER-1787: User has to fill up all the allow and deny conditions items to create a knox policy.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62375/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Mehul Parikh, and Velmurugan Periasamy.


Bugs: RANGER-1787
    https://issues.apache.org/jira/browse/RANGER-1787


Repository: ranger


Description
-------

In Ranger UI -> While creating any policy, policy conditions are not mandatory. 
But while creating/editing a knox policy, user has to add users and groups in all the allow and deny conditions(have to add users/groups in allow, exclude allow, deny and exclude deny) or else user will get pop-up error "Please select group/user for the selected permission, else group/user will not be added." 
This pop-up error is shown even though the user/groups are there in Allow Condition.


Diffs
-----

  security-admin/src/main/webapp/scripts/views/policies/PermissionList.js bb64984 


Diff: https://reviews.apache.org/r/62375/diff/1/


Testing
-------

Verified cases :
- Knox policy screen does not select access type default even if it contains single access type.
- Able to create policy without modifying policy conditions in Knox component.
- Also verified same scenarios for others component.


Thanks,

Nitin Galave


Re: Review Request 62375: RANGER-1787: User has to fill up all the allow and deny conditions items to create a knox policy.

Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62375/#review185676
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On Sept. 18, 2017, 6 a.m., Nitin Galave wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62375/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2017, 6 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Mehul Parikh, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1787
>     https://issues.apache.org/jira/browse/RANGER-1787
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> In Ranger UI -> While creating any policy, policy conditions are not mandatory. 
> But while creating/editing a knox policy, user has to add users and groups in all the allow and deny conditions(have to add users/groups in allow, exclude allow, deny and exclude deny) or else user will get pop-up error "Please select group/user for the selected permission, else group/user will not be added." 
> This pop-up error is shown even though the user/groups are there in Allow Condition.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/views/policies/PermissionList.js bb64984 
> 
> 
> Diff: https://reviews.apache.org/r/62375/diff/1/
> 
> 
> Testing
> -------
> 
> Verified cases :
> - Knox policy screen does not select access type default even if it contains single access type.
> - Able to create policy without modifying policy conditions in Knox component.
> - Also verified same scenarios for others component.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>


Re: Review Request 62375: RANGER-1787: User has to fill up all the allow and deny conditions items to create a knox policy.

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62375/#review185563
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Sept. 18, 2017, 6 a.m., Nitin Galave wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62375/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2017, 6 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Mehul Parikh, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1787
>     https://issues.apache.org/jira/browse/RANGER-1787
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> In Ranger UI -> While creating any policy, policy conditions are not mandatory. 
> But while creating/editing a knox policy, user has to add users and groups in all the allow and deny conditions(have to add users/groups in allow, exclude allow, deny and exclude deny) or else user will get pop-up error "Please select group/user for the selected permission, else group/user will not be added." 
> This pop-up error is shown even though the user/groups are there in Allow Condition.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/views/policies/PermissionList.js bb64984 
> 
> 
> Diff: https://reviews.apache.org/r/62375/diff/1/
> 
> 
> Testing
> -------
> 
> Verified cases :
> - Knox policy screen does not select access type default even if it contains single access type.
> - Able to create policy without modifying policy conditions in Knox component.
> - Also verified same scenarios for others component.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>