You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/11/10 13:05:43 UTC
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #1214: MINIFICPP-1683 Revert github actions caching changes
lordgamez opened a new pull request #1214:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1214
Recently caching was changed to only keep a single cache key for each branch and update the cache content for that key in every CI build. This was done to save space so it would take longer for the older branch caches (especially main) to be evicted due to the 5GB cache space per repository. Unfortunately github cache actions does not support updating the cache content for a key because caches are immutable:
- https://github.com/actions/cache/issues/171
- https://github.com/actions/cache/issues/109
https://issues.apache.org/jira/browse/MINIFICPP-1683
------------------------------------------------------------------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #1214: MINIFICPP-1683 Revert github actions caching changes
Posted by GitBox <gi...@apache.org>.
szaszm commented on pull request #1214:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1214#issuecomment-965127443
Could we only cache builds on main and always restore the cache of main, regardless of the branch? It should be relatively close to most branches, so we would get the most benefit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni closed pull request #1214: MINIFICPP-1683 Revert github actions caching changes
Posted by GitBox <gi...@apache.org>.
adamdebreceni closed pull request #1214:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1214: MINIFICPP-1683 Revert github actions caching changes
Posted by GitBox <gi...@apache.org>.
lordgamez commented on pull request #1214:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1214#issuecomment-965132649
> Could we only cache builds on main and always restore the cache of main, regardless of the branch? It should be relatively close to most branches, so we would get the most benefit.
That's not a bad idea, my only concern is that can we assume that everyone would always rebase their PRs to the latest main when the branch is updated with new commits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1214: MINIFICPP-1683 Revert github actions caching changes
Posted by GitBox <gi...@apache.org>.
lordgamez commented on pull request #1214:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1214#issuecomment-967205073
> Could we only cache builds on main and always restore the cache of main, regardless of the branch? It should be relatively close to most branches, so we would get the most benefit.
Unfortunately I was not able to save the cache only specifically for the main branch. The problem is that there seems to be no option to do this as we have to define a key for every job that uses caching and if the key is not found it will be saved. Only the restore keys can be specified in a priority order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org