You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/19 22:48:26 UTC

[GitHub] [airflow] potiuk commented on pull request #25805: Improve error handling/messaging around bucket exist check

potiuk commented on PR #25805:
URL: https://github.com/apache/airflow/pull/25805#issuecomment-1221146537

   > > Should something still be printed if the return code is 200?
   > 
   > Thanks for the review TP!
   > 
   > I'm generally not a huge fan of success case logging, usually it's superfluous IMHO. I think maintaining the behaviour of no logging on success makes the most sense here and is less invasive. We could perhaps put a DEBUG level message for the success case if people really want something to trace in that case?
   
   Agree. not to print anything. I think 200 is not an interesting one and printing it in the logs adds no value. I think debug is not really needed - if someone is interested in seeing such details for DEBUG, they are likely better off by enabling some debug levels in boto ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org