[jira] [Comment Edited] (KYLIN-3004) Delete cube segment validation

["Yang Hao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286941#comment-16286941 ] 

Yang Hao edited comment on KYLIN-3004 at 12/12/17 1:34 AM:
-----------------------------------------------------------

Is it resonable to delete the middle segment? I think a proper way is to delete the unready middle segment as well as the former limit.


was (Author: yanghaogn):
Is it resonable to delete the middle segment? A proper way is to delete the unready middle segment as well as the former limit.

> Delete cube segment validation
> ------------------------------
>
>                 Key: KYLIN-3004
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3004
>             Project: Kylin
>          Issue Type: Bug
>          Components: REST Service
>    Affects Versions: v2.1.0
>            Reporter: Pan, Julian
>            Assignee: Pan, Julian
>         Attachments: KYLIN_3004.patch, KYLIN_3004.patch
>
>
> In version 2.1, kylin allow hole between segment.
> But currently, there is validation for delete segment.
> Here is the code in CubeService:
>  if (!segmentName.equals(cube.getSegments().get(0).getName())
>                 && !segmentName.equals(cube.getSegments().get(cube.getSegments().size() - 1).getName())) {
>             throw new BadRequestException(String.format(msg.getDELETE_NOT_FIRST_LAST_SEG(), segmentName));
>         }
> Does it make sense? Should we remove the limit?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)