You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "kaka11chen (via GitHub)" <gi...@apache.org> on 2024/03/23 03:56:58 UTC

[PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression test. [doris]

kaka11chen opened a new pull request, #32721:
URL: https://github.com/apache/doris/pull/32721

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016681383

   TeamCity be ut coverage result:
    Function Coverage: 35.26% (8733/24766) 
    Line Coverage: 27.05% (71503/264299)
    Region Coverage: 26.29% (37101/141099)
    Branch Coverage: 23.19% (18973/81818)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/deaa88d2ae0999a10979c919d9279099d4cdeec5_deaa88d2ae0999a10979c919d9279099d4cdeec5/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016827079

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "kaka11chen (via GitHub)" <gi...@apache.org>.
kaka11chen commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016825172

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016709329

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016684463

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 185497 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit deaa88d2ae0999a10979c919d9279099d4cdeec5, data reload: false
   
   query1	939	375	350	350
   query2	7449	2025	2028	2025
   query3	6721	209	207	207
   query4	31550	21162	21336	21162
   query5	4380	407	408	407
   query6	270	181	175	175
   query7	4621	293	287	287
   query8	222	175	168	168
   query9	9212	2288	2252	2252
   query10	561	247	255	247
   query11	17354	14461	14326	14326
   query12	134	94	84	84
   query13	1620	398	417	398
   query14	12991	11432	10564	10564
   query15	271	193	188	188
   query16	8239	255	261	255
   query17	2011	596	547	547
   query18	2106	286	274	274
   query19	357	148	154	148
   query20	91	89	91	89
   query21	206	130	137	130
   query22	4954	4823	4741	4741
   query23	33402	32973	32558	32558
   query24	10821	2833	2874	2833
   query25	610	378	385	378
   query26	1221	152	157	152
   query27	2715	359	347	347
   query28	7477	1865	1855	1855
   query29	900	647	622	622
   query30	301	147	147	147
   query31	982	740	736	736
   query32	90	57	63	57
   query33	776	259	244	244
   query34	1033	472	509	472
   query35	818	609	612	609
   query36	1024	877	892	877
   query37	118	77	77	77
   query38	3553	3442	3396	3396
   query39	1496	1448	1411	1411
   query40	217	112	118	112
   query41	50	49	49	49
   query42	102	97	96	96
   query43	471	450	461	450
   query44	1159	706	723	706
   query45	287	274	258	258
   query46	1125	708	697	697
   query47	1935	1802	1804	1802
   query48	444	360	341	341
   query49	1093	352	340	340
   query50	770	370	371	370
   query51	6698	6608	6562	6562
   query52	112	93	90	90
   query53	348	275	283	275
   query54	328	240	263	240
   query55	87	80	77	77
   query56	265	237	239	237
   query57	1198	1128	1124	1124
   query58	245	206	208	206
   query59	2901	2731	2538	2538
   query60	269	260	260	260
   query61	115	119	115	115
   query62	700	458	457	457
   query63	310	269	277	269
   query64	5608	3948	3948	3948
   query65	3107	3025	3093	3025
   query66	877	369	371	369
   query67	15186	14729	14662	14662
   query68	6811	522	514	514
   query69	614	368	384	368
   query70	1202	1170	1169	1169
   query71	488	273	274	273
   query72	6915	2718	2550	2550
   query73	706	311	304	304
   query74	7070	6689	6629	6629
   query75	4044	2981	2932	2932
   query76	4467	922	941	922
   query77	613	253	256	253
   query78	10853	10174	10221	10174
   query79	8524	515	516	515
   query80	1633	389	377	377
   query81	521	218	219	218
   query82	844	206	202	202
   query83	214	142	141	141
   query84	285	78	76	76
   query85	1470	312	311	311
   query86	424	309	291	291
   query87	3728	3566	3483	3483
   query88	4433	2287	2299	2287
   query89	518	367	369	367
   query90	2023	177	178	177
   query91	174	163	172	163
   query92	58	48	50	48
   query93	6479	488	467	467
   query94	1116	186	182	182
   query95	435	333	325	325
   query96	608	270	268	268
   query97	3075	2891	2904	2891
   query98	230	212	206	206
   query99	1197	955	944	944
   Total cold run time: 311375 ms
   Total hot run time: 185497 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016723293

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 187114 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit b97b65cb35152f061a7ad3ff3b2d2bcba39d0200, data reload: false
   
   query1	946	381	356	356
   query2	7432	2041	2068	2041
   query3	6719	212	208	208
   query4	31857	21293	21397	21293
   query5	4335	517	403	403
   query6	275	199	170	170
   query7	4621	286	282	282
   query8	233	172	168	168
   query9	9139	2285	2279	2279
   query10	543	261	258	258
   query11	17513	14454	14504	14454
   query12	146	93	84	84
   query13	1623	415	401	401
   query14	13014	11293	11108	11108
   query15	267	214	200	200
   query16	7929	263	262	262
   query17	1961	590	551	551
   query18	1396	303	293	293
   query19	231	155	155	155
   query20	95	88	88	88
   query21	203	126	128	126
   query22	5047	4802	4865	4802
   query23	33293	32792	32843	32792
   query24	11998	2894	2816	2816
   query25	667	380	390	380
   query26	1858	155	156	155
   query27	3304	353	359	353
   query28	7584	1847	1835	1835
   query29	1041	653	639	639
   query30	309	149	152	149
   query31	975	740	721	721
   query32	93	64	58	58
   query33	771	262	251	251
   query34	1131	480	490	480
   query35	847	620	614	614
   query36	1027	927	893	893
   query37	274	75	83	75
   query38	3535	3437	3514	3437
   query39	1480	1434	1403	1403
   query40	291	113	111	111
   query41	53	48	47	47
   query42	104	92	98	92
   query43	497	454	476	454
   query44	1174	727	725	725
   query45	282	256	259	256
   query46	1111	707	700	700
   query47	1910	1846	1830	1830
   query48	433	351	353	351
   query49	1238	334	333	333
   query50	751	372	365	365
   query51	6748	6711	6630	6630
   query52	107	93	90	90
   query53	343	274	284	274
   query54	341	249	242	242
   query55	89	79	80	79
   query56	245	231	232	231
   query57	1216	1153	1137	1137
   query58	235	217	211	211
   query59	2776	2712	2724	2712
   query60	261	337	274	274
   query61	117	117	116	116
   query62	655	449	463	449
   query63	305	276	287	276
   query64	6977	4087	3952	3952
   query65	3084	3029	3019	3019
   query66	1296	371	362	362
   query67	15417	14969	14854	14854
   query68	9328	519	519	519
   query69	689	384	370	370
   query70	1344	1200	1174	1174
   query71	531	273	270	270
   query72	7194	2770	2572	2572
   query73	1624	316	317	316
   query74	8551	6723	6680	6680
   query75	4495	2816	2884	2816
   query76	5926	901	881	881
   query77	642	377	263	263
   query78	11009	10252	10088	10088
   query79	11535	517	513	513
   query80	1429	412	387	387
   query81	496	215	214	214
   query82	346	208	210	208
   query83	229	151	144	144
   query84	285	74	77	74
   query85	1097	357	312	312
   query86	359	299	294	294
   query87	3691	3578	3531	3531
   query88	5112	2282	2281	2281
   query89	484	375	371	371
   query90	2046	179	177	177
   query91	169	138	140	138
   query92	62	48	49	48
   query93	5989	498	482	482
   query94	1340	178	178	178
   query95	434	334	329	329
   query96	601	267	268	267
   query97	3072	2927	2917	2917
   query98	226	212	209	209
   query99	1107	897	886	886
   Total cold run time: 325210 ms
   Total hot run time: 187114 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016682717

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 37716 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit deaa88d2ae0999a10979c919d9279099d4cdeec5, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17664	4240	4079	4079
   q2	2125	146	160	146
   q3	10594	1131	1182	1131
   q4	10229	763	849	763
   q5	7512	3017	2985	2985
   q6	197	122	120	120
   q7	1020	572	573	572
   q8	9350	2009	1981	1981
   q9	7203	6551	6522	6522
   q10	8426	3435	3520	3435
   q11	429	219	231	219
   q12	404	209	196	196
   q13	17800	2832	2858	2832
   q14	236	195	213	195
   q15	507	468	459	459
   q16	488	374	368	368
   q17	939	526	624	526
   q18	7001	6379	6364	6364
   q19	2418	1458	1365	1365
   q20	561	254	248	248
   q21	3654	2925	2909	2909
   q22	329	301	307	301
   Total cold run time: 109086 ms
   Total hot run time: 37716 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4138	4080	4105	4080
   q2	325	238	237	237
   q3	2956	2866	2813	2813
   q4	1828	1600	1496	1496
   q5	5276	5303	5331	5303
   q6	196	116	123	116
   q7	2256	1848	1865	1848
   q8	3153	3299	3293	3293
   q9	8703	8749	8715	8715
   q10	3786	3773	3743	3743
   q11	540	439	441	439
   q12	724	548	538	538
   q13	16935	2890	2825	2825
   q14	296	245	253	245
   q15	490	456	451	451
   q16	467	422	409	409
   q17	1716	1473	1461	1461
   q18	7450	7188	7216	7188
   q19	1609	1500	1557	1500
   q20	1911	1714	1702	1702
   q21	4744	4660	4768	4660
   q22	515	445	457	445
   Total cold run time: 70014 ms
   Total hot run time: 53507 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016794879

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 37628 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 9c16403b85afc19ea910be7210334514be7e6570, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17698	4939	4089	4089
   q2	2122	155	151	151
   q3	10580	1092	1184	1092
   q4	10229	759	789	759
   q5	7452	2989	2972	2972
   q6	199	123	127	123
   q7	1045	596	571	571
   q8	9348	1983	1960	1960
   q9	7189	6524	6491	6491
   q10	8385	3450	3545	3450
   q11	440	215	216	215
   q12	405	200	197	197
   q13	17802	2859	2861	2859
   q14	256	200	199	199
   q15	504	458	448	448
   q16	486	375	365	365
   q17	940	502	594	502
   q18	7190	6396	6377	6377
   q19	1944	1427	1479	1427
   q20	535	253	246	246
   q21	3596	2865	2852	2852
   q22	338	283	303	283
   Total cold run time: 108683 ms
   Total hot run time: 37628 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4122	4120	4055	4055
   q2	325	232	226	226
   q3	2957	2904	2841	2841
   q4	1861	1550	1566	1550
   q5	5337	5352	5371	5352
   q6	198	115	118	115
   q7	2279	1902	1877	1877
   q8	3166	3291	3309	3291
   q9	8771	8774	8750	8750
   q10	3831	3829	3786	3786
   q11	542	440	441	440
   q12	715	601	541	541
   q13	17025	3114	3069	3069
   q14	292	281	293	281
   q15	485	464	456	456
   q16	504	440	441	440
   q17	1744	1493	1479	1479
   q18	8068	7796	7337	7337
   q19	3861	1492	1513	1492
   q20	1923	1714	1697	1697
   q21	4877	4677	4706	4677
   q22	538	439	440	439
   Total cold run time: 73421 ms
   Total hot run time: 54191 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016677851

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016685032

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit deaa88d2ae0999a10979c919d9279099d4cdeec5 with default session variables
   Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
   Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       22.3 seconds inserted 10000000 Rows, about 448K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "kaka11chen (via GitHub)" <gi...@apache.org>.
kaka11chen commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016676939

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "kaka11chen (via GitHub)" <gi...@apache.org>.
kaka11chen commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016784815

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression test. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016335003

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016336164

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "kaka11chen (via GitHub)" <gi...@apache.org>.
kaka11chen commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016708450

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016827073

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016798858

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 9c16403b85afc19ea910be7210334514be7e6570 with default session variables
   Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
   Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
   Insert into select:       19.8 seconds inserted 10000000 Rows, about 505K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016785123

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016720925

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 38394 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit b97b65cb35152f061a7ad3ff3b2d2bcba39d0200, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17639	4256	4144	4144
   q2	2123	167	153	153
   q3	11415	1162	1289	1162
   q4	10662	761	784	761
   q5	7850	3151	3083	3083
   q6	204	123	124	123
   q7	1085	627	597	597
   q8	9387	2083	2045	2045
   q9	7356	6764	6722	6722
   q10	8997	3464	3597	3464
   q11	433	220	215	215
   q12	425	203	190	190
   q13	17798	2859	2870	2859
   q14	229	208	219	208
   q15	506	465	455	455
   q16	509	377	373	373
   q17	973	538	616	538
   q18	7249	6519	6385	6385
   q19	3281	1488	1497	1488
   q20	558	283	259	259
   q21	3650	2940	2873	2873
   q22	351	297	302	297
   Total cold run time: 112680 ms
   Total hot run time: 38394 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4110	4074	4055	4055
   q2	328	233	240	233
   q3	3037	2878	2843	2843
   q4	1860	1623	1614	1614
   q5	5335	5346	5352	5346
   q6	196	116	116	116
   q7	2235	1858	1851	1851
   q8	3186	3329	3326	3326
   q9	8749	8676	8723	8676
   q10	3768	3817	3820	3817
   q11	536	445	444	444
   q12	751	583	597	583
   q13	19479	2829	2868	2829
   q14	280	243	275	243
   q15	505	457	453	453
   q16	480	426	424	424
   q17	1734	1501	1476	1476
   q18	7571	7313	7153	7153
   q19	1613	1482	1501	1482
   q20	1914	1698	1713	1698
   q21	4791	4632	4858	4632
   q22	535	442	451	442
   Total cold run time: 72993 ms
   Total hot run time: 53736 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016723840

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit b97b65cb35152f061a7ad3ff3b2d2bcba39d0200 with default session variables
   Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
   Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
   Insert into select:       22.2 seconds inserted 10000000 Rows, about 450K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016792841

   TeamCity be ut coverage result:
    Function Coverage: 35.26% (8733/24766) 
    Line Coverage: 27.06% (71519/264321)
    Region Coverage: 26.29% (37100/141115)
    Branch Coverage: 23.19% (18977/81828)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/9c16403b85afc19ea910be7210334514be7e6570_9c16403b85afc19ea910be7210334514be7e6570/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32721:
URL: https://github.com/apache/doris/pull/32721#issuecomment-2016797977

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 186891 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 9c16403b85afc19ea910be7210334514be7e6570, data reload: false
   
   query1	945	361	353	353
   query2	7522	2032	2041	2032
   query3	6714	212	210	210
   query4	31727	21356	21410	21356
   query5	4468	400	414	400
   query6	262	171	171	171
   query7	4625	291	286	286
   query8	223	189	177	177
   query9	9057	2274	2251	2251
   query10	590	259	267	259
   query11	15838	14401	14382	14382
   query12	142	100	84	84
   query13	1623	417	410	410
   query14	12985	11162	11514	11162
   query15	268	197	206	197
   query16	8234	252	244	244
   query17	2151	571	548	548
   query18	2122	298	280	280
   query19	363	158	155	155
   query20	96	92	89	89
   query21	206	137	123	123
   query22	5011	4827	5034	4827
   query23	33611	32729	32552	32552
   query24	10544	2856	2862	2856
   query25	645	397	384	384
   query26	1170	156	160	156
   query27	2392	350	358	350
   query28	6792	1856	1860	1856
   query29	887	661	619	619
   query30	298	149	150	149
   query31	974	732	739	732
   query32	93	58	55	55
   query33	787	263	266	263
   query34	1048	477	502	477
   query35	835	625	615	615
   query36	1031	904	895	895
   query37	116	79	76	76
   query38	3547	3461	3430	3430
   query39	1485	1455	1440	1440
   query40	211	114	114	114
   query41	51	47	47	47
   query42	102	96	97	96
   query43	494	463	470	463
   query44	1142	718	710	710
   query45	290	268	267	267
   query46	1114	695	704	695
   query47	1912	1824	1849	1824
   query48	454	357	354	354
   query49	1100	340	337	337
   query50	759	375	372	372
   query51	6593	6628	6588	6588
   query52	112	94	93	93
   query53	344	277	281	277
   query54	323	243	250	243
   query55	88	80	81	80
   query56	257	228	247	228
   query57	1205	1144	1133	1133
   query58	237	210	207	207
   query59	2909	2666	2806	2666
   query60	273	258	260	258
   query61	121	118	119	118
   query62	660	461	434	434
   query63	310	280	283	280
   query64	5735	4143	4071	4071
   query65	3083	3038	3039	3038
   query66	892	380	371	371
   query67	15483	14893	14619	14619
   query68	8927	517	536	517
   query69	665	377	387	377
   query70	1456	1099	1153	1099
   query71	521	275	281	275
   query72	6702	2720	2576	2576
   query73	1648	309	318	309
   query74	7293	6674	6728	6674
   query75	4589	2989	2953	2953
   query76	5721	888	893	888
   query77	663	364	259	259
   query78	10929	10260	10122	10122
   query79	12535	527	527	527
   query80	1976	390	402	390
   query81	534	213	217	213
   query82	432	206	201	201
   query83	219	144	149	144
   query84	291	78	82	78
   query85	1115	322	316	316
   query86	365	281	284	281
   query87	3665	3521	3550	3521
   query88	5209	2282	2293	2282
   query89	488	388	388	388
   query90	2069	179	176	176
   query91	174	134	139	134
   query92	61	52	50	50
   query93	6800	497	490	490
   query94	1306	179	180	179
   query95	436	343	339	339
   query96	618	274	275	274
   query97	3065	2888	2893	2888
   query98	226	206	208	206
   query99	1163	890	881	881
   Total cold run time: 319542 ms
   Total hot run time: 186891 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](multi-catalog)Fix the issue of not initializing the writer caused by refactoring and add hive writing regression tests. [doris]

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #32721:
URL: https://github.com/apache/doris/pull/32721


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org