You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2024/08/28 09:22:47 UTC
Re: [PR] [SPARK-49444] Modified UnivocityParser to throw runtime exceptions caused by ArrayIndexOutOfBounds with more user-oriented messages [spark]
MaxGekk commented on code in PR #47906:
URL: https://github.com/apache/spark/pull/47906#discussion_r1734318734
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/csv/UnivocityParserSuite.scala:
##########
@@ -273,11 +273,11 @@ class UnivocityParserSuite extends SparkFunSuite with SQLHelper {
test("skipping rows using pushdown filters") {
def check(
- input: String = "1,a",
- dataSchema: StructType = StructType.fromDDL("i INTEGER, s STRING"),
- requiredSchema: StructType = StructType.fromDDL("i INTEGER"),
- filters: Seq[Filter],
- expected: Option[InternalRow]): Unit = {
+ input: String = "1,a",
+ dataSchema: StructType = StructType.fromDDL("i INTEGER, s STRING"),
+ requiredSchema: StructType = StructType.fromDDL("i INTEGER"),
+ filters: Seq[Filter],
+ expected: Option[InternalRow]): Unit = {
Review Comment:
wrong indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org