You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by re...@apache.org on 2019/05/02 19:43:57 UTC
[bookkeeper] branch branch-4.9 updated: ISSUE #2075: Bookieshell
lastmark command isn't functional, always returning 0-0
This is an automated email from the ASF dual-hosted git repository.
reddycharan pushed a commit to branch branch-4.9
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/branch-4.9 by this push:
new ef7ba35 ISSUE #2075: Bookieshell lastmark command isn't functional, always returning 0-0
ef7ba35 is described below
commit ef7ba357ae73cbebd5d2c749531cc2aa766e0fc5
Author: karanmehta93 <k....@salesforce.com>
AuthorDate: Thu May 2 12:38:31 2019 -0700
ISSUE #2075: Bookieshell lastmark command isn't functional, always returning 0-0
Descriptions of the changes in this PR:
### Motivation
`lastmark` shell command is to be used while debugging however currently it cannot be used since it returns incorrect value.
### Changes
Updated `LedgerDirsManager` object initialization to use correct `ledgerDirs`.
Master Issue: #2075
Reviewers: Charan Reddy Guttapalem <re...@gmail.com>, Sijie Guo <si...@apache.org>
This closes #2076 from karanmehta93/ISSUE-2075, closes #2075
(cherry picked from commit 707ae5c8536f967c0369f951d6178670c5dd031d)
Signed-off-by: Charan Reddy Guttapalem <cg...@salesforce.com>
---
.../apache/bookkeeper/tools/cli/commands/bookie/LastMarkCommand.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/LastMarkCommand.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/LastMarkCommand.java
index 61c1f92..f925e13 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/LastMarkCommand.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/LastMarkCommand.java
@@ -48,7 +48,7 @@ public class LastMarkCommand extends BookieCommand<CliFlags> {
@Override
public boolean apply(ServerConfiguration conf, CliFlags flags) {
LedgerDirsManager dirsManager = new LedgerDirsManager(
- conf, conf.getJournalDirs(),
+ conf, conf.getLedgerDirs(),
new DiskChecker(conf.getDiskUsageThreshold(), conf.getDiskUsageWarnThreshold()));
File[] journalDirs = conf.getJournalDirs();