You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by pt...@apache.org on 2019/12/22 11:35:18 UTC
[ignite] branch master updated: .NET: Fix Resharper inspection
warnings
This is an automated email from the ASF dual-hosted git repository.
ptupitsyn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ignite.git
The following commit(s) were added to refs/heads/master by this push:
new 607cdb0 .NET: Fix Resharper inspection warnings
607cdb0 is described below
commit 607cdb0dafe8cb8c6595ab776b66a1a25cba018d
Author: Pavel Tupitsyn <pt...@apache.org>
AuthorDate: Sun Dec 22 14:34:52 2019 +0300
.NET: Fix Resharper inspection warnings
Fix or suppress everything from solution-wide analysis of the latest Resharper and Rider to make it easier to spot new issues during development
---
.gitignore | 2 ++
.../IgniteSessionStateStoreDataTest.cs | 6 ++++--
.../Binary/Serializable/ObjectReferenceTests.cs | 1 +
.../Binary/TypeNameParserTest.cs | 1 +
.../Cache/AddArgCacheEntryProcessor.cs | 4 +++-
.../Cache/Affinity/AffinityFunctionSpringTest.cs | 1 +
.../Cache/Affinity/AffinityFunctionTest.cs | 1 +
.../Cache/Query/Linq/CacheLinqTest.Base.cs | 3 ++-
.../Compute/ComputeApiTest.cs | 2 ++
.../Compute/IgniteExceptionTaskSelfTest.cs | 2 --
.../DataStructures/AtomicReferenceTest.cs | 4 +++-
.../Apache.Ignite.Core.Tests/DeploymentTest.cs | 1 +
.../dotnet/Apache.Ignite.Core.Tests/EventsTest.cs | 4 +++-
.../Apache.Ignite.Core.Tests/MessagingTest.cs | 1 +
.../Services/ServicesTest.cs | 2 ++
.../Impl/Binary/BinaryArrayEqualityComparer.cs | 4 +++-
.../Apache.Ignite.Core/Impl/Binary/BinaryEnum.cs | 4 +++-
.../Apache.Ignite.Core/Impl/Binary/BinaryObject.cs | 4 +++-
.../Impl/Binary/BinaryObjectHeader.cs | 8 ++++++--
.../Impl/Cache/MutableCacheEntry.cs | 10 +++++++--
.../Impl/Client/ClientProtocolVersion.cs | 24 ++++++++++++++++------
.../dotnet/Apache.Ignite.Core/Impl/Ignite.cs | 14 ++++++-------
.../Impl/Services/ServiceDescriptor.cs | 4 +++-
.../Apache.Ignite.Core/Impl/Unmanaged/Jni/Env.cs | 2 ++
.../Impl/CacheFieldsQueryExecutor.cs | 4 +++-
.../Apache.Ignite.Linq/Impl/MethodVisitor.cs | 2 ++
.../DataStructures/AtomicLongIncrementAction.cs | 1 +
.../DataStructures/AtomicReferenceModifyAction.cs | 1 +
.../AtomicSequenceIncrementAction.cs | 1 +
29 files changed, 88 insertions(+), 30 deletions(-)
diff --git a/.gitignore b/.gitignore
index dd7eac1..cdc7065 100644
--- a/.gitignore
+++ b/.gitignore
@@ -30,6 +30,8 @@ git-patch-prop-local.sh
*.classname*
*.exe
.mvn/
+mvnw
+mvnw.cmd
#Ignore all Intellij IDEA files (except default inspections config)
.idea/
diff --git a/modules/platforms/dotnet/Apache.Ignite.AspNet.Tests/IgniteSessionStateStoreDataTest.cs b/modules/platforms/dotnet/Apache.Ignite.AspNet.Tests/IgniteSessionStateStoreDataTest.cs
index e8dcd7c..7bb82eb 100644
--- a/modules/platforms/dotnet/Apache.Ignite.AspNet.Tests/IgniteSessionStateStoreDataTest.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.AspNet.Tests/IgniteSessionStateStoreDataTest.cs
@@ -18,6 +18,7 @@
namespace Apache.Ignite.AspNet.Tests
{
using System;
+ using System.Diagnostics;
using System.IO;
using System.Reflection;
using System.Web;
@@ -39,8 +40,9 @@ namespace Apache.Ignite.AspNet.Tests
{
// Modification method is internal.
var statics = new HttpStaticObjectsCollection();
- statics.GetType().GetMethod("Add", BindingFlags.Instance | BindingFlags.NonPublic)
- .Invoke(statics, new object[] { "int", typeof(int), false });
+ var methodInfo = statics.GetType().GetMethod("Add", BindingFlags.Instance | BindingFlags.NonPublic);
+ Debug.Assert(methodInfo != null);
+ methodInfo.Invoke(statics, new object[] { "int", typeof(int), false });
var data = new IgniteSessionStateStoreData(statics, 44);
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Binary/Serializable/ObjectReferenceTests.cs b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Binary/Serializable/ObjectReferenceTests.cs
index 71d2f9a..ceb0f79 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Binary/Serializable/ObjectReferenceTests.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Binary/Serializable/ObjectReferenceTests.cs
@@ -96,6 +96,7 @@ namespace Apache.Ignite.Core.Tests.Binary.Serializable
public void GetObjectData(SerializationInfo info, StreamingContext context)
{
+ // ReSharper disable once AssignNullToNotNullAttribute
info.FullTypeName = typeof(ObjectInfoHolder).FullName;
info.AssemblyName = typeof(ObjectInfoHolder).Assembly.FullName;
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Binary/TypeNameParserTest.cs b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Binary/TypeNameParserTest.cs
index 8718d32..33fe495 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Binary/TypeNameParserTest.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Binary/TypeNameParserTest.cs
@@ -268,6 +268,7 @@ namespace Apache.Ignite.Core.Tests.Binary
Assert.AreEqual(type.FullName, res.GetNameWithNamespace() + res.GetArray());
}
+ Assert.IsNotNull(type.FullName);
Assert.AreEqual(type.FullName.Length + 2, res.AssemblyStart);
Assert.AreEqual(type.FullName, res.GetFullName());
}
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Cache/AddArgCacheEntryProcessor.cs b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Cache/AddArgCacheEntryProcessor.cs
index 5187627..feef1ab 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Cache/AddArgCacheEntryProcessor.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Cache/AddArgCacheEntryProcessor.cs
@@ -82,7 +82,9 @@ namespace Apache.Ignite.Core.Tests.Cache
return entry.Value;
}
- /** <inheritdoc /> */
+ /// <summary>
+ /// Invalid override.
+ /// </summary>
public int Process(IMutableCacheEntry<int, int> entry, int arg)
{
throw new Exception("Invalid method");
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Cache/Affinity/AffinityFunctionSpringTest.cs b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Cache/Affinity/AffinityFunctionSpringTest.cs
index 78de671..14b5a60 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Cache/Affinity/AffinityFunctionSpringTest.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Cache/Affinity/AffinityFunctionSpringTest.cs
@@ -94,6 +94,7 @@ namespace Apache.Ignite.Core.Tests.Cache.Affinity
Assert.AreEqual(3, aff.GetPartition(4L));
}
+ // ReSharper disable once UnusedType.Local (used from config)
private class TestFunc : IAffinityFunction // [Serializable] is not necessary
{
[InstanceResource]
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Cache/Affinity/AffinityFunctionTest.cs b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Cache/Affinity/AffinityFunctionTest.cs
index 7c6d779..09996bd 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Cache/Affinity/AffinityFunctionTest.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Cache/Affinity/AffinityFunctionTest.cs
@@ -300,6 +300,7 @@ namespace Apache.Ignite.Core.Tests.Cache.Affinity
private class SimpleAffinityFunction : IAffinityFunction
{
#pragma warning disable 649 // field is never assigned
+ // ReSharper disable once UnassignedReadonlyField
[InstanceResource] private readonly IIgnite _ignite;
public int Partitions
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Cache/Query/Linq/CacheLinqTest.Base.cs b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Cache/Query/Linq/CacheLinqTest.Base.cs
index 81dcfed..c70b692 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Cache/Query/Linq/CacheLinqTest.Base.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Cache/Query/Linq/CacheLinqTest.Base.cs
@@ -498,7 +498,7 @@ namespace Apache.Ignite.Core.Tests.Cache.Query.Linq
if (Equals(x, y))
return 0;
- if (x is double)
+ if (x is double && y is double)
{
var dx = (double) x;
var dy = (double) y;
@@ -512,6 +512,7 @@ namespace Apache.Ignite.Core.Tests.Cache.Query.Linq
return Math.Abs((double) x - (double) y) < relEpsilon ? 0 : 1;
}
+ // ReSharper disable once PossibleNullReferenceException
return ((IComparable) x).CompareTo(y);
}
}
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Compute/ComputeApiTest.cs b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Compute/ComputeApiTest.cs
index d41b4a6..6991f08 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Compute/ComputeApiTest.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Compute/ComputeApiTest.cs
@@ -949,6 +949,7 @@ namespace Apache.Ignite.Core.Tests.Compute
{
[InstanceResource]
#pragma warning disable 649
+ // ReSharper disable once UnassignedField.Local
private IIgnite _grid;
public static ConcurrentBag<Guid> Invokes = new ConcurrentBag<Guid>();
@@ -1017,6 +1018,7 @@ namespace Apache.Ignite.Core.Tests.Compute
class ComputeFunc : INestedComputeFunc, IUserInterface<int>
{
[InstanceResource]
+ // ReSharper disable once UnassignedField.Local
private IIgnite _grid;
public static int InvokeCount;
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Compute/IgniteExceptionTaskSelfTest.cs b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Compute/IgniteExceptionTaskSelfTest.cs
index 9f157f4..0af647b 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Compute/IgniteExceptionTaskSelfTest.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Compute/IgniteExceptionTaskSelfTest.cs
@@ -569,8 +569,6 @@ namespace Apache.Ignite.Core.Tests.Compute
/// </summary>
private class BadJob : IComputeJob<object>, IBinarizable
{
- [InstanceResource]
-
/** <inheritDoc /> */
public object Execute()
{
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/DataStructures/AtomicReferenceTest.cs b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/DataStructures/AtomicReferenceTest.cs
index 185a7c0..8a66c5a 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/DataStructures/AtomicReferenceTest.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/DataStructures/AtomicReferenceTest.cs
@@ -197,7 +197,9 @@ namespace Apache.Ignite.Core.Tests.DataStructures
/** */
public int Foo { get; set; }
- /** <inheritdoc /> */
+ /// <summary>
+ /// Determines whether the specified object is equal to the current object.
+ /// </summary>
private bool Equals(SerializableObj other)
{
return Foo == other.Foo;
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/DeploymentTest.cs b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/DeploymentTest.cs
index 9c75a8b..949643f 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/DeploymentTest.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/DeploymentTest.cs
@@ -229,6 +229,7 @@ namespace Apache.Ignite.Core.Tests
private class ProcessPathFunc : IComputeFunc<string>
{
[InstanceResource]
+ // ReSharper disable once UnassignedField.Local
private IIgnite _ignite;
/** <inheritdoc /> */
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/EventsTest.cs b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/EventsTest.cs
index 7162d3e..2bf0a73 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/EventsTest.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/EventsTest.cs
@@ -946,7 +946,9 @@ namespace Apache.Ignite.Core.Tests
return _invoke(evt);
}
- /** <inheritdoc /> */
+ /// <summary>
+ /// Invalid Invoke method for tests.
+ /// </summary>
// ReSharper disable once UnusedMember.Global
public bool Invoke(T evt)
{
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/MessagingTest.cs b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/MessagingTest.cs
index af1096b..659afa7 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/MessagingTest.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/MessagingTest.cs
@@ -688,6 +688,7 @@ namespace Apache.Ignite.Core.Tests
#pragma warning disable 649
/** Grid. */
[InstanceResource]
+ // ReSharper disable once UnassignedField.Local
private IIgnite _grid;
#pragma warning restore 649
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Services/ServicesTest.cs b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Services/ServicesTest.cs
index fb55d6f..32a7f73 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Services/ServicesTest.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core.Tests/Services/ServicesTest.cs
@@ -292,6 +292,7 @@ namespace Apache.Ignite.Core.Tests.Services
Assert.AreEqual(prx.ToString(), svc.ToString());
Assert.AreEqual(17, prx.TestProperty);
Assert.IsTrue(prx.Initialized);
+ // ReSharper disable once AccessToModifiedClosure
Assert.IsTrue(TestUtils.WaitForCondition(() => prx.Executed, 5000));
Assert.IsFalse(prx.Cancelled);
Assert.AreEqual(SvcName, prx.LastCallContextName);
@@ -1138,6 +1139,7 @@ namespace Apache.Ignite.Core.Tests.Services
{
/** */
[InstanceResource]
+ // ReSharper disable once UnassignedField.Local
private IIgnite _grid;
/** <inheritdoc /> */
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/BinaryArrayEqualityComparer.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/BinaryArrayEqualityComparer.cs
index d969b8f..e01ac98 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/BinaryArrayEqualityComparer.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/BinaryArrayEqualityComparer.cs
@@ -96,7 +96,9 @@ namespace Apache.Ignite.Core.Impl.Binary
}
}
- /** <inheritdoc /> */
+ /// <summary>
+ /// Computes the hash code of specified stream content.
+ /// </summary>
public static int GetHashCode(IBinaryStream stream, int startPos, int length)
{
Debug.Assert(stream != null);
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/BinaryEnum.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/BinaryEnum.cs
index 2bc4bdf..128fe45 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/BinaryEnum.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/BinaryEnum.cs
@@ -51,7 +51,9 @@ namespace Apache.Ignite.Core.Impl.Binary
_marsh = marsh;
}
- /** <inheritdoc /> */
+ /// <summary>
+ /// Gets the type id.
+ /// </summary>
public int TypeId
{
get { return _typeId; }
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/BinaryObject.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/BinaryObject.cs
index 370233f..9f2ea63 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/BinaryObject.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/BinaryObject.cs
@@ -77,7 +77,9 @@ namespace Apache.Ignite.Core.Impl.Binary
_header = header;
}
- /** <inheritdoc /> */
+ /// <summary>
+ /// Gets the type id.
+ /// </summary>
public int TypeId
{
get { return _header.TypeId; }
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/BinaryObjectHeader.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/BinaryObjectHeader.cs
index d7dd74d..7debd23 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/BinaryObjectHeader.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/BinaryObjectHeader.cs
@@ -346,13 +346,17 @@ namespace Apache.Ignite.Core.Impl.Binary
}
}
- /** <inheritdoc /> */
+ /// <summary>
+ /// Equality operator.
+ /// </summary>
public static bool operator ==(BinaryObjectHeader left, BinaryObjectHeader right)
{
return left.Equals(right);
}
- /** <inheritdoc /> */
+ /// <summary>
+ /// Inequality operator.
+ /// </summary>
public static bool operator !=(BinaryObjectHeader left, BinaryObjectHeader right)
{
return !left.Equals(right);
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/MutableCacheEntry.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/MutableCacheEntry.cs
index d1d2898..7d5648d 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/MutableCacheEntry.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/MutableCacheEntry.cs
@@ -33,6 +33,7 @@ namespace Apache.Ignite.Core.Impl.Cache
/// Initializes a new instance of the <see cref="MutableCacheEntry{K, V}"/> class.
/// </summary>
/// <param name="key">The key.</param>
+ // ReSharper disable once UnusedMember.Global (used from Reflection)
public MutableCacheEntry(TK key)
{
Key = key;
@@ -43,6 +44,7 @@ namespace Apache.Ignite.Core.Impl.Cache
/// </summary>
/// <param name="key">The key.</param>
/// <param name="value">The value.</param>
+ // ReSharper disable once UnusedMember.Global (used from Reflection)
public MutableCacheEntry(TK key, TV value)
{
Key = key;
@@ -59,7 +61,9 @@ namespace Apache.Ignite.Core.Impl.Cache
get { return Key; }
}
- /** <inheritdoc /> */
+ /// <summary>
+ /// Gets or sets the value.
+ /// </summary>
public TV Value
{
get { return _value; }
@@ -77,7 +81,9 @@ namespace Apache.Ignite.Core.Impl.Cache
get { return Value; }
}
- /** <inheritdoc /> */
+ /// <summary>
+ /// Gets a value indicating whether cache entry exists in cache.
+ /// </summary>
public bool Exists { get; private set; }
/** <inheritdoc /> */
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/ClientProtocolVersion.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/ClientProtocolVersion.cs
index d00ab82..80fd98b 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/ClientProtocolVersion.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/ClientProtocolVersion.cs
@@ -106,37 +106,49 @@ namespace Apache.Ignite.Core.Impl.Client
return obj is ClientProtocolVersion && Equals((ClientProtocolVersion) obj);
}
- /** <inheritdoc /> */
+ /// <summary>
+ /// Equality operator.
+ /// </summary>
public static bool operator ==(ClientProtocolVersion left, ClientProtocolVersion right)
{
return left.Equals(right);
}
- /** <inheritdoc /> */
+ /// <summary>
+ /// Inequality operator.
+ /// </summary>
public static bool operator !=(ClientProtocolVersion left, ClientProtocolVersion right)
{
return !left.Equals(right);
}
- /** <inheritdoc /> */
+ /// <summary>
+ /// Less-than operator.
+ /// </summary>
public static bool operator <(ClientProtocolVersion left, ClientProtocolVersion right)
{
return left.CompareTo(right) < 0;
}
- /** <inheritdoc /> */
+ /// <summary>
+ /// Less-or-equal-than operator.
+ /// </summary>
public static bool operator <=(ClientProtocolVersion left, ClientProtocolVersion right)
{
return left.CompareTo(right) <= 0;
}
- /** <inheritdoc /> */
+ /// <summary>
+ /// Greater-than operator.
+ /// </summary>
public static bool operator >(ClientProtocolVersion left, ClientProtocolVersion right)
{
return left.CompareTo(right) > 0;
}
- /** <inheritdoc /> */
+ /// <summary>
+ /// Greater-or-equal-than operator.
+ /// </summary>
public static bool operator >=(ClientProtocolVersion left, ClientProtocolVersion right)
{
return left.CompareTo(right) >= 0;
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Ignite.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Ignite.cs
index 07e96ae..e19dcbf 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Ignite.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Ignite.cs
@@ -235,7 +235,7 @@ namespace Apache.Ignite.Core.Impl
return _prj.ForNodes(GetLocalNode());
}
- /** <inheritdoc /> */
+ /** <inheritdoc cref="IIgnite" /> */
public ICompute GetCompute()
{
return _prj.ForServers().GetCompute();
@@ -599,7 +599,7 @@ namespace Apache.Ignite.Core.Impl
return this;
}
- /** <inheritdoc /> */
+ /** <inheritdoc cref="IIgnite" /> */
public IBinary GetBinary()
{
return _binary;
@@ -621,19 +621,19 @@ namespace Apache.Ignite.Core.Impl
return new TransactionsImpl(this, DoOutOpObject((int) Op.GetTransactions), GetLocalNode().Id);
}
- /** <inheritdoc /> */
+ /** <inheritdoc cref="IIgnite" /> */
public IMessaging GetMessaging()
{
return _prj.GetMessaging();
}
- /** <inheritdoc /> */
+ /** <inheritdoc cref="IIgnite" /> */
public IEvents GetEvents()
{
return _prj.GetEvents();
}
- /** <inheritdoc /> */
+ /** <inheritdoc cref="IIgnite" /> */
public IServices GetServices()
{
return _prj.ForServers().GetServices();
@@ -780,13 +780,13 @@ namespace Apache.Ignite.Core.Impl
}
#pragma warning restore 618
- /** <inheritdoc /> */
+ /** <inheritdoc cref="IIgnite" /> */
public void SetActive(bool isActive)
{
_prj.SetActive(isActive);
}
- /** <inheritdoc /> */
+ /** <inheritdoc cref="IIgnite" /> */
public bool IsActive()
{
return _prj.IsActive();
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/ServiceDescriptor.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/ServiceDescriptor.cs
index 2e5de39..4a60ac0 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/ServiceDescriptor.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/ServiceDescriptor.cs
@@ -87,7 +87,9 @@ namespace Apache.Ignite.Core.Impl.Services
}
}
- /** <inheritdoc /> */
+ /// <summary>
+ /// Gets or sets the platform of this service.
+ /// </summary>
public Platform Platform { get; private set; }
/** <inheritdoc /> */
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/Jni/Env.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/Jni/Env.cs
index fbe91f0..61256db 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/Jni/Env.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/Jni/Env.cs
@@ -69,6 +69,7 @@ namespace Apache.Ignite.Core.Impl.Unmanaged.Jni
private readonly EnvDelegates.CallVoidMethod _callVoidMethod;
/** */
+ // ReSharper disable once PrivateFieldCanBeConvertedToLocalVariable
private readonly EnvDelegates.GetStringChars _getStringChars;
/** */
@@ -81,6 +82,7 @@ namespace Apache.Ignite.Core.Impl.Unmanaged.Jni
private readonly EnvDelegates.ReleaseStringUtfChars _releaseStringUtfChars;
/** */
+ // ReSharper disable once PrivateFieldCanBeConvertedToLocalVariable
private readonly EnvDelegates.ReleaseStringChars _releaseStringChars;
/** */
diff --git a/modules/platforms/dotnet/Apache.Ignite.Linq/Impl/CacheFieldsQueryExecutor.cs b/modules/platforms/dotnet/Apache.Ignite.Linq/Impl/CacheFieldsQueryExecutor.cs
index 866edff..43d8e64 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Linq/Impl/CacheFieldsQueryExecutor.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Linq/Impl/CacheFieldsQueryExecutor.cs
@@ -214,7 +214,9 @@ namespace Apache.Ignite.Linq.Impl
};
}
- /** <inheritdoc /> */
+ /// <summary>
+ /// Generates <see cref="QueryData"/> from specified <see cref="QueryModel"/>.
+ /// </summary>
public static QueryData GetQueryData(QueryModel queryModel)
{
Debug.Assert(queryModel != null);
diff --git a/modules/platforms/dotnet/Apache.Ignite.Linq/Impl/MethodVisitor.cs b/modules/platforms/dotnet/Apache.Ignite.Linq/Impl/MethodVisitor.cs
index 375c7a8..c7aebb9 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Linq/Impl/MethodVisitor.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Linq/Impl/MethodVisitor.cs
@@ -32,6 +32,7 @@ namespace Apache.Ignite.Linq.Impl
/// <summary> Property visitors. </summary>
private static readonly Dictionary<MemberInfo, string> Properties = new Dictionary<MemberInfo, string>
{
+ // ReSharper disable AssignNullToNotNullAttribute
{typeof(string).GetProperty("Length"), "length"},
{typeof(DateTime).GetProperty("Year"), "year"},
{typeof(DateTime).GetProperty("Month"), "month"},
@@ -41,6 +42,7 @@ namespace Apache.Ignite.Linq.Impl
{typeof(DateTime).GetProperty("Hour"), "hour"},
{typeof(DateTime).GetProperty("Minute"), "minute"},
{typeof(DateTime).GetProperty("Second"), "second"}
+ // ReSharper restore AssignNullToNotNullAttribute
};
/// <summary> Method visit delegate. </summary>
diff --git a/modules/platforms/dotnet/examples/Apache.Ignite.ExamplesDll/DataStructures/AtomicLongIncrementAction.cs b/modules/platforms/dotnet/examples/Apache.Ignite.ExamplesDll/DataStructures/AtomicLongIncrementAction.cs
index 87732f8..713d8bf 100644
--- a/modules/platforms/dotnet/examples/Apache.Ignite.ExamplesDll/DataStructures/AtomicLongIncrementAction.cs
+++ b/modules/platforms/dotnet/examples/Apache.Ignite.ExamplesDll/DataStructures/AtomicLongIncrementAction.cs
@@ -33,6 +33,7 @@ namespace Apache.Ignite.ExamplesDll.DataStructures
public const string AtomicLongName = "dotnet_atomic_long";
/** */
+ // ReSharper disable once UnassignedReadonlyField
[InstanceResource] private readonly IIgnite _ignite;
/// <summary>
diff --git a/modules/platforms/dotnet/examples/Apache.Ignite.ExamplesDll/DataStructures/AtomicReferenceModifyAction.cs b/modules/platforms/dotnet/examples/Apache.Ignite.ExamplesDll/DataStructures/AtomicReferenceModifyAction.cs
index 196a2d1..36aea7e 100644
--- a/modules/platforms/dotnet/examples/Apache.Ignite.ExamplesDll/DataStructures/AtomicReferenceModifyAction.cs
+++ b/modules/platforms/dotnet/examples/Apache.Ignite.ExamplesDll/DataStructures/AtomicReferenceModifyAction.cs
@@ -33,6 +33,7 @@ namespace Apache.Ignite.ExamplesDll.DataStructures
public const string AtomicReferenceName = "dotnet_atomic_reference";
/** */
+ // ReSharper disable once UnassignedReadonlyField
[InstanceResource] private readonly IIgnite _ignite;
/// <summary>
diff --git a/modules/platforms/dotnet/examples/Apache.Ignite.ExamplesDll/DataStructures/AtomicSequenceIncrementAction.cs b/modules/platforms/dotnet/examples/Apache.Ignite.ExamplesDll/DataStructures/AtomicSequenceIncrementAction.cs
index c7112b9..0256795 100644
--- a/modules/platforms/dotnet/examples/Apache.Ignite.ExamplesDll/DataStructures/AtomicSequenceIncrementAction.cs
+++ b/modules/platforms/dotnet/examples/Apache.Ignite.ExamplesDll/DataStructures/AtomicSequenceIncrementAction.cs
@@ -33,6 +33,7 @@ namespace Apache.Ignite.ExamplesDll.DataStructures
public const string AtomicSequenceName = "dotnet_atomic_sequence";
/** */
+ // ReSharper disable once UnassignedReadonlyField
[InstanceResource] private readonly IIgnite _ignite;
/// <summary>