You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2019/10/24 22:47:03 UTC

[GitHub] [lucene-solr] tobijdc opened a new pull request #975: Add temporal unit to warmupTime in ref guide

tobijdc opened a new pull request #975: Add temporal unit to warmupTime in ref guide
URL: https://github.com/apache/lucene-solr/pull/975
 
 
   I haven't created a Solr Ticket for this minor change, if really necessary, I can and would update PR and commit message.
   
   # Description
   
   Wanted to know the unit of warmUpTime, but it was not included.
   
   # Solution
   
   Added it, so other people don't have to dig.
   
   # Tests
   
   None, but you can quickly verify by checking source.
   https://github.com/apache/lucene-solr/search?l=Java&q=warmupTime
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ X ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [ - ] I have created a Jira issue and added the issue ID to my pull request title.
   - [ X ] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute.
   - [ X ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [ X ] I have developed this patch against the `master` branch.
   - [ - ] I have run `ant precommit` and the appropriate test suite.
   - [ - ] I have added tests for my changes.
   - [ X ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org