You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/13 13:40:09 UTC
[GitHub] [airflow] josh-fell opened a new pull request #18203: Proper handling of custom conn field values in the AzureDataExplorerHook
josh-fell opened a new pull request #18203:
URL: https://github.com/apache/airflow/pull/18203
Closes: #18124
This PR addresses two main issues with the current `AzureDataExplorerHook`:
1. The custom `Azure Data Explorer` connection fields mappings for `Tenant ID` and `Authentication Method` are switched so the hook cannot properly use the values specified.
2. There `get_required_params()` method is passed invalid values and will always raise an exception for a missing required parameter. These invalid values are from the classic `Extras` fields in the connection form which is no longer exposed in the `Azure Data Explorer` connection type.
Additionally there are minor updates made to the hook's docstring for information accuracy and correct rendering of Airflow docs as well as small spelling/grammar changes.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18203: Proper handling of custom conn field values in the AzureDataExplorerHook
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18203:
URL: https://github.com/apache/airflow/pull/18203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org