You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/11/30 15:42:05 UTC
[GitHub] [incubator-mxnet] szha commented on a change in pull request #19596: Fix serialization bug for writing large arrays to npz
szha commented on a change in pull request #19596:
URL: https://github.com/apache/incubator-mxnet/pull/19596#discussion_r532692168
##########
File path: tests/python/unittest/test_numpy_ndarray.py
##########
@@ -999,6 +999,16 @@ def test_setitem_autograd(np_array, index):
test_getitem_slice_bound()
+@use_np
+@pytest.mark.parametrize('load_fn', [_np.load, npx.load])
+def test_np_save_load_large_ndarrays(load_fn, tmp_path):
+ weight = mx.np.arange(32768 * 512).reshape((32768, 512))
Review comment:
adding a few varied sizes may help capture other bugs in the future, including those on the very small and very large ends.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org