You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/05 17:57:38 UTC

[GitHub] vandanavk commented on a change in pull request #12646: ONNX export: Fully connected operator with no bias

vandanavk commented on a change in pull request #12646: ONNX export: Fully connected operator with no bias
URL: https://github.com/apache/incubator-mxnet/pull/12646#discussion_r223091863
 
 

 ##########
 File path: python/mxnet/contrib/onnx/mx2onnx/_op_translations.py
 ##########
 @@ -214,17 +214,42 @@ def convert_fully_connected(node, **kwargs):
     onnx = import_onnx_modules()
     name = node["name"]
     inputs = node["inputs"]
+    attrs = node["attrs"]
+    initializer = kwargs["initializer"]
+
+    no_bias = 1 if ("no_bias" in attrs) and \
 
 Review comment:
   there are 3 such checks (including this) in the current code. Will create a common function. Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services