You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ri...@apache.org on 2010/02/02 12:52:29 UTC

svn commit: r905592 - in /qpid/branches/0.5.x-dev/qpid/java/broker/src/main/java/org/apache/qpid/server: protocol/AMQMinaProtocolSession.java state/AMQStateManager.java

Author: ritchiem
Date: Tue Feb  2 11:52:24 2010
New Revision: 905592

URL: http://svn.apache.org/viewvc?rev=905592&view=rev
Log:
QPID-2370 : Committing patch to improve broker logging. This will not cleanly apply to trunk due to IO changes.

Modified:
    qpid/branches/0.5.x-dev/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQMinaProtocolSession.java
    qpid/branches/0.5.x-dev/qpid/java/broker/src/main/java/org/apache/qpid/server/state/AMQStateManager.java

Modified: qpid/branches/0.5.x-dev/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQMinaProtocolSession.java
URL: http://svn.apache.org/viewvc/qpid/branches/0.5.x-dev/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQMinaProtocolSession.java?rev=905592&r1=905591&r2=905592&view=diff
==============================================================================
--- qpid/branches/0.5.x-dev/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQMinaProtocolSession.java (original)
+++ qpid/branches/0.5.x-dev/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQMinaProtocolSession.java Tue Feb  2 11:52:24 2010
@@ -388,11 +388,13 @@
                             evt.getMethod().getConnectionException(AMQConstant.CHANNEL_ERROR,
                                                                    AMQConstant.CHANNEL_ERROR.getName().toString());
 
+                    _logger.info(e.getMessage() + " whilst processing:" + methodBody);
                     closeConnection(channelId, ce, false);
                 }
             }
             catch (AMQConnectionException e)
             {
+                _logger.info(e.getMessage() + " whilst processing:" + methodBody);
                 closeConnection(channelId, e, false);
             }
         }
@@ -708,7 +710,7 @@
     {
         if (_logger.isInfoEnabled())
         {
-            _logger.info("Closing connection due to: " + e.getMessage());
+            _logger.info("Closing connection due to: " + e);
         }
 
         markChannelAwaitingCloseOk(channelId);

Modified: qpid/branches/0.5.x-dev/qpid/java/broker/src/main/java/org/apache/qpid/server/state/AMQStateManager.java
URL: http://svn.apache.org/viewvc/qpid/branches/0.5.x-dev/qpid/java/broker/src/main/java/org/apache/qpid/server/state/AMQStateManager.java?rev=905592&r1=905591&r2=905592&view=diff
==============================================================================
--- qpid/branches/0.5.x-dev/qpid/java/broker/src/main/java/org/apache/qpid/server/state/AMQStateManager.java (original)
+++ qpid/branches/0.5.x-dev/qpid/java/broker/src/main/java/org/apache/qpid/server/state/AMQStateManager.java Tue Feb  2 11:52:24 2010
@@ -196,7 +196,7 @@
                   || (body instanceof ChannelCloseOkBody)
                   || (body instanceof ChannelCloseBody)))
             {
-                throw body.getConnectionException(AMQConstant.CHANNEL_ERROR, "channel is closed");
+                throw body.getConnectionException(AMQConstant.CHANNEL_ERROR, "channel is closed won't process:" + body);
             }
 
         }



---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org