[GitHub] [tvm] cbalint13 commented on a change in pull request #7382: Add missing round(), floor(), ceil() to codegen_c.cc backend

[GitBox <gi...@apache.org>]

cbalint13 commented on a change in pull request #7382:
URL: https://github.com/apache/tvm/pull/7382#discussion_r568135185



##########
File path: src/target/source/codegen_c.cc
##########
@@ -648,6 +648,21 @@ void CodeGenC::VisitExpr_(const CallNode* op, std::ostream& os) {  // NOLINT(*)
       os << " != ";
       this->PrintExpr(op->args[0], os);
       os << ")";
+    } else if (op->op.as<OpNode>()->name == "tir.round") {

Review comment:
       > This is a great point. Additionally, we can cache the operators in the class member, so the original lookup only happens once in initialization time.
   > 
   > See examples in
   > https://github.com/apache/tvm/blob/main/src/target/llvm/codegen_llvm.h#L352
   
   @tqchen 
   
   Like [```op->op.same_as(builtin::isnan())```](https://github.com/apache/tvm/blob/2365c7ee6620f672c172247afc73da3884165884/src/target/source/codegen_c.cc#L645) , right ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org