You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by atomtong <gi...@git.apache.org> on 2017/07/19 09:12:20 UTC
[GitHub] incubator-weex pull request #521: if render pageName setting Incorrect .in d...
GitHub user atomtong opened a pull request:
https://github.com/apache/incubator-weex/pull/521
if render pageName setting Incorrect .in debug mode sdkinstance will render a default error page instead
+ if render pageName setting Incorrect .in debug mode sdkinstance will render a default error page instead
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/atomtong/incubator-weex 0.15-dev-feature-pageName-not-setting
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/521.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #521
----
commit 6f840d926a69dd8c85216cb6ad08b8b8c6c5e958
Author: atomtong <to...@qq.com>
Date: 2017-07-19T08:46:37Z
* [android] pageName if not set page will nav to a default weex page in debug mode
commit d395102c1bee7f037d912a1a0c688567d36a028d
Author: atomtong <to...@qq.com>
Date: 2017-07-19T09:10:05Z
Merge branch '0.15-hub-dev' into 0.15-dev-feature-pageName-not-setting
* 0.15-hub-dev:
* [doc] Change the doc of timer.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #521: if render pageName setting Incorrect .in d...
Posted by atomtong <gi...@git.apache.org>.
GitHub user atomtong reopened a pull request:
https://github.com/apache/incubator-weex/pull/521
if render pageName setting Incorrect .in debug mode sdkinstance will render a default error page instead
+ if render pageName setting Incorrect .in debug mode sdkinstance will render a default error page instead
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/atomtong/incubator-weex 0.15-dev-feature-pageName-not-setting
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/521.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #521
----
commit 6f840d926a69dd8c85216cb6ad08b8b8c6c5e958
Author: atomtong <to...@qq.com>
Date: 2017-07-19T08:46:37Z
* [android] pageName if not set page will nav to a default weex page in debug mode
commit d395102c1bee7f037d912a1a0c688567d36a028d
Author: atomtong <to...@qq.com>
Date: 2017-07-19T09:10:05Z
Merge branch '0.15-hub-dev' into 0.15-dev-feature-pageName-not-setting
* 0.15-hub-dev:
* [doc] Change the doc of timer.
commit 503efbaaa63af9dd440478a12da3855b33a292c4
Author: atomtong <to...@qq.com>
Date: 2017-07-19T09:16:17Z
* [android] test pageName is null on playground
commit 2882fe460f0bdc6284430927ebe60f1d4f875a36
Author: atomtong <to...@qq.com>
Date: 2017-07-25T03:40:42Z
* [android] if pageName not be set, throw new WXRuntimeException with error msg.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #521: if render pageName setting Incorrect .in debug mo...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/521
<!--
1 failure: This PR modify SD...
2 warning: No Changelog chan..., This PR should up...
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>This PR modify SDK code. Please add/modify corresponding testcases. If it is ok, please comment about it. Or put '@notdanger' in you commit message.</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #521: if render pageName setting Incorrect .in d...
Posted by atomtong <gi...@git.apache.org>.
Github user atomtong closed the pull request at:
https://github.com/apache/incubator-weex/pull/521
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #521: if render pageName setting Incorrect .in d...
Posted by atomtong <gi...@git.apache.org>.
Github user atomtong closed the pull request at:
https://github.com/apache/incubator-weex/pull/521
---