You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/12 19:52:58 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #4136: libc/string: Skip compile the c version when the optimization is enabled
xiaoxiang781216 opened a new pull request #4136:
URL: https://github.com/apache/incubator-nuttx/pull/4136
## Summary
To avoid the symbol duplication linker error
## Impact
Change Makefile only
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4136: libc/string: Skip compile the c version when the optimization is enabled
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4136:
URL: https://github.com/apache/incubator-nuttx/pull/4136#discussion_r668416645
##########
File path: libs/libc/string/Make.defs
##########
@@ -43,6 +47,26 @@ CSRCS += lib_memcpy.c
endif
endif
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4136: libc/string: Skip compile the c version when the optimization is enabled
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4136:
URL: https://github.com/apache/incubator-nuttx/pull/4136#discussion_r668174934
##########
File path: libs/libc/string/Make.defs
##########
@@ -43,6 +47,26 @@ CSRCS += lib_memcpy.c
endif
endif
Review comment:
How about adding all the remaining functions that already have Kconfig options created?
- LIBC_ARCH_MEMCMP
- LIBC_ARCH_STRCHR
- LIBC_ARCH_STRLCPY
- LIBC_ARCH_STRNCPY
- LIBC_ARCH_STRNLEN
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei merged pull request #4136: libc/string: Skip compile the c version when the optimization is enabled
Posted by GitBox <gi...@apache.org>.
gustavonihei merged pull request #4136:
URL: https://github.com/apache/incubator-nuttx/pull/4136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org