Re: [PR] [SPARK-46179][SQL] Add CrossDbmsQueryTestSuites, which allows generating golden files with other DBMS, starting off with Postgres [spark]

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on PR #44084:
URL: https://github.com/apache/spark/pull/44084#issuecomment-1873936713

   > That makes sense. I think all DBMS can share the same golden file, if we make the queries simple enough that they are compatible with all DBMS.
   
   Makes sense to me. Then shall we always let Spark generate golden files? What we need to do is to let other DBMS run the query and compare results with golden files (exclude the schema part). I think keeping a single golden file is important to verify the results, otherwise we need human to make sure two golden files are equal.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org