You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/05 11:55:44 UTC

[GitHub] [cordova-plugin-inappbrowser] NiklasMerz opened a new pull request #717: (ios): update CI for Xcode 11

NiklasMerz opened a new pull request #717:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/717


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   See build issues in #688 
   
   ### Description
   <!-- Describe your changes in detail -->
   Updates paramedic config
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-inappbrowser] brodybits commented on pull request #717: (ios): update CI for Xcode 11

Posted by GitBox <gi...@apache.org>.
brodybits commented on pull request #717:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/717#issuecomment-640564252


   I think it would be ideal if we could migrate to GitHub actions, like we have with cordova-ios.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-inappbrowser] NiklasMerz commented on pull request #717: (ios): update CI for Xcode 11

Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on pull request #717:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/717#issuecomment-639451297


   Config seems to be working. It now somehow fails with UserAgent stuff that should be gone:
   
   ```
   /var/folders/z3/_825pg0s3jvf0hb_q8kzmg5h0000gn/T/tmp-4273wd2NTrUjtYlp/platforms/ios/HelloCordova/Plugins/cordova-plugin-wkwebview-engine/CDVWKWebViewEngine.m:104:80: error: property 'userAgent' not found on object of type 'CDVViewController *'
   
           wkWebView.customUserAgent = ((CDVViewController*) self.viewController).userAgent;
   
                                                                                  ^
   
   /var/folders/z3/_825pg0s3jvf0hb_q8kzmg5h0000gn/T/tmp-4273wd2NTrUjtYlp/platforms/ios/HelloCordova/Plugins/cordova-plugin-wkwebview-engine/CDVWKWebViewEngine.m:375:6: error: use of undeclared identifier 'CDVUserAgentUtil'
   
       [CDVUserAgentUtil releaseLock:vc.userAgentLockToken];
   
        ^
   
   /var/folders/z3/_825pg0s3jvf0hb_q8kzmg5h0000gn/T/tmp-4273wd2NTrUjtYlp/platforms/ios/HelloCordova/Plugins/cordova-plugin-wkwebview-engine/CDVWKWebViewEngine.m:388:6: error: use of undeclared identifier 'CDVUserAgentUtil'
   
       [CDVUserAgentUtil releaseLock:vc.userAgentLockToken];
   
        ^
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-inappbrowser] NiklasMerz commented on a change in pull request #717: (ios): update CI for Xcode 11

Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on a change in pull request #717:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/717#discussion_r452061050



##########
File path: .travis.yml
##########
@@ -81,7 +81,7 @@ before_install:
   - if [[ "$PLATFORM" =~ ios ]]; then npm install -g ios-deploy; fi
   - npm install -g cordova
   # install paramedic if not running on paramedic repo
-  - if ! [[ "$TRAVIS_REPO_SLUG" =~ cordova-paramedic ]]; then npm install -g github:apache/cordova-paramedic; fi
+  - if ! [[ "$TRAVIS_REPO_SLUG" =~ cordova-paramedic ]]; then npm install -g github:apache/cordova-paramedic#ios13-test; fi

Review comment:
       Work in progress 😀




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-inappbrowser] NiklasMerz merged pull request #717: ci(ios): remove wkwebview plugin

Posted by GitBox <gi...@apache.org>.
NiklasMerz merged pull request #717:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/717


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-inappbrowser] NiklasMerz removed a comment on pull request #717: (ios): update CI for Xcode 11

Posted by GitBox <gi...@apache.org>.
NiklasMerz removed a comment on pull request #717:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/717#issuecomment-639451297


   Config seems to be working. It now somehow fails with UserAgent stuff that should be gone:
   
   ```
   /var/folders/z3/_825pg0s3jvf0hb_q8kzmg5h0000gn/T/tmp-4273wd2NTrUjtYlp/platforms/ios/HelloCordova/Plugins/cordova-plugin-wkwebview-engine/CDVWKWebViewEngine.m:104:80: error: property 'userAgent' not found on object of type 'CDVViewController *'
   
           wkWebView.customUserAgent = ((CDVViewController*) self.viewController).userAgent;
   
                                                                                  ^
   
   /var/folders/z3/_825pg0s3jvf0hb_q8kzmg5h0000gn/T/tmp-4273wd2NTrUjtYlp/platforms/ios/HelloCordova/Plugins/cordova-plugin-wkwebview-engine/CDVWKWebViewEngine.m:375:6: error: use of undeclared identifier 'CDVUserAgentUtil'
   
       [CDVUserAgentUtil releaseLock:vc.userAgentLockToken];
   
        ^
   
   /var/folders/z3/_825pg0s3jvf0hb_q8kzmg5h0000gn/T/tmp-4273wd2NTrUjtYlp/platforms/ios/HelloCordova/Plugins/cordova-plugin-wkwebview-engine/CDVWKWebViewEngine.m:388:6: error: use of undeclared identifier 'CDVUserAgentUtil'
   
       [CDVUserAgentUtil releaseLock:vc.userAgentLockToken];
   
        ^
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-inappbrowser] NiklasMerz commented on pull request #717: ci(ios): remove wkwebview plugin

Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on pull request #717:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/717#issuecomment-731105017


   Repurposed the PR to remove the plugin and fix the tests again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-inappbrowser] timbru31 commented on a change in pull request #717: (ios): update CI for Xcode 11

Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #717:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/717#discussion_r452057167



##########
File path: .travis.yml
##########
@@ -81,7 +81,7 @@ before_install:
   - if [[ "$PLATFORM" =~ ios ]]; then npm install -g ios-deploy; fi
   - npm install -g cordova
   # install paramedic if not running on paramedic repo
-  - if ! [[ "$TRAVIS_REPO_SLUG" =~ cordova-paramedic ]]; then npm install -g github:apache/cordova-paramedic; fi
+  - if ! [[ "$TRAVIS_REPO_SLUG" =~ cordova-paramedic ]]; then npm install -g github:apache/cordova-paramedic#ios13-test; fi

Review comment:
       🥁 😄 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-inappbrowser] NiklasMerz commented on pull request #717: (ios): update CI for Xcode 11

Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on pull request #717:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/717#issuecomment-639528489


   Build is now successful but simulator times out...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org