You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "asbachb (via GitHub)" <gi...@apache.org> on 2023/05/29 07:35:19 UTC
[GitHub] [netbeans-mavenutils-archetypes] asbachb opened a new pull request, #2: Created a maven-archetype which is able to generate a web application…
asbachb opened a new pull request, #2:
URL: https://github.com/apache/netbeans-mavenutils-archetypes/pull/2
… skeleton for:
* Jakarta EE Full (8.0.0, 9.0.0, 9.1.0, 10.0.0)
* Jakarta EE Web (8.0.0, 9.0.0, 9.1.0, 10.0.0)
* Jakarta EE Core (8.0.0, 9.0.0, 9.1.0, 10.0.0)
Core, Web and Full add `web.xml`, `beans.xml` Web and Full add `persistence.xml` additionally
All xmls are using the specific schema versions for the selected Jakarta EE version.
This archetype can be configured via properties:
* `javaVersion`: 11, [17]
* `jakartaee`: [jakartaee], jakartaee-web, jakartaee-core
* `jakartaEEVersion`: 8.0.0, 9.0.0, 9.1.0, [10.0.0]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-archetypes] asbachb commented on pull request #2: Created a maven-archetype which is able to generate a web application…
Posted by "asbachb (via GitHub)" <gi...@apache.org>.
asbachb commented on PR #2:
URL: https://github.com/apache/netbeans-mavenutils-archetypes/pull/2#issuecomment-1570357417
@ebarboni
> Could you change NetBeans by Apache NetBeans ? in the pom description.
Changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-archetypes] asbachb commented on a diff in pull request #2: Created a maven-archetype which is able to generate a web application…
Posted by "asbachb (via GitHub)" <gi...@apache.org>.
asbachb commented on code in PR #2:
URL: https://github.com/apache/netbeans-mavenutils-archetypes/pull/2#discussion_r1211819860
##########
netbeans-jakartaee-war-archetype/src/main/resources/META-INF/archetype-post-generate.groovy:
##########
@@ -0,0 +1,10 @@
+dir = new File(new File(request.outputDirectory), request.artifactId)
+
+jakartaEEVariant = request.getProperties().get("jakartaEEVariant")
+
+if ("jakartaee-core".equals(jakartaEEVariant)) {
+ dir = new File(new File(request.outputDirectory), request.artifactId)
+ persistenceXml = new File(dir.toString() + "/src/main/resources/META-INF/persistence.xml");
+
+ persistenceXml.delete()
+}
Review Comment:
Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-archetypes] mbien commented on a diff in pull request #2: Created a maven-archetype which is able to generate a web application…
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #2:
URL: https://github.com/apache/netbeans-mavenutils-archetypes/pull/2#discussion_r1210543709
##########
netbeans-jakartaee-war-archetype/src/main/resources/META-INF/archetype-post-generate.groovy:
##########
@@ -0,0 +1,10 @@
+dir = new File(new File(request.outputDirectory), request.artifactId)
+
+jakartaEEVariant = request.getProperties().get("jakartaEEVariant")
+
+if ("jakartaee-core".equals(jakartaEEVariant)) {
+ dir = new File(new File(request.outputDirectory), request.artifactId)
+ persistenceXml = new File(dir.toString() + "/src/main/resources/META-INF/persistence.xml");
+
+ persistenceXml.delete()
+}
Review Comment:
nitpick: consider adding new line before end of file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-archetypes] asbachb commented on pull request #2: Created a maven-archetype which is able to generate a web application…
Posted by "asbachb (via GitHub)" <gi...@apache.org>.
asbachb commented on PR #2:
URL: https://github.com/apache/netbeans-mavenutils-archetypes/pull/2#issuecomment-1566693642
Can you please double check:
- [ ] Maven coordinates
- [ ] Created project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-archetypes] mbien commented on a diff in pull request #2: Created a maven-archetype which is able to generate a web application…
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #2:
URL: https://github.com/apache/netbeans-mavenutils-archetypes/pull/2#discussion_r1210543912
##########
netbeans-jakartaee-war-archetype/src/main/resources/archetype-resources/pom.xml:
##########
@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>${groupId}</groupId>
+ <artifactId>${artifactId}</artifactId>
+ <version>${version}</version>
+ <packaging>war</packaging>
+
+ <properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ <maven.compiler.source>${javaVersion}</maven.compiler.source>
+ <maven.compiler.target>${javaVersion}</maven.compiler.target>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>jakarta.platform</groupId>
+ <artifactId>jakarta.${jakartaEEVariant}-api</artifactId>
+ <version>${jakartaEEVersion}</version>
+ <scope>provided</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>3.1.0</version>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-war-plugin</artifactId>
+ <version>3.3.2</version>
+ </plugin>
+ </plugins>
+ </build>
+</project>
Review Comment:
nitpick: consider adding new line
##########
netbeans-jakartaee-war-archetype/src/main/resources/archetype-resources/pom.xml:
##########
@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>${groupId}</groupId>
+ <artifactId>${artifactId}</artifactId>
+ <version>${version}</version>
+ <packaging>war</packaging>
+
+ <properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ <maven.compiler.source>${javaVersion}</maven.compiler.source>
+ <maven.compiler.target>${javaVersion}</maven.compiler.target>
Review Comment:
would it be possible to make it use `maven.compiler.release` for versions > 8?
##########
netbeans-jakartaee-war-archetype/src/main/resources/archetype-resources/src/main/webapp/WEB-INF/beans.xml:
##########
@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="UTF-8"?>
+#if( $jakartaEEVersion == '8.0.0')
+ #set( $xmlns = 'https://xmlns.jcp.org/xml/ns/javaee' )
+ #set( $xsiSchemaLocation = 'https://xmlns.jcp.org/xml/ns/javaee https://xmlns.jcp.org/xml/ns/javaee/beans_2_0.xsd' )
+ #set( $version = '2.0' )
+#else
+ #set( $xmlns = 'https://jakarta.ee/xml/ns/jakartaee' )
+ #if( $jakartaEEVersion == '9.0.0' || $jakartaEEVersion == '9.1.0' )
+ #set( $xsiSchemaLocation = 'https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/beans_3_0.xsd' )
+ #set( $version = '3.0' )
+ #else
+ #set( $xsiSchemaLocation = 'https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/beans_4_0.xsd' )
+ #set( $version = '4.0' )
+ #end
+#end
+
+<beans xmlns="$xmlns"
+ xmlns:xsi="https://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="$xsiSchemaLocation"
+ bean-discovery-mode="all"
+ version="$version">
+</beans>
Review Comment:
nitpick: consider adding new line
##########
netbeans-jakartaee-war-archetype/src/main/resources/META-INF/archetype-post-generate.groovy:
##########
@@ -0,0 +1,10 @@
+dir = new File(new File(request.outputDirectory), request.artifactId)
+
+jakartaEEVariant = request.getProperties().get("jakartaEEVariant")
+
+if ("jakartaee-core".equals(jakartaEEVariant)) {
+ dir = new File(new File(request.outputDirectory), request.artifactId)
+ persistenceXml = new File(dir.toString() + "/src/main/resources/META-INF/persistence.xml");
+
+ persistenceXml.delete()
+}
Review Comment:
nitpick: consider adding new line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-archetypes] asbachb commented on a diff in pull request #2: Created a maven-archetype which is able to generate a web application…
Posted by "asbachb (via GitHub)" <gi...@apache.org>.
asbachb commented on code in PR #2:
URL: https://github.com/apache/netbeans-mavenutils-archetypes/pull/2#discussion_r1211820265
##########
netbeans-jakartaee-war-archetype/src/main/resources/archetype-resources/pom.xml:
##########
@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>${groupId}</groupId>
+ <artifactId>${artifactId}</artifactId>
+ <version>${version}</version>
+ <packaging>war</packaging>
+
+ <properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ <maven.compiler.source>${javaVersion}</maven.compiler.source>
+ <maven.compiler.target>${javaVersion}</maven.compiler.target>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>jakarta.platform</groupId>
+ <artifactId>jakarta.${jakartaEEVariant}-api</artifactId>
+ <version>${jakartaEEVersion}</version>
+ <scope>provided</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>3.1.0</version>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-war-plugin</artifactId>
+ <version>3.3.2</version>
+ </plugin>
+ </plugins>
+ </build>
+</project>
Review Comment:
Added.
##########
netbeans-jakartaee-war-archetype/src/main/resources/archetype-resources/src/main/webapp/WEB-INF/beans.xml:
##########
@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="UTF-8"?>
+#if( $jakartaEEVersion == '8.0.0')
+ #set( $xmlns = 'https://xmlns.jcp.org/xml/ns/javaee' )
+ #set( $xsiSchemaLocation = 'https://xmlns.jcp.org/xml/ns/javaee https://xmlns.jcp.org/xml/ns/javaee/beans_2_0.xsd' )
+ #set( $version = '2.0' )
+#else
+ #set( $xmlns = 'https://jakarta.ee/xml/ns/jakartaee' )
+ #if( $jakartaEEVersion == '9.0.0' || $jakartaEEVersion == '9.1.0' )
+ #set( $xsiSchemaLocation = 'https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/beans_3_0.xsd' )
+ #set( $version = '3.0' )
+ #else
+ #set( $xsiSchemaLocation = 'https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/beans_4_0.xsd' )
+ #set( $version = '4.0' )
+ #end
+#end
+
+<beans xmlns="$xmlns"
+ xmlns:xsi="https://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="$xsiSchemaLocation"
+ bean-discovery-mode="all"
+ version="$version">
+</beans>
Review Comment:
Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-archetypes] mbien commented on a diff in pull request #2: Created a maven-archetype which is able to generate a web application…
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #2:
URL: https://github.com/apache/netbeans-mavenutils-archetypes/pull/2#discussion_r1212012881
##########
netbeans-jakartaee-war-archetype/src/main/resources/archetype-resources/pom.xml:
##########
@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>${groupId}</groupId>
+ <artifactId>${artifactId}</artifactId>
+ <version>${version}</version>
+ <packaging>war</packaging>
+
+ <properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ <maven.compiler.source>${javaVersion}</maven.compiler.source>
+ <maven.compiler.target>${javaVersion}</maven.compiler.target>
Review Comment:
this is pretty cool. I somehow forgot about the fact that maven can run groovy scripts as project creation step.
This will likely also allow us to set the right JVM flags for netbeans modules:
https://github.com/apache/netbeans/tree/master/nbbuild/jms-config
once we update this archetype. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-archetypes] ebarboni commented on pull request #2: Created a maven-archetype which is able to generate a web application…
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #2:
URL: https://github.com/apache/netbeans-mavenutils-archetypes/pull/2#issuecomment-1568632363
Could you change NetBeans by Apache NetBeans ? in the pom description.
We need to add rat, and exclusion this could be done in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-archetypes] mbien commented on a diff in pull request #2: Created a maven-archetype which is able to generate a web application…
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #2:
URL: https://github.com/apache/netbeans-mavenutils-archetypes/pull/2#discussion_r1210543912
##########
netbeans-jakartaee-war-archetype/src/main/resources/archetype-resources/pom.xml:
##########
@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>${groupId}</groupId>
+ <artifactId>${artifactId}</artifactId>
+ <version>${version}</version>
+ <packaging>war</packaging>
+
+ <properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ <maven.compiler.source>${javaVersion}</maven.compiler.source>
+ <maven.compiler.target>${javaVersion}</maven.compiler.target>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>jakarta.platform</groupId>
+ <artifactId>jakarta.${jakartaEEVariant}-api</artifactId>
+ <version>${jakartaEEVersion}</version>
+ <scope>provided</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>3.1.0</version>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-war-plugin</artifactId>
+ <version>3.3.2</version>
+ </plugin>
+ </plugins>
+ </build>
+</project>
Review Comment:
nitpick: consider adding new line before end of file
##########
netbeans-jakartaee-war-archetype/src/main/resources/archetype-resources/src/main/webapp/WEB-INF/beans.xml:
##########
@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="UTF-8"?>
+#if( $jakartaEEVersion == '8.0.0')
+ #set( $xmlns = 'https://xmlns.jcp.org/xml/ns/javaee' )
+ #set( $xsiSchemaLocation = 'https://xmlns.jcp.org/xml/ns/javaee https://xmlns.jcp.org/xml/ns/javaee/beans_2_0.xsd' )
+ #set( $version = '2.0' )
+#else
+ #set( $xmlns = 'https://jakarta.ee/xml/ns/jakartaee' )
+ #if( $jakartaEEVersion == '9.0.0' || $jakartaEEVersion == '9.1.0' )
+ #set( $xsiSchemaLocation = 'https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/beans_3_0.xsd' )
+ #set( $version = '3.0' )
+ #else
+ #set( $xsiSchemaLocation = 'https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/beans_4_0.xsd' )
+ #set( $version = '4.0' )
+ #end
+#end
+
+<beans xmlns="$xmlns"
+ xmlns:xsi="https://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="$xsiSchemaLocation"
+ bean-discovery-mode="all"
+ version="$version">
+</beans>
Review Comment:
nitpick: consider adding new line before end of file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-archetypes] asbachb commented on a diff in pull request #2: Created a maven-archetype which is able to generate a web application…
Posted by "asbachb (via GitHub)" <gi...@apache.org>.
asbachb commented on code in PR #2:
URL: https://github.com/apache/netbeans-mavenutils-archetypes/pull/2#discussion_r1211819443
##########
netbeans-jakartaee-war-archetype/src/main/resources/archetype-resources/pom.xml:
##########
@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>${groupId}</groupId>
+ <artifactId>${artifactId}</artifactId>
+ <version>${version}</version>
+ <packaging>war</packaging>
+
+ <properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ <maven.compiler.source>${javaVersion}</maven.compiler.source>
+ <maven.compiler.target>${javaVersion}</maven.compiler.target>
Review Comment:
I implemented a prototype where this is adjusted in the post project creation groovy script: https://github.com/asbachb/netbeans-mavenutils-archetypes/blob/master/netbeans-jakartaee-war-archetype/src/main/resources/META-INF/archetype-post-generate.groovy#L10-L21
Not 100% if I like it, but it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-archetypes] ebarboni merged pull request #2: Created a maven-archetype which is able to generate a web application…
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni merged PR #2:
URL: https://github.com/apache/netbeans-mavenutils-archetypes/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists