[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31109: [SPARK-33970][SQL][TEST] Add test default partition in metastoredirectsql

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #31109:
URL: https://github.com/apache/spark/pull/31109#discussion_r555260783



##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HivePartitionFilteringSuite.scala
##########
@@ -39,10 +40,13 @@ class HivePartitionFilteringSuite(version: String)
 
   private val tryDirectSqlKey = HiveConf.ConfVars.METASTORE_TRY_DIRECT_SQL.varname
 
+  // Support default partition in metastoredirectsql since HIVE-11898(Hive 2.0.0).
+  private val defaultPartition = if (version.toDouble >= 2) Some(DEFAULT_PARTITION_NAME) else None

Review comment:
       If you don't mind, can we use string comparison instead? Something like, `version >= "2.0.0"`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org