You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "chunxiaozheng (via GitHub)" <gi...@apache.org> on 2024/04/29 02:53:51 UTC
[PR] [fix] prevent offload non-persistent or system topics [pulsar]
chunxiaozheng opened a new pull request, #22612:
URL: https://github.com/apache/pulsar/pull/22612
When ledger is closed, do not offload when this ledger is non-persistent or system topics.
<!-- Details of when a PIP is required and how the PIP process work, please see: https://github.com/apache/pulsar/blob/master/pip/README.md -->
### Motivation
When ledger is closed, do not offload when this ledger is non-persistent or system topics.
### Modifications
<!-- Describe the modifications you've done. -->
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] prevent offload non-persistent or system topics [pulsar]
Posted by "chunxiaozheng (via GitHub)" <gi...@apache.org>.
chunxiaozheng closed pull request #22612: [fix] prevent offload non-persistent or system topics
URL: https://github.com/apache/pulsar/pull/22612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] prevent offload non-persistent or system topics [pulsar]
Posted by "dao-jun (via GitHub)" <gi...@apache.org>.
dao-jun commented on PR #22612:
URL: https://github.com/apache/pulsar/pull/22612#issuecomment-2099753208
@chunxiaozheng https://github.com/apache/pulsar/pull/22497 merged, let's close this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] prevent offload non-persistent or system topics [pulsar]
Posted by "dao-jun (via GitHub)" <gi...@apache.org>.
dao-jun commented on PR #22612:
URL: https://github.com/apache/pulsar/pull/22612#issuecomment-2081810490
NonPersistentTopic has no ledgers to persist messages, so we don't need to care about it.
About SystemTopic, I remember there is a PR to fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] prevent offload non-persistent or system topics [pulsar]
Posted by "dao-jun (via GitHub)" <gi...@apache.org>.
dao-jun commented on PR #22612:
URL: https://github.com/apache/pulsar/pull/22612#issuecomment-2081833142
> > Got it, #22497
>
> Thanks! But I see the #22497 did not merge. In our scenario, due to system topic triggered offload, many exceptions were printed in the log, so I submitted the above modifications
let me ask him, if there is no other problems, I'll reopen and merge it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] prevent offload non-persistent or system topics [pulsar]
Posted by "chunxiaozheng (via GitHub)" <gi...@apache.org>.
chunxiaozheng commented on PR #22612:
URL: https://github.com/apache/pulsar/pull/22612#issuecomment-2081822077
> Got it, #22497
Thanks! But I see the #22497 did not merge. In our scenario, due to system topic triggered offload, many exceptions were printed in the log, so I submitted the above modifications
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] prevent offload non-persistent or system topics [pulsar]
Posted by "chunxiaozheng (via GitHub)" <gi...@apache.org>.
chunxiaozheng commented on PR #22612:
URL: https://github.com/apache/pulsar/pull/22612#issuecomment-2102136219
> @chunxiaozheng #22497 merged, let's close this PR
okay，thanks！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] prevent offload non-persistent or system topics [pulsar]
Posted by "dao-jun (via GitHub)" <gi...@apache.org>.
dao-jun commented on PR #22612:
URL: https://github.com/apache/pulsar/pull/22612#issuecomment-2081810616
Got it, https://github.com/apache/pulsar/pull/22497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] prevent offload non-persistent or system topics [pulsar]
Posted by "chunxiaozheng (via GitHub)" <gi...@apache.org>.
chunxiaozheng commented on PR #22612:
URL: https://github.com/apache/pulsar/pull/22612#issuecomment-2081841242
> > > Got it, #22497
> >
> >
> > Thanks! But I see the #22497 did not merge. In our scenario, due to system topic triggered offload, many exceptions were printed in the log, so I submitted the above modifications
>
> let me ask him, if there is no other problems, I'll reopen and merge it
Thanks！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org