You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/04/08 10:49:18 UTC

[GitHub] [james-project] fiery06 opened a new pull request #373: JAMES-3405 Add Prometheus config

fiery06 opened a new pull request #373:
URL: https://github.com/apache/james-project/pull/373


   The guide part for ES are restored. 
   Added metric configuration with Prometheus + example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] chibenwa merged pull request #373: JAMES-3405 Add Prometheus config

Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #373:
URL: https://github.com/apache/james-project/pull/373


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] chibenwa commented on pull request #373: JAMES-3405 Add Prometheus config

Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #373:
URL: https://github.com/apache/james-project/pull/373#issuecomment-816543973


   I like that you create :
   
   ```
   docs/modules/servers/pages/distributed/operate/metrics_es.adoc
   docs/modules/servers/pages/distributed/operate/metrics_prometheus.adoc 
   ```
   
   Then we should move all content of `docs/modules/servers/pages/distributed/operate/metrics.adoc ` linked to Prometheus to `metrics_prometheus.adoc ` and all linked to ES to `metrics_es.adoc`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] chibenwa commented on pull request #373: JAMES-3405 Add Prometheus config

Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #373:
URL: https://github.com/apache/james-project/pull/373#issuecomment-816542168


   I disagree with changes to `docs/modules/servers/pages/distributed/run-docker.adoc `
   
   A proper 3.6.0 docker image set will be uploaded for the release, we should then remember to update the docker-compose then.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] fiery06 commented on a change in pull request #373: JAMES-3405 Add Prometheus config

Posted by GitBox <gi...@apache.org>.
fiery06 commented on a change in pull request #373:
URL: https://github.com/apache/james-project/pull/373#discussion_r611533343



##########
File path: docs/modules/servers/pages/distributed/operate/metrics.adoc
##########
@@ -7,16 +7,101 @@ for keeping track of some core metrics of James.
 Such metrics are made available via JMX. You can connect for instance using VisualVM and the associated
 mbean plugins.
 
-You can also export the metrics to ElasticSearch and visualize them with https://grafana.com/[Grafana].
-See xref:distributed/configure/elasticsearch.adoc#_exporting_metrics_directly_to_elasticsearch[elaticseach.properties]
-documentation for more details on how to set this up.
+We also support displaying them via https://grafana.com/[Grafana]. Two methods can be used to back grafana display:
 
-If some metrics seem abnormally slow despite in depth database
-performance tuning, feedback is appreciated as well on the bug tracker,
-the user mailing list or our Gitter channel (see our
-http://james.apache.org/#second[community page]) . Any additional
-details categorizing the slowness are appreciated as well (details of
-the slow requests for instance).
+ - Prometheus metric collection - Data are exposed on a HTTP endpoint for Prometheus scrape.
+ - ElasticSearch metric collection - This method is depreciated and will be removed in next version.
+ 
+== Expose metrics for Prometheus collection
+
+Metrics can be exposed over HTTP and made available by using ``extensions.routes`` in James https://github.com/apache/james-project/blob/master/docs/modules/servers/pages/distributed/configure/webadmin.adoc[webadmin.properties] file:
+....
+extensions.routes=org.apache.james.webadmin.dropwizard.MetricsRoutes
+....
+You can test the result by accessing to: 
+....
+http://james_server:8000/metrics
+....
+
+== Running James with Prometheus
+
+Make the below changes to scrape job config in ``prometheus.yml`` to collect the data for Grafana dashboard.
+....
+global:
+  scrape_interval:     15s # Set the scrape interval to every 15 seconds. Default is every 1 minute.
+  evaluation_interval: 15s # Evaluate rules every 15 seconds. The default is every 1 minute.
+  # scrape_timeout is set to the global default (10s).
+
+alerting:
+  alertmanagers:
+  - static_configs:
+    - targets:
+      # - alertmanager:9093
+
+rule_files:
+  # - "first_rules.yml"
+  # - "second_rules.yml"
+
+scrape_configs:
+  # The job name is added as a label `job=<job_name>` to any timeseries scraped from this config.
+  - job_name: 'prometheus'
+    scrape_interval: 5s
+    static_configs:
+      - targets: ['localhost:9090']
+  - job_name: 'Apache James'
+    scrape_interval: 5s
+    metrics_path: /metrics
+    static_configs:
+      - targets: ['james:8000']
+....
+
+You can download the dashboard json files and use https://grafana.com/tutorials/provision-dashboards-and-data-sources/[Grafana provision] to make the metrics datasource and dashboards available after container creation. [Insert link to Prometheus json files.]
+
+Update the https://github.com/grafana/grafana/blob/master/conf/sample.ini[grafana.ini] configuration file in the ``/etc/grafana/grafana.ini`` to override default configuration options. You only need to change the provisioning folder path:
+
+```
+;provisioning = /etc/grafana/provisioning
+```
+
+Create the provisioning folder tree and copy all the dashboard json files to ``/provisioning/dashboards/james/``
+
+    |-- provisioning
+        |-- dashboards
+            |-- defaults.yml
+            |-- james
+        |-- datasources
+            |-- prometheus.yml

Review comment:
       name changed to avoid confuse




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] chibenwa commented on a change in pull request #373: JAMES-3405 Add Prometheus config

Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #373:
URL: https://github.com/apache/james-project/pull/373#discussion_r611285498



##########
File path: docs/modules/servers/pages/distributed/run-docker.adoc
##########
@@ -10,20 +10,21 @@ When you try James this way, you will use the most current state of James.
 It will be configured to run with Cassandra & ElasticSearch.
 All those three components will be started with a single command.
 
-You can retrieve the docker-compose file :
+You can retrieve the docker-compose file : ( docker-compose file and james image name should be changed) 
 
-    $ wget https://raw.githubusercontent.com/apache/james-project/master/dockerfiles/run/docker-compose.yml
+    $ wget https://raw.githubusercontent.com/apache/james-project/master/dockerfiles/run/docker-compose-branch-master.yml
+   

Review comment:
       Please revert all changes to this file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] chibenwa commented on a change in pull request #373: JAMES-3405 Add Prometheus config

Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #373:
URL: https://github.com/apache/james-project/pull/373#discussion_r611327741



##########
File path: docs/modules/servers/pages/distributed/operate/metrics.adoc
##########
@@ -7,16 +7,101 @@ for keeping track of some core metrics of James.
 Such metrics are made available via JMX. You can connect for instance using VisualVM and the associated
 mbean plugins.
 
-You can also export the metrics to ElasticSearch and visualize them with https://grafana.com/[Grafana].
-See xref:distributed/configure/elasticsearch.adoc#_exporting_metrics_directly_to_elasticsearch[elaticseach.properties]
-documentation for more details on how to set this up.
+We also support displaying them via https://grafana.com/[Grafana]. Two methods can be used to back grafana display:
 
-If some metrics seem abnormally slow despite in depth database
-performance tuning, feedback is appreciated as well on the bug tracker,
-the user mailing list or our Gitter channel (see our
-http://james.apache.org/#second[community page]) . Any additional
-details categorizing the slowness are appreciated as well (details of
-the slow requests for instance).
+ - Prometheus metric collection - Data are exposed on a HTTP endpoint for Prometheus scrape.
+ - ElasticSearch metric collection - This method is depreciated and will be removed in next version.
+ 
+== Expose metrics for Prometheus collection
+
+Metrics can be exposed over HTTP and made available by using ``extensions.routes`` in James https://github.com/apache/james-project/blob/master/docs/modules/servers/pages/distributed/configure/webadmin.adoc[webadmin.properties] file:
+....
+extensions.routes=org.apache.james.webadmin.dropwizard.MetricsRoutes
+....
+You can test the result by accessing to: 
+....
+http://james_server:8000/metrics
+....
+
+== Running James with Prometheus
+
+Make the below changes to scrape job config in ``prometheus.yml`` to collect the data for Grafana dashboard.
+....
+global:
+  scrape_interval:     15s # Set the scrape interval to every 15 seconds. Default is every 1 minute.
+  evaluation_interval: 15s # Evaluate rules every 15 seconds. The default is every 1 minute.
+  # scrape_timeout is set to the global default (10s).
+
+alerting:
+  alertmanagers:
+  - static_configs:
+    - targets:
+      # - alertmanager:9093
+
+rule_files:
+  # - "first_rules.yml"
+  # - "second_rules.yml"
+
+scrape_configs:
+  # The job name is added as a label `job=<job_name>` to any timeseries scraped from this config.
+  - job_name: 'prometheus'
+    scrape_interval: 5s
+    static_configs:
+      - targets: ['localhost:9090']
+  - job_name: 'Apache James'
+    scrape_interval: 5s
+    metrics_path: /metrics
+    static_configs:
+      - targets: ['james:8000']
+....
+
+You can download the dashboard json files and use https://grafana.com/tutorials/provision-dashboards-and-data-sources/[Grafana provision] to make the metrics datasource and dashboards available after container creation. [Insert link to Prometheus json files.]
+
+Update the https://github.com/grafana/grafana/blob/master/conf/sample.ini[grafana.ini] configuration file in the ``/etc/grafana/grafana.ini`` to override default configuration options. You only need to change the provisioning folder path:
+
+```
+;provisioning = /etc/grafana/provisioning
+```
+
+Create the provisioning folder tree and copy all the dashboard json files to ``/provisioning/dashboards/james/``
+
+    |-- provisioning
+        |-- dashboards
+            |-- defaults.yml
+            |-- james
+        |-- datasources
+            |-- prometheus.yml

Review comment:
       This is different than the prometheus.yml described above right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] chibenwa commented on a change in pull request #373: JAMES-3405 Add Prometheus config

Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #373:
URL: https://github.com/apache/james-project/pull/373#discussion_r611569503



##########
File path: docs/modules/servers/pages/distributed/operate/metrics.adoc
##########
@@ -7,16 +7,101 @@ for keeping track of some core metrics of James.
 Such metrics are made available via JMX. You can connect for instance using VisualVM and the associated
 mbean plugins.
 
-You can also export the metrics to ElasticSearch and visualize them with https://grafana.com/[Grafana].
-See xref:distributed/configure/elasticsearch.adoc#_exporting_metrics_directly_to_elasticsearch[elaticseach.properties]
-documentation for more details on how to set this up.
+We also support displaying them via https://grafana.com/[Grafana]. Two methods can be used to back grafana display:
 
-If some metrics seem abnormally slow despite in depth database
-performance tuning, feedback is appreciated as well on the bug tracker,
-the user mailing list or our Gitter channel (see our
-http://james.apache.org/#second[community page]) . Any additional
-details categorizing the slowness are appreciated as well (details of
-the slow requests for instance).
+ - Prometheus metric collection - Data are exposed on a HTTP endpoint for Prometheus scrape.
+ - ElasticSearch metric collection - This method is depreciated and will be removed in next version.
+ 
+== Expose metrics for Prometheus collection
+
+Metrics can be exposed over HTTP and made available by using ``extensions.routes`` in James https://github.com/apache/james-project/blob/master/docs/modules/servers/pages/distributed/configure/webadmin.adoc[webadmin.properties] file:
+....
+extensions.routes=org.apache.james.webadmin.dropwizard.MetricsRoutes
+....
+You can test the result by accessing to: 
+....
+http://james_server:8000/metrics
+....
+
+== Running James with Prometheus
+
+Make the below changes to scrape job config in ``prometheus.yml`` to collect the data for Grafana dashboard.
+....
+global:
+  scrape_interval:     15s # Set the scrape interval to every 15 seconds. Default is every 1 minute.
+  evaluation_interval: 15s # Evaluate rules every 15 seconds. The default is every 1 minute.
+  # scrape_timeout is set to the global default (10s).
+
+alerting:
+  alertmanagers:
+  - static_configs:
+    - targets:
+      # - alertmanager:9093
+
+rule_files:
+  # - "first_rules.yml"
+  # - "second_rules.yml"
+
+scrape_configs:
+  # The job name is added as a label `job=<job_name>` to any timeseries scraped from this config.
+  - job_name: 'prometheus'
+    scrape_interval: 5s
+    static_configs:
+      - targets: ['localhost:9090']
+  - job_name: 'Apache James'
+    scrape_interval: 5s
+    metrics_path: /metrics
+    static_configs:
+      - targets: ['james:8000']
+....
+
+You can download the dashboard json files and use https://grafana.com/tutorials/provision-dashboards-and-data-sources/[Grafana provision] to make the metrics datasource and dashboards available after container creation. [Insert link to Prometheus json files.]
+
+Update the https://github.com/grafana/grafana/blob/master/conf/sample.ini[grafana.ini] configuration file in the ``/etc/grafana/grafana.ini`` to override default configuration options. You only need to change the provisioning folder path:
+
+```
+;provisioning = /etc/grafana/provisioning
+```
+
+Create the provisioning folder tree and copy all the dashboard json files to ``/provisioning/dashboards/james/``
+
+    |-- provisioning
+        |-- dashboards
+            |-- defaults.yml
+            |-- james
+        |-- datasources
+            |-- prometheus_ds.yml

Review comment:
       Can we know how to generate / where to get `prometheus_ds.yml` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] Arsnael commented on a change in pull request #373: JAMES-3405 Add Prometheus config

Posted by GitBox <gi...@apache.org>.
Arsnael commented on a change in pull request #373:
URL: https://github.com/apache/james-project/pull/373#discussion_r612102820



##########
File path: docs/modules/servers/pages/distributed/operate/metrics.adoc
##########
@@ -7,16 +7,101 @@ for keeping track of some core metrics of James.
 Such metrics are made available via JMX. You can connect for instance using VisualVM and the associated
 mbean plugins.
 
-You can also export the metrics to ElasticSearch and visualize them with https://grafana.com/[Grafana].
-See xref:distributed/configure/elasticsearch.adoc#_exporting_metrics_directly_to_elasticsearch[elaticseach.properties]
-documentation for more details on how to set this up.
+We also support displaying them via https://grafana.com/[Grafana]. Two methods can be used to back grafana display:
 
-If some metrics seem abnormally slow despite in depth database
-performance tuning, feedback is appreciated as well on the bug tracker,
-the user mailing list or our Gitter channel (see our
-http://james.apache.org/#second[community page]) . Any additional
-details categorizing the slowness are appreciated as well (details of
-the slow requests for instance).
+ - Prometheus metric collection - Data are exposed on a HTTP endpoint for Prometheus scrape.
+ - ElasticSearch metric collection - This method is depreciated and will be removed in next version.
+ 
+== Expose metrics for Prometheus collection
+
+Metrics can be exposed over HTTP and made available by using ``extensions.routes`` in James https://github.com/apache/james-project/blob/master/docs/modules/servers/pages/distributed/configure/webadmin.adoc[webadmin.properties] file:
+....
+extensions.routes=org.apache.james.webadmin.dropwizard.MetricsRoutes
+....
+You can test the result by accessing to: 
+....
+http://james_server:8000/metrics
+....
+
+== Running James with Prometheus
+
+Make the below changes to scrape job config in ``prometheus.yml`` to collect the data for Grafana dashboard.
+....
+global:
+  scrape_interval:     15s # Set the scrape interval to every 15 seconds. Default is every 1 minute.
+  evaluation_interval: 15s # Evaluate rules every 15 seconds. The default is every 1 minute.
+  # scrape_timeout is set to the global default (10s).
+
+alerting:
+  alertmanagers:
+  - static_configs:
+    - targets:
+      # - alertmanager:9093
+
+rule_files:
+  # - "first_rules.yml"
+  # - "second_rules.yml"
+
+scrape_configs:
+  # The job name is added as a label `job=<job_name>` to any timeseries scraped from this config.
+  - job_name: 'prometheus'
+    scrape_interval: 5s
+    static_configs:
+      - targets: ['localhost:9090']
+  - job_name: 'Apache James'
+    scrape_interval: 5s
+    metrics_path: /metrics
+    static_configs:
+      - targets: ['james:8000']
+....
+
+You can download the dashboard json files and use https://grafana.com/tutorials/provision-dashboards-and-data-sources/[Grafana provision] to make the metrics datasource and dashboards available after container creation. [Insert link to Prometheus json files.]

Review comment:
       `[Insert link to Prometheus json files.]` ? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] chibenwa commented on a change in pull request #373: JAMES-3405 Add Prometheus config

Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #373:
URL: https://github.com/apache/james-project/pull/373#discussion_r610474970



##########
File path: docs/modules/servers/pages/distributed/operate/metrics_es.adoc
##########
@@ -0,0 +1,195 @@
+= Distributed James Server &mdash; Metrics

Review comment:
       Why this file speaks about dropwizard in a file about ElasticSearch metric reporting?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] chibenwa commented on a change in pull request #373: JAMES-3405 Add Prometheus config

Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #373:
URL: https://github.com/apache/james-project/pull/373#discussion_r610473050



##########
File path: docs/modules/servers/pages/distributed/operate/metrics.adoc
##########
@@ -116,4 +159,37 @@ Import the different dashboards you want.
 You then need to enable reporting through ElasticSearch. Modify your
 James ElasticSearch configuration file accordingly. To help you doing
 this, you can take a look to
-https://github.com/apache/james-project/blob/master/dockerfiles/run/guice/cassandra/destination/conf/elasticsearch.properties[elasticsearch.properties].
\ No newline at end of file
+https://github.com/apache/james-project/blob/master/dockerfiles/run/guice/cassandra/destination/conf/elasticsearch.properties[elasticsearch.properties].
+
+== Running and configuring Prometheus/Grafana
+
+The following docker-compose.yml file will allow you to run a fresh prometheus/grafana montoring stack:
+
+....
+version: '3'
+
+services:
+  grafana:
+    image: grafana/grafana:latest
+    container_name: grafana
+    ports:
+      - "3000:3000"
+   # volumes:
+    #  - ./conf/grafana/grafana.ini:/etc/grafana/grafana.ini
+    #  - ./conf/grafana/provisioning:/etc/grafana/provisioning
+
+  prometheus:
+    image: prom/prometheus:latest
+    restart: unless-stopped
+    ports:
+      - "9090:9090"
+    volumes: #Map your scrape config to prometheus container.
+      - ./conf/prometheus/prometheus.yml:/etc/prometheus/prometheus.yml

Review comment:
       Where is the sample to the `prometheus.yml` file?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] chibenwa commented on a change in pull request #373: JAMES-3405 Add Prometheus config

Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #373:
URL: https://github.com/apache/james-project/pull/373#discussion_r611282456



##########
File path: docs/modules/servers/pages/distributed/run-docker.adoc
##########
@@ -10,20 +10,21 @@ When you try James this way, you will use the most current state of James.
 It will be configured to run with Cassandra & ElasticSearch.
 All those three components will be started with a single command.
 
-You can retrieve the docker-compose file :
+You can retrieve the docker-compose file : ( docker-compose file and james image name should be changed) 
 
-    $ wget https://raw.githubusercontent.com/apache/james-project/master/dockerfiles/run/docker-compose.yml
+    $ wget https://raw.githubusercontent.com/apache/james-project/master/dockerfiles/run/docker-compose-branch-master.yml
+   

Review comment:
       Revert changes to this file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] fiery06 commented on a change in pull request #373: JAMES-3405 Add Prometheus config

Posted by GitBox <gi...@apache.org>.
fiery06 commented on a change in pull request #373:
URL: https://github.com/apache/james-project/pull/373#discussion_r610476388



##########
File path: docs/modules/servers/pages/distributed/operate/metrics_es.adoc
##########
@@ -0,0 +1,195 @@
+= Distributed James Server &mdash; Metrics

Review comment:
       It was there at the first place lol. I'm cleaning the document.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] chibenwa commented on a change in pull request #373: JAMES-3405 Add Prometheus config

Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #373:
URL: https://github.com/apache/james-project/pull/373#discussion_r609579082



##########
File path: docs/modules/servers/pages/distributed/operate/metrics.adoc
##########
@@ -11,6 +11,49 @@ You can also export the metrics to ElasticSearch and visualize them with https:/
 See xref:distributed/configure/elasticsearch.adoc#_exporting_metrics_directly_to_elasticsearch[elaticseach.properties]
 documentation for more details on how to set this up.
 
+If you prefer Prometheus, metrics can also be exposed over HTTP and made available by using **extensions.routes** in https://github.com/apache/james-project/blob/master/docs/modules/servers/pages/distributed/configure/webadmin.adoc[webadmin.properties] file:

Review comment:
       The prometheus details needs needs to be in the prometheus section (below).
   
   Here we likely just should have a link to the below session.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] chibenwa commented on a change in pull request #373: JAMES-3405 Add Prometheus config

Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #373:
URL: https://github.com/apache/james-project/pull/373#discussion_r611568880



##########
File path: docs/modules/servers/pages/distributed/run-docker.adoc
##########
@@ -10,20 +10,21 @@ When you try James this way, you will use the most current state of James.
 It will be configured to run with Cassandra & ElasticSearch.
 All those three components will be started with a single command.
 
-You can retrieve the docker-compose file :

Review comment:
       I should see no modification in this file....




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org