[GitHub] [iceberg] rdblue edited a comment on pull request #3522: Build: Ensure checkstyle and all checks run for Spark PRs

[GitBox <gi...@apache.org>]

rdblue edited a comment on pull request #3522:
URL: https://github.com/apache/iceberg/pull/3522#issuecomment-968361658


   I don't think this is the right approach. We purposely disable checkstyle and others because those should be run in other workflows. That is the purpose of the "build-checks" job in `java-ci.yml`. Looks like that doesn't ensure all Spark and Flink versions are enabled, which is one reason why some of the checks were missing. In addition, it looks like the Java CI ignores spark and flink folders. I think the core tests should always run, even if only Spark is modified.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org