You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Lars Gullik Bjønnes <lg...@tandberg.com> on 2009/04/14 17:42:08 UTC
Make mailer.py send to NNTP and match logmsg on regex
This is a rather dirty patch (mailer.py did not lend itself to
modifications too nicely) that adds some more config vars to the conf
file:
For nntp handling:
nntp_hostname - the nntp server to send to
to_group - the newsgroup to send to
For bug/regex handling (f.ex. for sending to bugzilla):
bug_regex - the regex to match on
bug_multi - if to send multiple messages when the regex
matches more than once
bug_to_addr - where to send the matching messages
(possibly this can be dropped...)
The matching bug_reges should have one group that matches on bug id,
this id can be used in *_subject_prefix:
commit_subject_prefix = [Bug %(bugid)s] [%(repo)s]
If there are interest in cleaning this up for inclusion in subversion
I'll update against current trunk and try to clean it up further. As
it is now it is mostly FYI only.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1713817
Re: Make mailer.py send to NNTP and match logmsg on regex
Posted by Lars Gullik Bjønnes <lg...@tandberg.com>.
Edmund Wong <ed...@kdtc.net> writes:
| Btw, how would a username-password-required nntp server
| fit into your patch? From what I see, it expects an
| open nntp server. I'd think that'd be a great inclusion
| into the mailer.py. Again, that's just my $0.02.
would fit almost seamlessly I expect.
just a matter of handling
nntp_username
nntp_password
and using that when creating the connection to the news server.
(The news server mailer.py feature fits nicely into the current code.
I'll see if I can split my changes into (at least) two patches.)
--
Lgb
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1726550
Re: Make mailer.py send to NNTP and match logmsg on regex
Posted by Edmund Wong <ed...@kdtc.net>.
Hi Lars,
> This was not really a patch submission at all, but more of a request for
> interest.
But you did mention that it was a 'dirty patch', no? So there
is at least one person that's interested in having it included
in the trunk? Mind you, I don't know what you mean by 'dirty'.
To me, a patch is a patch.
>
> (You didn't just send me your pre-canned response to these kind of
> messages did you, without reading the message?)
>
I don't think that was a pre-canned response. But that's
just me. By even responding to your patch message, it
proves that there is interest in including it in the trunk,
so why waste time in doing it twice? You know your stuff
so it shouldn't be difficult for you to make a single-submission
patch. Me? It's evident it takes me a couple of tries;
but that's just because I'm a rookie in both Python and
C. And since mailer.py has superceded the commit-email.pl
(judging from the current trunk, this perl script is
gone), it makes even more sense to include more functionality
in mailer.py.
Btw, how would a username-password-required nntp server
fit into your patch? From what I see, it expects an
open nntp server. I'd think that'd be a great inclusion
into the mailer.py. Again, that's just my $0.02.
Edmund
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1724459
Re: Make mailer.py send to NNTP and match logmsg on regex
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Lars Gullik Bjønnes wrote on Wed, 15 Apr 2009 at 10:01 +0200:
> Gavin Baumanis <ga...@thespidernet.com> writes:
>
> > Hi Lars,
> >
> > Whether *everyone* agrees or not is almost irrelevant.
> >
> > It's always advisable to follow;
> > http://subversion.tigris.org/hacking.html#patches
> > when submitting any patch.
> >
> > As the patch submitter - you're in the best place to do this work,
> > because you inherently know the intent of the patch you propose.
> >
> > If you need assistance (with the code or with following the patch
> > submission guidelines), don't be shy to ask.
> > Most on the list, are almost to a fault, generous with their time for
> > mentoring.
>
> This was not really a patch submission at all, but more of a request for
> interest.
>
> If anyone (not everyone) is interested in seeing this functionality in
> mailer.py, then I'll work to make that happen with nice patches that
> follow every regulation you might have, but until then I won't bother.
>
If you don't want to follow the (simple) "regulations", we can't make
you. And I won't try.
But you can at least post a version of the patch cleaned up to the point
where people can pick it from the archives and apply it locally (*without*
their bosses vetoing them on grounds that "Even the author says it's
dirty!").
> (You didn't just send me your pre-canned response to these kind of
> messages did you, without reading the message?)
>
>
Gavin didn't.
And, by the way, accusing the person who was only trying to help you
doesn't help.
Daniel
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1725240
Re: Make mailer.py send to NNTP and match logmsg on regex
Posted by Lars Gullik Bjønnes <lg...@tandberg.com>.
Gavin Baumanis <ga...@thespidernet.com> writes:
| Hi Lars,
>
| Firstly, please don't take anything in my comments personally.
That would be hard as you don't know me and I don't know you.
| I am a little new to the role of Patch Manager (PM) here at the SVN
| project - so it could well be a case of;
| "I" need to learn something from this exchange.
| None the less - my reply is amongst your post.
>
| On 15/04/2009, at 6:01 PM, Lars Gullik Bjønnes wrote:
>
>> Gavin Baumanis <ga...@thespidernet.com> writes:
>>
>> | Hi Lars,
>>>
>> | Whether *everyone* agrees or not is almost irrelevant.
>>>
>> | It's always advisable to follow;
>> | http://subversion.tigris.org/hacking.html#patches
>> | when submitting any patch.
>>>
>> | As the patch submitter - you're in the best place to do this work,
>> | because you inherently know the intent of the patch you propose.
>>>
>> | If you need assistance (with the code or with following the patch
>> | submission guidelines), don't be shy to ask.
>> | Most on the list, are almost to a fault, generous with their time
>> for
>> | mentoring.
>>
>> This was not really a patch submission at all, but more of a request
>> for
>> interest.
>
| While technically you may well be right you did originally state;
>
>>> This is a rather dirty patch (mailer.py did not lend itself to
>>> modifications too nicely) that adds some more config vars to the conf
>>> file:
I see that I could have organized my message a bit better. Just
ordering would have helped heaps I guess.
| So, "This is rather a dirty patch".
| Means something other than this is a patch?
| Albeit one that is incomplete, may well require some comments /
| further work?
Means that this are how the features are currenctly
implemented, usable but not for applyinng. And the reason why it is
"rather a dirty patch" is because of the layer violations required by
the current inheritence tree (to many is-a relationships when has-a
would seem more proper.)
Also I wanted to show the patch just to show that my wanted changes
was not just fluff.
| And the advice to follow the patch submission rules, and to ask for
| help if needed was directed at how your ended your original email;
I do not really need any help in getting this kind of features into
mailer.py, but to do it in a (FMPOV) nice way can be a challenge and
require some discussion. (I am faily good with oo, but not
neccessarily in the context of python.)
>>> If there are interest in cleaning this up for inclusion in subversion
>>> I'll update against current trunk and try to clean it up further. As
>>> it is now it is mostly FYI only.
>
| My point being, that you're much more likely to receive comments about
| a patch submission if it is already in the "expected" format / style.
| And, if you needed help updating your ideas to a "real" patch
| submission - then you should feel at ease with asking for help.
| If you were to weight your work on wether or not your email received
| any comments - then you could well be waiting for a long time.
I was mainly fishing for comments like: "Such a feature would be nice
to have in mailer.py, please make a formal submission."
| A properly formatted submission is far more likely to be provided some
| attention, over one than that isn't - time being a rather expensive /
| valued commodity and the project being staffed by volunteers and all
| that...
And really... how far was my message really from a properly formatted
submission? (Properly formatted does not mean that the message is sound).
>> If anyone (not everyone) is interested in seeing this functionality in
>> mailer.py, then I'll work to make that happen with nice patches that
>> follow every regulation you might have, but until then I won't bother.
>>
>> (You didn't just send me your pre-canned response to these kind of
>> messages did you, without reading the message?)
>
| I don't do canned responses.
I guess it was the "*everyone*" that make me both think about
pre-canned and that you did not actally read the whole message.
At least I have gotten one positive response, so I'll invest some more
time on this feature(s).
--
Lgb
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1726478
Re: Make mailer.py send to NNTP and match logmsg on regex
Posted by Gavin Baumanis <ga...@thespidernet.com>.
Hi Lars,
Firstly, please don't take anything in my comments personally.
I am a little new to the role of Patch Manager (PM) here at the SVN
project - so it could well be a case of;
"I" need to learn something from this exchange.
None the less - my reply is amongst your post.
On 15/04/2009, at 6:01 PM, Lars Gullik Bjønnes wrote:
> Gavin Baumanis <ga...@thespidernet.com> writes:
>
> | Hi Lars,
>>
> | Whether *everyone* agrees or not is almost irrelevant.
>>
> | It's always advisable to follow;
> | http://subversion.tigris.org/hacking.html#patches
> | when submitting any patch.
>>
> | As the patch submitter - you're in the best place to do this work,
> | because you inherently know the intent of the patch you propose.
>>
> | If you need assistance (with the code or with following the patch
> | submission guidelines), don't be shy to ask.
> | Most on the list, are almost to a fault, generous with their time
> for
> | mentoring.
>
> This was not really a patch submission at all, but more of a request
> for
> interest.
While technically you may well be right you did originally state;
>> This is a rather dirty patch (mailer.py did not lend itself to
>> modifications too nicely) that adds some more config vars to the conf
>> file:
So, "This is rather a dirty patch".
Means something other than this is a patch?
Albeit one that is incomplete, may well require some comments /
further work?
And the advice to follow the patch submission rules, and to ask for
help if needed was directed at how your ended your original email;
>> If there are interest in cleaning this up for inclusion in subversion
>> I'll update against current trunk and try to clean it up further. As
>> it is now it is mostly FYI only.
My point being, that you're much more likely to receive comments about
a patch submission if it is already in the "expected" format / style.
And, if you needed help updating your ideas to a "real" patch
submission - then you should feel at ease with asking for help.
If you were to weight your work on wether or not your email received
any comments - then you could well be waiting for a long time.
A properly formatted submission is far more likely to be provided some
attention, over one than that isn't - time being a rather expensive /
valued commodity and the project being staffed by volunteers and all
that...
>
>
> If anyone (not everyone) is interested in seeing this functionality in
> mailer.py, then I'll work to make that happen with nice patches that
> follow every regulation you might have, but until then I won't bother.
>
> (You didn't just send me your pre-canned response to these kind of
> messages did you, without reading the message?)
I don't do canned responses.
While the job of PM here in the subversion project is pretty light
work really, a part of that role is to see all patch submissions
through to fruition.
Whether that end be; Successful commit into the project or the patch
is rejected due to an appropriate reason or the patch gets filed away
into the issue tracker so that it (the submission) isn't a totally
wasted effort.
And to that, I have done and will continue to offer the advice that
all patch submissions should be in the appropriate format, should have
an appropriate log message and if you need any help, just ask. After
all, the mailing list and it's contributors are here to help you.
Regardless, of the intent of your email (they way you meant for it to
be handled), as opposed to how it was - the advice is sound.
Finally, since your original email wasn't really a patch submission -
I suppose it's all really a mute point.
Gavin.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1725373
Re: Make mailer.py send to NNTP and match logmsg on regex
Posted by Lars Gullik Bjønnes <la...@gullik.org>.
Gavin Baumanis <ga...@thespidernet.com> writes:
| Hi Lars,
>
| Whether *everyone* agrees or not is almost irrelevant.
>
| It's always advisable to follow;
| http://subversion.tigris.org/hacking.html#patches
| when submitting any patch.
>
| As the patch submitter - you're in the best place to do this work,
| because you inherently know the intent of the patch you propose.
>
| If you need assistance (with the code or with following the patch
| submission guidelines), don't be shy to ask.
| Most on the list, are almost to a fault, generous with their time for
| mentoring.
This was not really a patch submission at all, but more of a request for
interest.
If anyone (not everyone) is interested in seeing this functionality in
mailer.py, then I'll work to make that happen with nice patches that
follow every regulation you might have, but until then I won't bother.
(You didn't just send me your pre-canned response to these kind of
messages did you, without reading the message?)
--
Lgb
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1723635
Re: Make mailer.py send to NNTP and match logmsg on regex
Posted by Gavin Baumanis <ga...@thespidernet.com>.
Hi Lars,
Whether *everyone* agrees or not is almost irrelevant.
It's always advisable to follow;
http://subversion.tigris.org/hacking.html#patches
when submitting any patch.
As the patch submitter - you're in the best place to do this work,
because you inherently know the intent of the patch you propose.
If you need assistance (with the code or with following the patch
submission guidelines), don't be shy to ask.
Most on the list, are almost to a fault, generous with their time for
mentoring.
Gavin.
On 15/04/2009, at 3:42 AM, Lars Gullik Bjønnes wrote:
> This is a rather dirty patch (mailer.py did not lend itself to
> modifications too nicely) that adds some more config vars to the conf
> file:
>
> For nntp handling:
>
> nntp_hostname - the nntp server to send to
> to_group - the newsgroup to send to
>
> For bug/regex handling (f.ex. for sending to bugzilla):
>
> bug_regex - the regex to match on
> bug_multi - if to send multiple messages when the regex
> matches more than once
> bug_to_addr - where to send the matching messages
> (possibly this can be dropped...)
>
>
> The matching bug_reges should have one group that matches on bug id,
> this id can be used in *_subject_prefix:
>
> commit_subject_prefix = [Bug %(bugid)s] [%(repo)s]
>
> If there are interest in cleaning this up for inclusion in subversion
> I'll update against current trunk and try to clean it up further. As
> it is now it is mostly FYI only.
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1713817
> <mailer-with-nntp-and-regex-support.diff>This is a rather dirty
> patch (mailer.py did not lend itself to
> modifications too nicely) that adds some more config vars to the conf
> file:
>
> For nntp handling:
>
> nntp_hostname - the nntp server to send to
> to_group - the newsgroup to send to
>
> For bug/regex handling (f.ex. for sending to bugzilla):
>
> bug_regex - the regex to match on
> bug_multi - if to send multiple messages when the regex
> matches more than once
> bug_to_addr - where to send the matching messages
> (possibly this can be dropped...)
>
>
> The matching bug_reges should have one group that matches on bug id,
> this id can be used in *_subject_prefix:
>
> commit_subject_prefix = [Bug %(bugid)s] [%(repo)s]
>
> If there are interest in cleaning this up for inclusion in subversion
> I'll update against current trunk and try to clean it up further. As
> it is now it is mostly FYI only.
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1713817
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1719151
Re: Make mailer.py send to NNTP and match logmsg on regex
Posted by Lars Gullik Bjønnes <lg...@tandberg.com>.
Lars Gullik Bjønnes <lg...@tandberg.com> writes:
[...]
| I'll break out a patch from my changes to only do the nntp stuff.
| That will make it easier to talk about and for me to know exacly what
| you are running.
This is against latest in trunk.
And only the NNTP part.
(It ended up being so similar to MailedOutput that I think some
unification is warranted.)
---------------
[general]
nntp_hostname = news
[defaults]
generate_diffs = none
from_addr = %(author)s@invalid.com
to_group = test
[maps]
---------------
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1750328
Re: Make mailer.py send to NNTP and match logmsg on regex
Posted by Jon Bendtsen <jb...@laerdal.dk>.
¨On 16/04/2009, at 15.01, Lars Gullik Bjønnes wrote:
> Jon Bendtsen <jb...@laerdal.dk> writes:
>
> [...]
> | I run:
> | ./nntp-mailer.py commit /data/svn 2343 /data/svn/bin/nntp/test-
> | mailer.conf
> | and i still get all data to stdout.
>
> nntp-mailer.py is just mailer.py with my patch applied, right?
yes, with the latest mailer.py revision, which might not be the same
revision that you are using.
> I cannot see why it is not working.
> I'll break out a patch from my changes to only do the nntp stuff.
> That will make it easier to talk about and for me to know exacly what
> you are running.
okay
JonB
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1747271
Re: Make mailer.py send to NNTP and match logmsg on regex
Posted by Lars Gullik Bjønnes <lg...@tandberg.com>.
Jon Bendtsen <jb...@laerdal.dk> writes:
[...]
>> Make sure that "mail_command" and "smtp_hostname" is not set in the
>> conf file.
| They are not set.
|
| frodo:/data/svn/bin/j/nntp# grep -v "#" test-mailer.conf
| [general]
|
| nntp_hostname = nntp.internal
|
| [defaults]
|
| to_group = test
|
| diff = /usr/bin/diff -u -L %(label_from)s -L %(label_to)s %(from)s %
| (to)s
|
| commit_subject_prefix = [svn]
|
| propchange_subject_prefix = [svn]
|
| lock_subject_prefix = [svn]
|
| unlock_subject_prefix = [svn]
|
| generate_diffs = add copy modify
|
| suppress_deletes = yes
|
|
| show_nonmatching_paths = yes
|
| [maps]
Looks ok.
| I run:
| ./nntp-mailer.py commit /data/svn 2343 /data/svn/bin/nntp/test-
| mailer.conf
| and i still get all data to stdout.
nntp-mailer.py is just mailer.py with my patch applied, right?
I cannot see why it is not working.
I'll break out a patch from my changes to only do the nntp stuff.
That will make it easier to talk about and for me to know exacly what
you are running.
--
Lgb
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1747069
Re: Make mailer.py send to NNTP and match logmsg on regex
Posted by Jon Bendtsen <jb...@laerdal.dk>.
On 16/04/2009, at 13.05, Lars Gullik Bjønnes wrote:
> Jon Bendtsen <jb...@laerdal.dk> writes:
>
> | On 14/04/2009, at 19.42, Lars Gullik Bjønnes wrote:
>>
>>> This is a rather dirty patch (mailer.py did not lend itself to
>>> modifications too nicely) that adds some more config vars to the
>>> conf
>>> file:
>>>
>>> For nntp handling:
>>>
>>> nntp_hostname - the nntp server to send to
>>> to_group - the newsgroup to send to
>>
> | How do i actually get it to post to a group? It just dumps to
> STDOUT.
>>
> | I tried making a map, but it still doesnt work.
>>
> | mailer.conf example(s) are wanted.
>
> In the general section:
>
> -------------------------
> [general]
>
> nntp_hostname = your.nntp.server
>
> [default]
> to_group = the.news.group.on.your.nntp.server
>
>
> -------------------------
>
> Make sure that "mail_command" and "smtp_hostname" is not set in the
> conf file.
They are not set.
frodo:/data/svn/bin/j/nntp# grep -v "#" test-mailer.conf
[general]
nntp_hostname = nntp.internal
[defaults]
to_group = test
diff = /usr/bin/diff -u -L %(label_from)s -L %(label_to)s %(from)s %
(to)s
commit_subject_prefix = [svn]
propchange_subject_prefix = [svn]
lock_subject_prefix = [svn]
unlock_subject_prefix = [svn]
generate_diffs = add copy modify
suppress_deletes = yes
show_nonmatching_paths = yes
[maps]
I run:
./nntp-mailer.py commit /data/svn 2343 /data/svn/bin/nntp/test-
mailer.conf
and i still get all data to stdout.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1745444
Re: Make mailer.py send to NNTP and match logmsg on regex
Posted by Lars Gullik Bjønnes <lg...@tandberg.com>.
Jon Bendtsen <jb...@laerdal.dk> writes:
| On 14/04/2009, at 19.42, Lars Gullik Bjønnes wrote:
>
>> This is a rather dirty patch (mailer.py did not lend itself to
>> modifications too nicely) that adds some more config vars to the conf
>> file:
>>
>> For nntp handling:
>>
>> nntp_hostname - the nntp server to send to
>> to_group - the newsgroup to send to
>
| How do i actually get it to post to a group? It just dumps to STDOUT.
>
| I tried making a map, but it still doesnt work.
>
| mailer.conf example(s) are wanted.
In the general section:
-------------------------
[general]
nntp_hostname = your.nntp.server
[default]
to_group = the.news.group.on.your.nntp.server
-------------------------
Make sure that "mail_command" and "smtp_hostname" is not set in the
conf file.
I'll have an improved patch in not too long.
--
Lgb
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1745295
Re: Make mailer.py send to NNTP and match logmsg on regex
Posted by Jon Bendtsen <jb...@laerdal.dk>.
On 14/04/2009, at 19.42, Lars Gullik Bjønnes wrote:
> This is a rather dirty patch (mailer.py did not lend itself to
> modifications too nicely) that adds some more config vars to the conf
> file:
>
> For nntp handling:
>
> nntp_hostname - the nntp server to send to
> to_group - the newsgroup to send to
How do i actually get it to post to a group? It just dumps to STDOUT.
I tried making a map, but it still doesnt work.
mailer.conf example(s) are wanted.
JonB
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1744377
Re: Make mailer.py send to NNTP and match logmsg on regex
Posted by Jon Bendtsen <jb...@laerdal.dk>.
On 16/04/2009, at 15.43, Greg Stein wrote:
> On Thu, Apr 16, 2009 at 15:13, Jon Bendtsen <jb...@laerdal.dk>
> wrote:
>> On 16/04/2009, at 14.44, Greg Stein wrote:
>> ...
>>> I should take a look again at that stuff.
>>
>> Thank you, but are there no others who could provide feedback?
>
> WIth time and interest? ... Hard to say. I know that cmpilato has
> worked on mailer.py quite a bit.
Well, while it might take your time now, it might be worthwhile in the
longer run.
You see, if an outside developer feels that contributions are welcome
and they
are taken care of, then the outside developer might become an inside
developer
in time.
But if nothing happens, people tend to give up and go elsewhere.
> Hopefully, Gavin will start tracking your patches so they don't get
> lost in the cracks of the mailing list.
I could put them somewhere else?
>>> And yes, posting to NNTP makes sense to me. I originally designed
>>> the
>>> Output stuff to have flexibility in how messages are delivered. NTTP
>>> ought to just be another way to output the message.
>>
>> okay, so thats why it is you that reviews patches.
>
> Yup. It isn't that it is "my" code (it's the whole community's), but I
> am definitely interested in the problem space. The original
> commit-email.pl was (imo) ugly, and I wanted to use the Python
> bindings in a "real" application. Thus... mailer.py.
Ahh, i see.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1748024
Re: Make mailer.py send to NNTP and match logmsg on regex
Posted by Greg Stein <gs...@gmail.com>.
On Thu, Apr 16, 2009 at 15:13, Jon Bendtsen <jb...@laerdal.dk> wrote:
> On 16/04/2009, at 14.44, Greg Stein wrote:
>...
>> I should take a look again at that stuff.
>
> Thank you, but are there no others who could provide feedback?
WIth time and interest? ... Hard to say. I know that cmpilato has
worked on mailer.py quite a bit.
Hopefully, Gavin will start tracking your patches so they don't get
lost in the cracks of the mailing list.
>...
>> And yes, posting to NNTP makes sense to me. I originally designed the
>> Output stuff to have flexibility in how messages are delivered. NTTP
>> ought to just be another way to output the message.
>
> okay, so thats why it is you that reviews patches.
Yup. It isn't that it is "my" code (it's the whole community's), but I
am definitely interested in the problem space. The original
commit-email.pl was (imo) ugly, and I wanted to use the Python
bindings in a "real" application. Thus... mailer.py.
Cheers,
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1747791
Re: Make mailer.py send to NNTP and match logmsg on regex
Posted by Jon Bendtsen <jb...@laerdal.dk>.
On 16/04/2009, at 14.44, Greg Stein wrote:
> On Thu, Apr 16, 2009 at 10:13, Jon Bendtsen <jb...@laerdal.dk>
> wrote:
>> On 14/04/2009, at 19.42, Lars Gullik Bjønnes wrote:
>> ...
>>> If there are interest in cleaning this up for inclusion in
>>> subversion
>>> I'll update against current trunk and try to clean it up further. As
>>> it is now it is mostly FYI only.
>>
>> I am interested in applying it to my local copy. But i would really
>> prefer a clean patch.
>>
>> I would like to point out that i tried to use mailpost from inn2 to
>> post mailer.py mail messages (because i already email them) but
>> mailpost (or innd) did not like the Date header, because it did not
>> follow RFC 850 or RFC 2822.
>> inews failed: inews: cannot send article to server: 441 \
>> Can't parse "Date" header inews: article not posted
>>
>> Maybe you run into the same problem? Maybe the date thing has been
>> fixed. It was fixed for commit-email.pl, but i couldnt find a bug for
>> mailer.py
>
> Then there probably isn't a bug. I hadn't heard of this until now. Tho
> I was out of the dev loop for a number of years...
I can not reproduce the problem. I did have 3 messages from 5 April
2009, but today i tried posting another, and it worked fine. Looking
at the date header it was different. I will try again later.
>> About submitting patches to mailer.py. I made some a few months
>> ago. I
>> did get some feedback, i asked questions, there was some debate. In
>> the end i believe i did make the changes but nothing happened. I
>> still
>
> Yah. I got distracted by wc-ng work.
That can happen to anyone.
> I should take a look again at that stuff.
Thank you, but are there no others who could provide feedback?
>> think it was worthwhile because at least my developers that uses
>> mailer.py and subversion internally got some extra functionality that
>> they requested. If others doesnt want it, i dont mind. I would have
>> prefered to have it included such that I dont have to change my
>> patches as the mailer.py gets other new development.
>
> I liked the ideas, so we'll get it in. Just need to find some cycles
> when I'm not heads-down on working on wc-ng.
It's okay, i suppose open source projects always lacks developertime.
> And yes, posting to NNTP makes sense to me. I originally designed the
> Output stuff to have flexibility in how messages are delivered. NTTP
> ought to just be another way to output the message.
okay, so thats why it is you that reviews patches.
JonB
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1747253
Re: Make mailer.py send to NNTP and match logmsg on regex
Posted by Greg Stein <gs...@gmail.com>.
On Thu, Apr 16, 2009 at 10:13, Jon Bendtsen <jb...@laerdal.dk> wrote:
> On 14/04/2009, at 19.42, Lars Gullik Bjønnes wrote:
>...
>> If there are interest in cleaning this up for inclusion in subversion
>> I'll update against current trunk and try to clean it up further. As
>> it is now it is mostly FYI only.
>
> I am interested in applying it to my local copy. But i would really
> prefer a clean patch.
>
> I would like to point out that i tried to use mailpost from inn2 to
> post mailer.py mail messages (because i already email them) but
> mailpost (or innd) did not like the Date header, because it did not
> follow RFC 850 or RFC 2822.
> inews failed: inews: cannot send article to server: 441 \
> Can't parse "Date" header inews: article not posted
>
> Maybe you run into the same problem? Maybe the date thing has been
> fixed. It was fixed for commit-email.pl, but i couldnt find a bug for
> mailer.py
Then there probably isn't a bug. I hadn't heard of this until now. Tho
I was out of the dev loop for a number of years...
> About submitting patches to mailer.py. I made some a few months ago. I
> did get some feedback, i asked questions, there was some debate. In
> the end i believe i did make the changes but nothing happened. I still
Yah. I got distracted by wc-ng work.
I should take a look again at that stuff.
> think it was worthwhile because at least my developers that uses
> mailer.py and subversion internally got some extra functionality that
> they requested. If others doesnt want it, i dont mind. I would have
> prefered to have it included such that I dont have to change my
> patches as the mailer.py gets other new development.
I liked the ideas, so we'll get it in. Just need to find some cycles
when I'm not heads-down on working on wc-ng.
And yes, posting to NNTP makes sense to me. I originally designed the
Output stuff to have flexibility in how messages are delivered. NTTP
ought to just be another way to output the message.
Cheers,
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1746781
Re: Make mailer.py send to NNTP and match logmsg on regex
Posted by Jon Bendtsen <jb...@laerdal.dk>.
On 14/04/2009, at 19.42, Lars Gullik Bjønnes wrote:
[cuuuuuuuuuuut]
> If there are interest in cleaning this up for inclusion in subversion
> I'll update against current trunk and try to clean it up further. As
> it is now it is mostly FYI only.
I am interested in applying it to my local copy. But i would really
prefer a clean patch.
I would like to point out that i tried to use mailpost from inn2 to
post mailer.py mail messages (because i already email them) but
mailpost (or innd) did not like the Date header, because it did not
follow RFC 850 or RFC 2822.
inews failed: inews: cannot send article to server: 441 \
Can't parse "Date" header inews: article not posted
Maybe you run into the same problem? Maybe the date thing has been
fixed. It was fixed for commit-email.pl, but i couldnt find a bug for
mailer.py
About submitting patches to mailer.py. I made some a few months ago. I
did get some feedback, i asked questions, there was some debate. In
the end i believe i did make the changes but nothing happened. I still
think it was worthwhile because at least my developers that uses
mailer.py and subversion internally got some extra functionality that
they requested. If others doesnt want it, i dont mind. I would have
prefered to have it included such that I dont have to change my
patches as the mailer.py gets other new development.
JonB
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1742780
Re: Make mailer.py send to NNTP and match logmsg on regex
Posted by Jon Bendtsen <jb...@laerdal.dk>.
On 14/04/2009, at 19.42, Lars Gullik Bjønnes wrote:
[cuuuuuuuuut]
> If there are interest in cleaning this up for inclusion in subversion
> I'll update against current trunk and try to clean it up further. As
> it is now it is mostly FYI only.
I did not have any problems patching this against rev 37297.
I havent tried running it yet.
I would suggest that your patch also makes changes to the example
configuration file, so people can actually see what can be done.
JonB
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1743080