You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by dr...@apache.org on 2001/06/05 15:48:29 UTC
cvs commit: apr/locks/unix locks.c
dreid 01/06/05 06:48:28
Modified: locks/unix locks.c
Log:
One slipped through the rename, but got it now!
Revision Changes Path
1.50 +1 -1 apr/locks/unix/locks.c
Index: locks.c
===================================================================
RCS file: /home/cvs/apr/locks/unix/locks.c,v
retrieving revision 1.49
retrieving revision 1.50
diff -u -r1.49 -r1.50
--- locks.c 2001/06/05 13:22:45 1.49
+++ locks.c 2001/06/05 13:48:25 1.50
@@ -324,7 +324,7 @@
apr_status_t apr_os_lock_put(apr_lock_t **lock, apr_os_lock_t *thelock,
apr_pool_t *pool)
{
- if (cont == NULL) {
+ if (pool == NULL) {
return APR_ENOPOOL;
}
if ((*lock) == NULL) {
Re: cvs commit: apr/locks/unix locks.c
Posted by David Reid <dr...@jetnet.co.uk>.
Could be!
david
----- Original Message -----
From: "Ben Laurie" <be...@algroup.co.uk>
To: <de...@apr.apache.org>
Cc: <ap...@apache.org>
Sent: Tuesday, June 05, 2001 7:23 PM
Subject: Re: cvs commit: apr/locks/unix locks.c
> Isn't this another example where we should just die instead of returning
> an error?
>
> Cheers,
>
> Ben.
>
> dreid@apache.org wrote:
> >
> > dreid 01/06/05 06:48:28
> >
> > Modified: locks/unix locks.c
> > Log:
> > One slipped through the rename, but got it now!
> >
> > Revision Changes Path
> > 1.50 +1 -1 apr/locks/unix/locks.c
> >
> > Index: locks.c
> > ===================================================================
> > RCS file: /home/cvs/apr/locks/unix/locks.c,v
> > retrieving revision 1.49
> > retrieving revision 1.50
> > diff -u -r1.49 -r1.50
> > --- locks.c 2001/06/05 13:22:45 1.49
> > +++ locks.c 2001/06/05 13:48:25 1.50
> > @@ -324,7 +324,7 @@
> > apr_status_t apr_os_lock_put(apr_lock_t **lock, apr_os_lock_t
*thelock,
> > apr_pool_t *pool)
> > {
> > - if (cont == NULL) {
> > + if (pool == NULL) {
> > return APR_ENOPOOL;
> > }
> > if ((*lock) == NULL) {
> >
> >
> >
>
> --
> http://www.apache-ssl.org/ben.html
>
> "There is no limit to what a man can do or how far he can go if he
> doesn't mind who gets the credit." - Robert Woodruff
>
Re: cvs commit: apr/locks/unix locks.c
Posted by Cliff Woolley <cl...@yahoo.com>.
On Tue, 5 Jun 2001, Ben Laurie wrote:
> > apr_status_t apr_os_lock_put(apr_lock_t **lock, apr_os_lock_t *thelock,
> > apr_pool_t *pool)
> > {
> > - if (cont == NULL) {
> > + if (pool == NULL) {
> > return APR_ENOPOOL;
> > }
> > if ((*lock) == NULL) {
>
> Isn't this another example where we should just die instead of returning
> an error?
I think so, yes. Many of the APR_ENOfoo codes are on my hit-list. =-)
For example:
* APR_ENOPOOL APR was not provided a pool with which to allocate memory
* APR_ENOFILE APR was not given a file structure
* APR_ENOPROC APR was not given a process structure
* APR_ENOTIME APR was not given a time structure
* APR_ENODIR APR was not given a directory structure
* APR_ENOLOCK APR was not given a lock structure
* APR_ENOPOLL APR was not given a poll structure
* APR_ENOSOCKET APR was not given a socket
* APR_ENOTHREAD APR was not given a thread structure
* APR_ENOTHDKEY APR was not given a thread key structure
I'm equally hostile toward five or six of the other codes in there as
well, but these are a good enough example.
--Cliff
--------------------------------------------------------------
Cliff Woolley
cliffwoolley@yahoo.com
Charlottesville, VA
Re: cvs commit: apr/locks/unix locks.c
Posted by Ben Laurie <be...@algroup.co.uk>.
Isn't this another example where we should just die instead of returning
an error?
Cheers,
Ben.
dreid@apache.org wrote:
>
> dreid 01/06/05 06:48:28
>
> Modified: locks/unix locks.c
> Log:
> One slipped through the rename, but got it now!
>
> Revision Changes Path
> 1.50 +1 -1 apr/locks/unix/locks.c
>
> Index: locks.c
> ===================================================================
> RCS file: /home/cvs/apr/locks/unix/locks.c,v
> retrieving revision 1.49
> retrieving revision 1.50
> diff -u -r1.49 -r1.50
> --- locks.c 2001/06/05 13:22:45 1.49
> +++ locks.c 2001/06/05 13:48:25 1.50
> @@ -324,7 +324,7 @@
> apr_status_t apr_os_lock_put(apr_lock_t **lock, apr_os_lock_t *thelock,
> apr_pool_t *pool)
> {
> - if (cont == NULL) {
> + if (pool == NULL) {
> return APR_ENOPOOL;
> }
> if ((*lock) == NULL) {
>
>
>
--
http://www.apache-ssl.org/ben.html
"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff
Re: cvs commit: apr/locks/unix locks.c
Posted by Ben Laurie <be...@algroup.co.uk>.
Isn't this another example where we should just die instead of returning
an error?
Cheers,
Ben.
dreid@apache.org wrote:
>
> dreid 01/06/05 06:48:28
>
> Modified: locks/unix locks.c
> Log:
> One slipped through the rename, but got it now!
>
> Revision Changes Path
> 1.50 +1 -1 apr/locks/unix/locks.c
>
> Index: locks.c
> ===================================================================
> RCS file: /home/cvs/apr/locks/unix/locks.c,v
> retrieving revision 1.49
> retrieving revision 1.50
> diff -u -r1.49 -r1.50
> --- locks.c 2001/06/05 13:22:45 1.49
> +++ locks.c 2001/06/05 13:48:25 1.50
> @@ -324,7 +324,7 @@
> apr_status_t apr_os_lock_put(apr_lock_t **lock, apr_os_lock_t *thelock,
> apr_pool_t *pool)
> {
> - if (cont == NULL) {
> + if (pool == NULL) {
> return APR_ENOPOOL;
> }
> if ((*lock) == NULL) {
>
>
>
--
http://www.apache-ssl.org/ben.html
"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff