You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Daryn Sharp (JIRA)" <ji...@apache.org> on 2012/08/06 17:11:02 UTC
[jira] [Commented] (HADOOP-8649) ChecksumFileSystem should have an
overriding implementation of listStatus(Path, PathFilter)
[ https://issues.apache.org/jira/browse/HADOOP-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429184#comment-13429184 ]
Daryn Sharp commented on HADOOP-8649:
-------------------------------------
Good catch! In {{ChecksumFileSystem#listStatus(Path, PathFilter)}}:
# I question the null check, although useful, because {{FileSystems}} doesn't allow a null filter. This would make a {{FilterFileSystem}} behave differently. {{FileSystem}} itself should probably be changed to ignore a null since it appears to cause a NPE.
# The invocation order of the filters should be flipped from (user, default) to (default, user) to prevent a user supplied filter ever seeing a checksum file. I've seen user cases where the filter takes action on a matching path to avoid waiting for the entire listing to return.
> ChecksumFileSystem should have an overriding implementation of listStatus(Path, PathFilter)
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-8649
> URL: https://issues.apache.org/jira/browse/HADOOP-8649
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: HADOOP-8649_branch1.patch
>
>
> Currently, ChecksumFileSystem implements only listStatus(Path). The other form of listStatus(Path, PathFilter) is implemented by parent class FileSystem, and hence doesn't filter out check-sum files.
> The implementation should use a composite filter of passed Filter and the Checksum filter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira