[GitHub] iverase commented on a change in pull request #578: LUCENE-8699: Use fixed byte array in HeapPointWriter

[GitBox <gi...@apache.org>]

iverase commented on a change in pull request #578: LUCENE-8699: Use fixed byte array in HeapPointWriter
URL: https://github.com/apache/lucene-solr/pull/578#discussion_r258050800
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/util/bkd/PointWriter.java
 ##########
 @@ -32,9 +32,12 @@
   /** Add a new point from byte array*/
   void append(byte[] packedValue, int docID) throws IOException;
 
-  /** Add a new point from byteRef */
+  /** Add a new point from byteRef and docId */
 
 Review comment:
   I agree, and already though about removing the method that accept a byte array. I have done it now.
   I think for the second comment, I prefer to create a dedicated interface for packedValues and use that instead of bytesRef. The main driver for this method is to prevent deserialising and serialising the docId when copying points between OfflineWriters.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org