You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/02/21 01:40:46 UTC

[GitHub] [iotdb] sunjincheng121 opened a new pull request #2704: [IOTDB-1166] Remove redundant toString() calls

sunjincheng121 opened a new pull request #2704:
URL: https://github.com/apache/iotdb/pull/2704


   Remove redundant toString() calls,e.g,:
   
   `"Unknown operator: " + operatorType.toString()`-> `Unknown operator: " + operatorType`
   
   Any calls to toString() used in string concatenations and as arguments to the print() and println() methods of java.io.PrintWriter and java.io.PrintStream, the append() method of java.lang.StringBuilder and java.lang.StringBuffer or the trace(), debug(), info(), warn() and error() methods of org.slf4j.Logger. In these cases the conversion to string will be handled by the underlying library methods and an explicit call to toString() is no needed.
   
   And using `mvn spotless:check ` and `mvn spotless:apply` format code.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] jixuan1989 merged pull request #2704: [IOTDB-1166] Remove redundant toString() calls

Posted by GitBox <gi...@apache.org>.
jixuan1989 merged pull request #2704:
URL: https://github.com/apache/iotdb/pull/2704


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org