You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/12/07 16:09:27 UTC
[GitHub] [netbeans] JaroslavTulach opened a new pull request #3357: Updating HTML/Java API to 1.7.3 version
JaroslavTulach opened a new pull request #3357:
URL: https://github.com/apache/netbeans/pull/3357
[HTML/Java API](https://bits.netbeans.org/html+java/1.7.1/) has recently released its [1.7.3 version](https://lists.apache.org/thread/h6hzsm60ygodv5sz1c5q8xvjctwlqzy6) which (among other) gives proper OSGi bundle names to its modules. Former `generic` module is now `org.netbeans.html.presenters.spi`. Time to upgrade.
When at it, I am also splitting the `api.htmlui` module to two parts. The goal is to move the JavaFX WebView based implementation into its own module and allow the API to be used without it. That's all built around `HTMLViewerSpi` interface.
Also, to satisfy old @dbalek request, I am introducing `OnSubmit` callback that, allows validation of the state of the dialog before it is closed.
The commit c182fc33e409021950cdeba60bede1fe492a6348 modifies `nbjunit` module. I tried to use `MockServices` in TestNG without depending on JUnit4 and was getting linkage errors. Replacing the exceptions with `java.lang.AssertionError` fixes the problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3357: Updating HTML/Java API to 1.7.3 version
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #3357:
URL: https://github.com/apache/netbeans/pull/3357#discussion_r764526204
##########
File path: platform/o.n.html.presenters.spi/manifest.mf
##########
@@ -0,0 +1 @@
+OpenIDE-Module: generic
Review comment:
Fixed in 1b111c539faafa58665, thanks.
The missing rename went unnoticed as this is an _OSGi module_. It's build script contains `<target name="jar"/>` and as such the JAR is never built, but rather copied according to instructions in properties: `release.external/generic-1.7.3.jar=modules/org-netbeans-html-presenters-spi.jar`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #3357: Updating HTML/Java API to 1.7.3 version
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #3357:
URL: https://github.com/apache/netbeans/pull/3357#discussion_r764237795
##########
File path: platform/o.n.html.presenters.spi/manifest.mf
##########
@@ -0,0 +1 @@
+OpenIDE-Module: generic
Review comment:
Missing rename?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach merged pull request #3357: Updating HTML/Java API to 1.7.3 version
Posted by GitBox <gi...@apache.org>.
JaroslavTulach merged pull request #3357:
URL: https://github.com/apache/netbeans/pull/3357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists