You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2010/03/11 20:46:27 UTC

[jira] Created: (MAPREDUCE-1592) Generate Eclipse's .classpath file from Ivy config

Generate Eclipse's .classpath file from Ivy config
--------------------------------------------------

                 Key: MAPREDUCE-1592
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1592
             Project: Hadoop Map/Reduce
          Issue Type: Improvement
          Components: build
            Reporter: Tom White
            Assignee: Tom White


MapReduce companion issue for HADOOP-6407.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1592) Generate Eclipse's .classpath file from Ivy config

Posted by "Paolo Castagna (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849602#action_12849602 ] 

Paolo Castagna commented on MAPREDUCE-1592:
-------------------------------------------

The new patch does not copy .launch scripts, but it does not address the problem with the 15 contrib modules.

> Generate Eclipse's .classpath file from Ivy config
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1592
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1592
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tom White
>            Assignee: Tom White
>
> MapReduce companion issue for HADOOP-6407.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1592) Generate Eclipse's .classpath file from Ivy config

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated MAPREDUCE-1592:
---------------------------------

    Attachment: MAPREDUCE-1592.patch

> Generate Eclipse's .classpath file from Ivy config
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1592
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1592
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-1592.patch, MAPREDUCE-1592.patch, MAPREDUCE-1592.patch
>
>
> MapReduce companion issue for HADOOP-6407.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1592) Generate Eclipse's .classpath file from Ivy config

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated MAPREDUCE-1592:
---------------------------------

    Status: Patch Available  (was: Open)

> Generate Eclipse's .classpath file from Ivy config
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1592
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1592
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-1592.patch, MAPREDUCE-1592.patch, MAPREDUCE-1592.patch
>
>
> MapReduce companion issue for HADOOP-6407.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1592) Generate Eclipse's .classpath file from Ivy config

Posted by "bc Wong (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862052#action_12862052 ] 

bc Wong commented on MAPREDUCE-1592:
------------------------------------

+1. Tried out the patch. It works, and resolves my earlier classpath errors.

> Generate Eclipse's .classpath file from Ivy config
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1592
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1592
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-1592.patch, MAPREDUCE-1592.patch, MAPREDUCE-1592.patch
>
>
> MapReduce companion issue for HADOOP-6407.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1592) Generate Eclipse's .classpath file from Ivy config

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated MAPREDUCE-1592:
---------------------------------

    Status: Open  (was: Patch Available)

> Generate Eclipse's .classpath file from Ivy config
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1592
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1592
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-1592.patch, MAPREDUCE-1592.patch, MAPREDUCE-1592.patch
>
>
> MapReduce companion issue for HADOOP-6407.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1592) Generate Eclipse's .classpath file from Ivy config

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929964#action_12929964 ] 

Tom White commented on MAPREDUCE-1592:
--------------------------------------

+1 works for me

> Generate Eclipse's .classpath file from Ivy config
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1592
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1592
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-1592.patch, MAPREDUCE-1592.patch, MAPREDUCE-1592.patch, MAPREDUCE-1592.patch
>
>
> MapReduce companion issue for HADOOP-6407.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1592) Generate Eclipse's .classpath file from Ivy config

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922181#action_12922181 ] 

Tom White commented on MAPREDUCE-1592:
--------------------------------------

Sorry that this patch got forgotten. I just tried it out and it still works for me ({{ant clean compile eclipse}}). The compile step is needed to generate the Avro classes in org.apache.hadoop.mapreduce.jobhistory. So I think we should commit this, probably to the 0.21 branch and trunk. Similarly for HDFS-1035.

> Generate Eclipse's .classpath file from Ivy config
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1592
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1592
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-1592.patch, MAPREDUCE-1592.patch, MAPREDUCE-1592.patch
>
>
> MapReduce companion issue for HADOOP-6407.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1592) Generate Eclipse's .classpath file from Ivy config

Posted by "Paolo Castagna (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paolo Castagna updated MAPREDUCE-1592:
--------------------------------------

    Status: Patch Available  (was: Open)

> Generate Eclipse's .classpath file from Ivy config
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1592
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1592
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-1592.patch
>
>
> MapReduce companion issue for HADOOP-6407.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1592) Generate Eclipse's .classpath file from Ivy config

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930018#action_12930018 ] 

Hudson commented on MAPREDUCE-1592:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #533 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/533/])
    

> Generate Eclipse's .classpath file from Ivy config
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1592
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1592
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tom White
>            Assignee: Tom White
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-1592.patch, MAPREDUCE-1592.patch, MAPREDUCE-1592.patch, MAPREDUCE-1592.patch
>
>
> MapReduce companion issue for HADOOP-6407.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1592) Generate Eclipse's .classpath file from Ivy config

Posted by "Paolo Castagna (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paolo Castagna updated MAPREDUCE-1592:
--------------------------------------

    Attachment: MAPREDUCE-1592.patch

> Generate Eclipse's .classpath file from Ivy config
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1592
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1592
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-1592.patch
>
>
> MapReduce companion issue for HADOOP-6407.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1592) Generate Eclipse's .classpath file from Ivy config

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850218#action_12850218 ] 

Tom White commented on MAPREDUCE-1592:
--------------------------------------

I was thinking we list the contrib source paths explicitly in build.xml. Does that sound reasonable?

> Generate Eclipse's .classpath file from Ivy config
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1592
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1592
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-1592.patch
>
>
> MapReduce companion issue for HADOOP-6407.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1592) Generate Eclipse's .classpath file from Ivy config

Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nigel Daley updated MAPREDUCE-1592:
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.22.0
     Release Note: Added support to auto-generate the Eclipse .classpath file from ivy.
           Status: Resolved  (was: Patch Available)

I just committed this.  Thanks Tom. (sorry, got the contributor name wrong in my commit msg)

> Generate Eclipse's .classpath file from Ivy config
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1592
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1592
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tom White
>            Assignee: Tom White
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-1592.patch, MAPREDUCE-1592.patch, MAPREDUCE-1592.patch, MAPREDUCE-1592.patch
>
>
> MapReduce companion issue for HADOOP-6407.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1592) Generate Eclipse's .classpath file from Ivy config

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850408#action_12850408 ] 

Hadoop QA commented on MAPREDUCE-1592:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12439755/MAPREDUCE-1592.patch
  against trunk revision 927995.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 13 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/62/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/62/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/62/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/62/console

This message is automatically generated.

> Generate Eclipse's .classpath file from Ivy config
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1592
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1592
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-1592.patch
>
>
> MapReduce companion issue for HADOOP-6407.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1592) Generate Eclipse's .classpath file from Ivy config

Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nigel Daley updated MAPREDUCE-1592:
-----------------------------------

    Attachment: MAPREDUCE-1592.patch

Made a small change to the patch to use ${build.dir} variable when defining build.dir.eclipse

> Generate Eclipse's .classpath file from Ivy config
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1592
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1592
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-1592.patch, MAPREDUCE-1592.patch, MAPREDUCE-1592.patch, MAPREDUCE-1592.patch
>
>
> MapReduce companion issue for HADOOP-6407.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1592) Generate Eclipse's .classpath file from Ivy config

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated MAPREDUCE-1592:
---------------------------------

    Attachment: MAPREDUCE-1592.patch

Here's a patch that includes the contrib source paths (except the ones for the eclipse-plugin and index, since these didn't compile - I didn't look into why at this point). It also keeps the code to install the launch files that are in .eclipse.templates/.launches.

> Generate Eclipse's .classpath file from Ivy config
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1592
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1592
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-1592.patch, MAPREDUCE-1592.patch
>
>
> MapReduce companion issue for HADOOP-6407.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1592) Generate Eclipse's .classpath file from Ivy config

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861723#action_12861723 ] 

Hadoop QA commented on MAPREDUCE-1592:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12443036/MAPREDUCE-1592.patch
  against trunk revision 938779.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 33 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/150/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/150/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/150/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/150/console

This message is automatically generated.

> Generate Eclipse's .classpath file from Ivy config
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1592
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1592
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-1592.patch, MAPREDUCE-1592.patch, MAPREDUCE-1592.patch
>
>
> MapReduce companion issue for HADOOP-6407.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1592) Generate Eclipse's .classpath file from Ivy config

Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921971#action_12921971 ] 

Nigel Daley commented on MAPREDUCE-1592:
----------------------------------------

Tom, are we going to go with this solution or should I submit a patch for .eclipse.templates/.classpath?  It's woefully out of date.

> Generate Eclipse's .classpath file from Ivy config
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1592
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1592
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-1592.patch, MAPREDUCE-1592.patch, MAPREDUCE-1592.patch
>
>
> MapReduce companion issue for HADOOP-6407.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1592) Generate Eclipse's .classpath file from Ivy config

Posted by "Paolo Castagna (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849600#action_12849600 ] 

Paolo Castagna commented on MAPREDUCE-1592:
-------------------------------------------

>From duplicate issue MAPREDUCE-1619:

bq. We should include source paths for the Java source (including tests) for each contrib module.

I followed the approach in HADOOP-6407 which does not include contrib modules.
There are 15 contrib modules and I do not see an easy way to automate this.

bq. I don't think the copy task is needed in the new eclipse target.

I left it there to copy .launch scripts, but it can be removed if you think it's better.

> Generate Eclipse's .classpath file from Ivy config
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1592
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1592
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tom White
>            Assignee: Tom White
>
> MapReduce companion issue for HADOOP-6407.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.