You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/11 06:12:33 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #1744: fix: use image of APISIX on docker hub instead of build from dockerfile
nic-chen opened a new pull request #1744:
URL: https://github.com/apache/apisix-dashboard/pull/1744
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Due to the unavailability of the luarocks service, the image from the dockerfile build APISIX failed, which affected the back-end e2e test. So instead use the image on the docker hub to run the e2e test environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1744: fix: use image of APISIX on docker hub instead of build from dockerfile
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1744:
URL: https://github.com/apache/apisix-dashboard/pull/1744#discussion_r611142112
##########
File path: api/test/docker/docker-compose.yaml
##########
@@ -152,11 +153,12 @@ services:
apisix2:
hostname: apisix_server2
- build:
- context: ../../
- dockerfile: test/docker/Dockerfile-apisix
- args:
- - APISIX_VERSION=2.4
+ image: apache/apisix:2.4-alpine
+ # build:
Review comment:
Do we still need this configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1744: fix: use image of APISIX on docker hub instead of build from dockerfile
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #1744:
URL: https://github.com/apache/apisix-dashboard/pull/1744#discussion_r611142640
##########
File path: api/test/docker/docker-compose.yaml
##########
@@ -152,11 +153,12 @@ services:
apisix2:
hostname: apisix_server2
- build:
- context: ../../
- dockerfile: test/docker/Dockerfile-apisix
- args:
- - APISIX_VERSION=2.4
+ image: apache/apisix:2.4-alpine
+ # build:
Review comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun merged pull request #1744: fix: use image of APISIX on docker hub instead of build from dockerfile
Posted by GitBox <gi...@apache.org>.
LiteSun merged pull request #1744:
URL: https://github.com/apache/apisix-dashboard/pull/1744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org