You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by gi...@git.apache.org on 2017/05/09 13:27:03 UTC

[GitHub] priyankparihar commented on issue #1872: CLOUDSTACK-3223 Exception observed while creating CPVM in VMware Setup with DVS

priyankparihar commented on issue #1872: CLOUDSTACK-3223 Exception observed while creating CPVM in VMware Setup with DVS
URL: https://github.com/apache/cloudstack/pull/1872#issuecomment-300162980

Hi,
Code is tested on master branch. VR, SSVM, CPVM and User VM all are coming up properly.
"StartCommand failed due to Exception: com.vmware.vim25.AlreadyExists." is not observed during testing of this patch.

Test procedure followed
---
Breakpoint is placed before "Line 55: synchronized (uniquedvPortGroupPerDvs.intern())..".
Breakpoint is disabled when multiple threads arrives at barrier(Breakpoint).

This approach is followed, because earlier this issue was coming because of concurrent attempts to create same dv portgroup on same dvSwitch by manager threads of CPVM and SSVM when both are started at same time as mention in issue.

vSphere image PFA.
<img width="1280" alt="129" src="https://cloud.githubusercontent.com/assets/13674052/25852899/85fc3fb0-34e8-11e7-9ede-865572b21552.png">

I would like to give Test LGTM.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services