You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2023/01/13 20:24:33 UTC
[GitHub] [tinkerpop] tormodhau opened a new pull request, #1941: TINKERPOP-2853: Throw explaining exception when reading unsupported GraphBinary type
tormodhau opened a new pull request, #1941:
URL: https://github.com/apache/tinkerpop/pull/1941
Fixes: https://issues.apache.org/jira/browse/TINKERPOP-2853
When reading a non-registered custom type with GraphBinary, a generic exception is thrown:
System.Collections.Generic.KeyNotFoundException: The given key 'janusgraph.RelationIdentifier' was not
present in the dictionary.
Now the following exception gets thrown instead:
System.InvalidOperationException: No serializer found for type 'janusgraph.RelationIdentifier'
This is the same exception and message that gets throw when _writing_ a non-registered custom type.
The change has been verified by writing two new tests:
- One to document the added _read_ behaviour
- One to document the existing _write_ behaviour (which was undocumented)
And running the `Gremlin.Net` test suite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #1941: TINKERPOP-2853: Throw explaining exception when reading unsupported GraphBinary type
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1941:
URL: https://github.com/apache/tinkerpop/pull/1941#issuecomment-1382376699
# [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1941](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a0c5bb) into [master](https://codecov.io/gh/apache/tinkerpop/commit/4320add17fff518aac79379977c247dc4e3d7edf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4320add) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1941 +/- ##
============================================
+ Coverage 68.59% 68.60% +0.01%
- Complexity 9085 9088 +3
============================================
Files 854 854
Lines 41179 41179
Branches 5597 5597
============================================
+ Hits 28245 28252 +7
+ Misses 10954 10951 -3
+ Partials 1980 1976 -4
```
| [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...al/strategy/optimization/ProductiveByStrategy.java](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdHJhdGVneS9vcHRpbWl6YXRpb24vUHJvZHVjdGl2ZUJ5U3RyYXRlZ3kuamF2YQ==) | `78.57% <0.00%> (-8.93%)` | :arrow_down: |
| [...apache/tinkerpop/gremlin/server/GremlinServer.java](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9HcmVtbGluU2VydmVyLmphdmE=) | `56.09% <0.00%> (-1.96%)` | :arrow_down: |
| [...pache/tinkerpop/gremlin/driver/ConnectionPool.java](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9Db25uZWN0aW9uUG9vbC5qYXZh) | `29.54% <0.00%> (+0.64%)` | :arrow_up: |
| [...kergraph/process/computer/TinkerGraphComputer.java](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGlua2VyZ3JhcGgtZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vdGlua2VyZ3JhcGgvcHJvY2Vzcy9jb21wdXRlci9UaW5rZXJHcmFwaENvbXB1dGVyLmphdmE=) | `96.18% <0.00%> (+0.76%)` | :arrow_up: |
| [...in/process/traversal/dsl/graph/GraphTraversal.java](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9kc2wvZ3JhcGgvR3JhcGhUcmF2ZXJzYWwuamF2YQ==) | `91.02% <0.00%> (+0.96%)` | :arrow_up: |
| [...rg/apache/tinkerpop/gremlin/driver/Connection.java](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9Db25uZWN0aW9uLmphdmE=) | `63.75% <0.00%> (+1.25%)` | :arrow_up: |
| [...java/org/apache/tinkerpop/gremlin/driver/Host.java](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9Ib3N0LmphdmE=) | `37.77% <0.00%> (+2.22%)` | :arrow_up: |
| [.../gremlin/driver/exception/ConnectionException.java](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9leGNlcHRpb24vQ29ubmVjdGlvbkV4Y2VwdGlvbi5qYXZh) | `44.44% <0.00%> (+22.22%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk merged pull request #1941: TINKERPOP-2853: Throw explaining exception when reading unsupported GraphBinary type
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk merged PR #1941:
URL: https://github.com/apache/tinkerpop/pull/1941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1941: TINKERPOP-2853: Throw explaining exception when reading unsupported GraphBinary type
Posted by GitBox <gi...@apache.org>.
FlorianHockmann commented on PR #1941:
URL: https://github.com/apache/tinkerpop/pull/1941#issuecomment-1383647445
> I made the changes from master, which I now see is pretty far from apache:3.5-dev. Should I have started from 3.5-dev in the first place?
That would be ideal, yes. I guess the easiest way now is to do a soft reset of your commit, stash it and then (hard) reset your branch on `3.5-dev`. After that, it should be easy to apply your changes from the stash and commit it again. Lastly, you can force push your branch which should let this PR end up clean with just one commit that should be merged into `3.5-dev`.
If you need help with that, just say so.
Our branching strategy is that non-breaking changes, and especially bug fixes, should target the lowest release branch still supported. This is `3.5-dev` right now. We will then merge it into that branch and afterwards merge it into the other release branches (`3.6-dev` and `master`) so it ends in all upcoming releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] tormodhau commented on pull request #1941: TINKERPOP-2853: Throw explaining exception when reading unsupported GraphBinary type
Posted by "tormodhau (via GitHub)" <gi...@apache.org>.
tormodhau commented on PR #1941:
URL: https://github.com/apache/tinkerpop/pull/1941#issuecomment-1418820159
Thank you @Cole-Greer! That was a very nice solution. The target branch is now updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer commented on pull request #1941: TINKERPOP-2853: Throw explaining exception when reading unsupported GraphBinary type
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #1941:
URL: https://github.com/apache/tinkerpop/pull/1941#issuecomment-1416509263
Hi @tormodhau, are you still having trouble moving your branch over to 3.5-dev? Just to elaborate on Florian's suggestion, running the following should fix any issues:
```
git reset HEAD~1
git stash
git reset --hard 3.5-dev
git stash apply
git add gremlin-dotnet/
git commit -m "Throw explaining exception when reading unsupported GraphBinary type"
git push -f
```
Feel free to reach out if you have any other issues with submitting your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on pull request #1941: TINKERPOP-2853: Throw explaining exception when reading unsupported GraphBinary type
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #1941:
URL: https://github.com/apache/tinkerpop/pull/1941#issuecomment-1424715843
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] tormodhau commented on pull request #1941: TINKERPOP-2853: Throw explaining exception when reading unsupported GraphBinary type
Posted by GitBox <gi...@apache.org>.
tormodhau commented on PR #1941:
URL: https://github.com/apache/tinkerpop/pull/1941#issuecomment-1383611490
> Thanks for this contribution, @tormodhau! I didn't fully review it, but could you please change the base branch to `3.5-dev`? That way, we can easily merge the contribution into all release branches.
I made the changes from master, which I now see is pretty far from apache:3.5-dev. Should I have started from 3.5-dev in the first place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1941: TINKERPOP-2853: Throw explaining exception when reading unsupported GraphBinary type
Posted by GitBox <gi...@apache.org>.
FlorianHockmann commented on PR #1941:
URL: https://github.com/apache/tinkerpop/pull/1941#issuecomment-1383594004
Thanks for this contribution, @tormodhau! I didn't fully review it, but could you please change the base branch to `3.5-dev`? That way, we can easily merge the contribution into all release branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org