You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/05/24 16:21:21 UTC

[GitHub] [couchdb-ibrowse] noahshaw11 commented on a change in pull request #6: Change now/0 to timestamp/0

noahshaw11 commented on a change in pull request #6:
URL: https://github.com/apache/couchdb-ibrowse/pull/6#discussion_r638095535



##########
File path: src/ibrowse_http_client.erl
##########
@@ -465,7 +465,7 @@ accumulate_response(Data, #state{reply_buffer      = RepBuf,
 
 make_tmp_filename(true) ->
     DownloadDir = ibrowse:get_config_value(download_dir, filename:absname("./")),
-    {A,B,C} = now(),
+    {A,B,C} = timestamp(),

Review comment:
       I am using this one https://erlang.org/doc/man/erlang.html#timestamp-0 which is the recommended replacement for `now()` according to https://erlang.org/doc/apps/erts/time_correction.html#new-time-api.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org