You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by weitao zhou <zh...@gmail.com> on 2015/06/02 05:28:50 UTC
Review Request 34921: Code Refactor: float the bytes to get rid of the
truncate fraction part in function datasize.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34921/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Code Refactor: float the bytes to get rid of the truncate fraction part in function datasize.
Diffs
-----
src/cli/mesos-ps 8ca7a64d0ab6f0b8db823ca95d5f7500487b8753
Diff: https://reviews.apache.org/r/34921/diff/
Testing
-------
Thanks,
weitao zhou
Re: Review Request 34921: Code Refactor: float the bytes to get rid
of the truncate fraction part in function datasize.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34921/#review86202
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34921]
All tests passed.
- Mesos ReviewBot
On June 2, 2015, 3:28 a.m., weitao zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34921/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 3:28 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Code Refactor: float the bytes to get rid of the truncate fraction part in function datasize.
>
>
> Diffs
> -----
>
> src/cli/mesos-ps 8ca7a64d0ab6f0b8db823ca95d5f7500487b8753
>
> Diff: https://reviews.apache.org/r/34921/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> weitao zhou
>
>
Re: Review Request 34921: Code Refactor: float the bytes to get rid
of the truncate fraction part in function datasize.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34921/#review87117
-----------------------------------------------------------
src/cli/mesos-ps
<https://reviews.apache.org/r/34921/#comment139443>
Do you still need the fraction on "1024.0" with this? Maybe a note is needed:
```
// Ensure bytes is treated as floating point for the math below.
bytes = float(bytes)
...
```
- Ben Mahler
On June 2, 2015, 3:28 a.m., weitao zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34921/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 3:28 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Code Refactor: float the bytes to get rid of the truncate fraction part in function datasize.
>
>
> Diffs
> -----
>
> src/cli/mesos-ps 8ca7a64d0ab6f0b8db823ca95d5f7500487b8753
>
> Diff: https://reviews.apache.org/r/34921/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> weitao zhou
>
>
Re: Review Request 34921: Code Refactor: float the bytes to get rid
of the truncate fraction part in function datasize.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34921/#review87336
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On June 9, 2015, 2:58 a.m., weitao zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34921/
> -----------------------------------------------------------
>
> (Updated June 9, 2015, 2:58 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Code Refactor: float the bytes to get rid of the truncate fraction part in function datasize.
>
>
> Diffs
> -----
>
> src/cli/mesos-ps ae48c8cde31e90024381ed3e6e22ec3bc96560b6
>
> Diff: https://reviews.apache.org/r/34921/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> weitao zhou
>
>
Re: Review Request 34921: Code Refactor: float the bytes to get rid
of the truncate fraction part in function datasize.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34921/#review87126
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34921]
All tests passed.
- Mesos ReviewBot
On June 9, 2015, 2:58 a.m., weitao zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34921/
> -----------------------------------------------------------
>
> (Updated June 9, 2015, 2:58 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Code Refactor: float the bytes to get rid of the truncate fraction part in function datasize.
>
>
> Diffs
> -----
>
> src/cli/mesos-ps ae48c8cde31e90024381ed3e6e22ec3bc96560b6
>
> Diff: https://reviews.apache.org/r/34921/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> weitao zhou
>
>
Re: Review Request 34921: Code Refactor: float the bytes to get rid
of the truncate fraction part in function datasize.
Posted by weitao zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34921/
-----------------------------------------------------------
(Updated 六月 9, 2015, 2:58 a.m.)
Review request for mesos.
Repository: mesos
Description
-------
Code Refactor: float the bytes to get rid of the truncate fraction part in function datasize.
Diffs (updated)
-----
src/cli/mesos-ps ae48c8cde31e90024381ed3e6e22ec3bc96560b6
Diff: https://reviews.apache.org/r/34921/diff/
Testing
-------
Thanks,
weitao zhou