You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by gsmet <gi...@git.apache.org> on 2014/10/03 00:02:40 UTC
[GitHub] wicket pull request: WICKET-5717 Support fragment in Url parse and...
GitHub user gsmet opened a pull request:
https://github.com/apache/wicket/pull/78
WICKET-5717 Support fragment in Url parse and toString
Note: this PR is for the wicket-6.x branch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/openwide-java/wicket support-fragment-in-url
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/78.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #78
----
commit f35ae4303333ee741ca7dd517ed09647d1a28a1f
Author: Guillaume Smet <gu...@gmail.com>
Date: 2014-09-30T23:42:27Z
WICKET-5717 Support fragment in Url parse and toString
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: WICKET-5717 Support fragment in Url parse and...
Posted by gsmet <gi...@git.apache.org>.
Github user gsmet closed the pull request at:
https://github.com/apache/wicket/pull/78
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: WICKET-5717 Support fragment in Url parse and...
Posted by gsmet <gi...@git.apache.org>.
Github user gsmet commented on the pull request:
https://github.com/apache/wicket/pull/78#issuecomment-58620519
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: WICKET-5717 Support fragment in Url parse and...
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/78#issuecomment-58332442
After merging this PR to wicket-6.x the following tests fail:
```
Failed tests: optionPlaceholderDecode1(org.apache.wicket.core.request.mapper.MountedMapperTest)
optionPlaceholderDecodeEagerMatchParameters(org.apache.wicket.core.request.mapper.MountedMapperTest)
optionPlaceholderDecode2(org.apache.wicket.core.request.mapper.MountedMapperTest)
optionPlaceholderDecode3(org.apache.wicket.core.request.mapper.MountedMapperTest)
optionPlaceholderDecodeWithIndexParams(org.apache.wicket.core.request.mapper.MountedMapperTest)
optionPlaceholderEncode1(org.apache.wicket.core.request.mapper.MountedMapperTest): expected:<some/[p1/path/p2/i1/i2?a=b&b=c]> but was:<some/[/i1/i2?a=b&b=c¶m1=p1¶m2=p2]>
optionPlaceholderEncode2(org.apache.wicket.core.request.mapper.MountedMapperTest): expected:<some/[path/p2/p3/i1/i2?a=b&b=c]> but was:<some/[/i1/i2?a=b&b=c¶m2=p2¶m3=p3]>
```
I'll investigate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---