[GitHub] [incubator-superset] rusackas commented on pull request #9666: [fix] Support APP_ICON_WIDTH configuration parameter in SPA menu

[GitBox <gi...@apache.org>]

rusackas commented on pull request #9666:
URL: https://github.com/apache/incubator-superset/pull/9666#issuecomment-620389819


   > could you set the width in the config file to 126? Then we'll both have documentation of the config var existing, and can replace the `config.get` with a `config["APP_ICON_WIDTH"]` because we can always assume it exists
   
   It appears  `APP_ICON_WIDTH` is [already set to 126](https://github.com/apache/incubator-superset/blob/c474ea848a1c5e611d1b30301686aa83eb2cda06/superset/config.py#L183) in `config.py`.
   
   There are a handful of other config.get instances that pull in existing vars from `config.py` - I'm not sure how big an issue is, or if it should be blocking for this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org