[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16157: [Bug](exec) enable warning on ignoring function return value for vctx

[github-actions]

github-actions[bot] commented on code in PR #16157:
URL: https://github.com/apache/doris/pull/16157#discussion_r1089725536


##########
be/test/vec/exprs/vexpr_test.cpp:
##########
@@ -83,8 +86,11 @@ TEST(TEST_VEXPR, ABSTEST2) {
     DescriptorTbl desc_tbl;

Review Comment:
   warning: calling a private constructor of class 'doris::DescriptorTbl' [clang-diagnostic-error]
   ```cpp
       DescriptorTbl desc_tbl;
                     ^
   ```
   **be/src/runtime/descriptors.h:426:** declared private here
   ```cpp
       DescriptorTbl() = default;
       ^
   ```
   



##########
be/test/vec/exprs/vexpr_test.cpp:
##########
@@ -83,8 +86,11 @@
     DescriptorTbl desc_tbl;
     desc_tbl._slot_desc_map[0] = tuple_desc->slots()[0];

Review Comment:
   warning: '_slot_desc_map' is a private member of 'doris::DescriptorTbl' [clang-diagnostic-error]
   ```cpp
       desc_tbl._slot_desc_map[0] = tuple_desc->slots()[0];
                ^
   ```
   **be/src/runtime/descriptors.h:423:** declared private here
   ```cpp
       SlotDescriptorMap _slot_desc_map;
                         ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org