[GitHub] [geode-native] gaussianrecurrence commented on a change in pull request #772: GEODE-9056: Replace ACE_Semaphore

[GitBox <gi...@apache.org>]

gaussianrecurrence commented on a change in pull request #772:
URL: https://github.com/apache/geode-native/pull/772#discussion_r600704330



##########
File path: cppcache/src/TcrConnectionManager.cpp
##########
@@ -72,7 +72,7 @@ void TcrConnectionManager::init(bool isPool) {
   }
   auto &props = m_cache->getDistributedSystem().getSystemProperties();
   m_isDurable = !props.durableClientId().empty();
-  auto pingInterval = (props.pingInterval() / 2);
+  auto pingInterval = props.pingInterval();

Review comment:
       This is something interesting hehe. Thing is previous implementation called twice to semaphore acquire. The implementation was clearly wrong. But in order to solve the issue the ping interval was divided by 2, et voilà.
   
   So now the right interval is used and ping semaphore acquire is just called once.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org