[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8279: dns: packed dns_header_s and dns_question_s

["pkarashchenko (via GitHub)" <gi...@apache.org>]

pkarashchenko commented on code in PR #8279:
URL: https://github.com/apache/nuttx/pull/8279#discussion_r1088802615


##########
include/nuttx/net/dns.h:
##########
@@ -147,15 +147,15 @@ struct dns_header_s
   uint16_t numanswers;
   uint16_t numauthrr;
   uint16_t numextrarr;
-};
+}end_packed_struct;

Review Comment:
   ```suggestion
   } end_packed_struct;
   ```



##########
include/nuttx/net/dns.h:
##########
@@ -147,15 +147,15 @@ struct dns_header_s
   uint16_t numanswers;
   uint16_t numauthrr;
   uint16_t numextrarr;
-};
+}end_packed_struct;
 
 /* The DNS question message structure */
 
-struct dns_question_s
+begin_packed_struct struct dns_question_s
 {
   uint16_t type;
   uint16_t class;
-};
+}end_packed_struct;

Review Comment:
   ```suggestion
   } end_packed_struct;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org