You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/06/13 15:00:41 UTC

[GitHub] [commons-lang] garydgregory commented on a change in pull request #542: [LANG-1557] change a Pattern to a static final field, for not letting it compile each time the function invoked.

garydgregory commented on a change in pull request #542:
URL: https://github.com/apache/commons-lang/pull/542#discussion_r439745405



##########
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##########
@@ -8186,6 +8186,8 @@ public static String strip(String str, final String stripChars) {
         return stripEnd(str, stripChars);
     }
 
+    private static final Pattern STRIP_ACCENTS_PATTERN = Pattern.compile("\\p{InCombiningDiacriticalMarks}+"); //$NON-NLS-1$

Review comment:
       All constants live at the top of the file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org