You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2013/02/07 11:25:52 UTC

[Bug 54535] New: [PATCH] Bug in INTERCEPT and SLOPE

https://issues.apache.org/bugzilla/show_bug.cgi?id=54535

            Bug ID: 54535
           Summary: [PATCH] Bug in INTERCEPT and SLOPE
           Product: POI
           Version: unspecified
          Hardware: PC
                OS: Mac OS X 10.4
            Status: NEW
          Severity: normal
          Priority: P2
         Component: POI Overall
          Assignee: dev@poi.apache.org
          Reporter: johan.karlsteen@gmail.com
    Classification: Unclassified

Created attachment 29931
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29931&action=edit
Bugfix

Found a bug in INTERCEPT and SLOPE that makes them unusable.

They are flipping x and y values so the result is wrong.

Small fix in LinearRegressionFunction.java and the test cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 54535] [PATCH] Bug in INTERCEPT and SLOPE

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54535

Nick Burch <ap...@gagravarr.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 54535] [PATCH] Bug in INTERCEPT and SLOPE

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54535

--- Comment #2 from Nick Burch <ap...@gagravarr.org> ---
Also, any chance you could re-do the patch without the Java 1.6 @Overrides? POI
currently only requires 1.5, and your patch therefore introduces compiler
errors when built with JDK 1.5...

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 54535] [PATCH] Bug in INTERCEPT and SLOPE

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54535

Cédric Walter <ce...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Cédric Walter <ce...@gmail.com> ---
review and integration test added to FormulaEvalTestData.xls
merged in trunk revision 1538772

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 54535] [PATCH] Bug in INTERCEPT and SLOPE

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54535

Nick Burch <ap...@gagravarr.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #6 from Nick Burch <ap...@gagravarr.org> ---
Looks like this was closed in error - the patch still needs to be reviewed and
applied before the bug is considered "fixed"

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 54535] [PATCH] Bug in INTERCEPT and SLOPE

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54535

Johan <jo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29931|0                           |1
        is obsolete|                            |

--- Comment #4 from Johan <jo...@gmail.com> ---
Created attachment 30537
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30537&action=edit
Bugfix

New version of the patch without @Override.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 54535] [PATCH] Bug in INTERCEPT and SLOPE

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54535

Nick Burch <ap...@gagravarr.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #1 from Nick Burch <ap...@gagravarr.org> ---
Would you be able to suggest some entries for FormulaEvalTestData.xls to cover
these two functions?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 54535] [PATCH] Bug in INTERCEPT and SLOPE

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54535

--- Comment #5 from Johan <jo...@gmail.com> ---
Created attachment 30538
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30538&action=edit
Additions to FormulaEvalTestData.xls

Added the following test cases to FormulaEvalTestData.xls:

Slope    FORMULA    =SLOPE(K7:K10,L7:L10)    =SLOPE(L7:L10,K7:K10)
    EXPECTED VALUE    0.846451557    1.09971

Intercept    FORMULA    =INTERCEPT(K7:K10,L7:L10)    =INTERCEPT(L7:L10,K7:K10)
    EXPECTED VALUE    -0.039545124    0.25095

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 54535] [PATCH] Bug in INTERCEPT and SLOPE

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54535

--- Comment #3 from Johan <jo...@gmail.com> ---
Sorry for the incredible bad response on my part. 

I have checked out a fresh copy of the trunk and to my understanding the patch
is already applied?

I'm happy to remove the @Overrides and create a test case in the XLS file,
should I do it as a new patch?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 54535] [PATCH] Bug in INTERCEPT and SLOPE

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54535

Johan <jo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org